Re: [OpenWrt-Devel] [PATCH] base-files: load_kernelmodules()

2011-09-20 Thread Bastian Bittorf
I would rather let it accept an argument so the day we change the path we don't have to change the function and just replace occurences of the script instead. Are you agree with patch6, which implements this? As far I can see, only one script (/etc/init.d/boot) uses this function. Will

Re: [OpenWrt-Devel] [PATCH] base-files: load_kernelmodules()

2011-09-20 Thread Florian Fainelli
On Tuesday 20 September 2011 13:32:52 Bastian Bittorf wrote: I would rather let it accept an argument so the day we change the path we don't have to change the function and just replace occurences of the script instead. Are you agree with patch6, which implements this? I think patch

Re: [OpenWrt-Devel] [PATCH] base-files: load_kernelmodules()

2011-09-20 Thread Bastian Bittorf
I think patch 6 proposes too much configurability, so let's just do it that way instead: function load_modules() { local dir=${1:-/etc/modules.d} ... } This is the same like proposed, ist'nt it? Where is the difference? bye, Bastian