Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-03-01 Thread Bas Mevissen
On Sun, 2010-02-28 at 11:30 +0100, Stijn Tintel wrote: On 28-02-10 11:28, Stijn Tintel wrote: This patch allows multiple listen ports to be configured for dropbear in /etc/config/dropbear. It renames the 'Port' option to 'Ports', so this will break existing configs. What looks more useful

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-03-01 Thread mail
On Mon, March 1, 2010 10:31, Bas Mevissen wrote: On Sun, 2010-02-28 at 11:30 +0100, Stijn Tintel wrote: On 28-02-10 11:28, Stijn Tintel wrote: This patch allows multiple listen ports to be configured for dropbear in /etc/config/dropbear. It renames the 'Port' option to 'Ports', so this

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-03-01 Thread Stijn Tintel
On 01-03-10 14:12, m...@maddes.net wrote: On Mon, March 1, 2010 10:31, Bas Mevissen wrote: On Sun, 2010-02-28 at 11:30 +0100, Stijn Tintel wrote: On 28-02-10 11:28, Stijn Tintel wrote: This patch allows multiple listen ports to be configured for dropbear in

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-03-01 Thread Bas Mevissen
On Mon, 2010-03-01 at 15:22 +0100, Stijn Tintel wrote: Since the above suggestion is OK for me, I'd suggest to just forget this patch :-) The patch itself is useful if someone wants to explore the possibilities of dropbear. There is a difference between two instances and one instance which

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-02-28 Thread Stijn Tintel
On 28-02-10 11:28, Stijn Tintel wrote: This patch allows multiple listen ports to be configured for dropbear in /etc/config/dropbear. It renames the 'Port' option to 'Ports', so this will break existing configs. Regards, Stijn ___ openwrt-devel

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-02-28 Thread Matthias Buecher / Germany
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Just my two cents: Maybe some OpenWrt team members can review if the option rename causes hassle to the normal end user. Multiple ports will be rarely used by normal users (same as with multiple instances), and advanced users should find out fast that

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-02-28 Thread edgar . soldin
Let's keep it simple and backward compatible. Change new config to ports but also add old port setting to this list. Something like: config_get ports ${section} Ports config_get port ${section} Port ports=$port $ports Perfect of course would be a log message telling deprecation of port setting

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-02-28 Thread Matthias Buecher / Germany
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 To me that's even more confusing. Either use port or ports, not both. Maddes On 28.02.2010 12:21, edgar.sol...@web.de wrote: Let's keep it simple and backward compatible. Change new config to ports but also add old port setting to this list.

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-02-28 Thread edgar . soldin
Don't missunderstand me please: I say switch to ports but don't break old configs by means of keeping port working in the background, maybe supported with a deprecation message for users with old config ;) .. ede On 28.02.2010 13:40, Matthias Buecher / Germany wrote: To me that's even more

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-02-28 Thread Stefan Monnier
This patch allows multiple listen ports to be configured for dropbear in /etc/config/dropbear. It renames the 'Port' option to 'Ports', so this will break existing configs. Shouldn't this be sent to the dropbear upstream maintainers? It doesn't seem specific to OpenWRT at all.

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-02-28 Thread mail
On Sun, February 28, 2010 21:58, Stefan Monnier wrote: This patch allows multiple listen ports to be configured for dropbear in /etc/config/dropbear. It renames the 'Port' option to 'Ports', so this will break existing configs. Shouldn't this be sent to the dropbear upstream maintainers? It

Re: [OpenWrt-Devel] [PATCH] dropbear: allow multiple listen ports to be configured

2010-02-28 Thread Stefan Monnier
No, as his patch only modifies OpenWrt scripts and uci. The functionality of multiple ports with only one DropBear instance is already in DropBear. Duh... sorry for being so dense, Stefan ___ openwrt-devel mailing list