Re: [OpenWrt-Devel] [PATCH] mac80211: fix WARN_ON_ONCE() caused by inbalanced set/clear of beacon enable bit.

2014-08-25 Thread John Crispin
On 25/08/2014 09:55, Yousong Zhou wrote: > As I deem myself not yet equipped with the necessary knowledge of all > three interface types of rt2x00 device, I should at this point say > "no, I am not sure". It's based on the following observation. same here, i don't know the 3 modes that well eithe

Re: [OpenWrt-Devel] [PATCH] mac80211: fix WARN_ON_ONCE() caused by inbalanced set/clear of beacon enable bit.

2014-08-25 Thread Yousong Zhou
Hi, John On 25 August 2014 14:24, John Crispin wrote: > Hi, > > On 25/08/2014 05:29, Yousong Zhou wrote: >> +-/* +-* Upload beacon to the H/W. >> This is only required on >> +- * USB devices. PCI devices fetch beacons >> periodically.

Re: [OpenWrt-Devel] [PATCH] mac80211: fix WARN_ON_ONCE() caused by inbalanced set/clear of beacon enable bit.

2014-08-24 Thread John Crispin
Hi, On 25/08/2014 05:29, Yousong Zhou wrote: > +-/* +-* Upload beacon to the H/W. > This is only required on > +- * USB devices. PCI devices fetch beacons periodically. > +- > */ +- if (rt2x00_is_usb(rt2x00dev)) +- > rt

[OpenWrt-Devel] [PATCH] mac80211: fix WARN_ON_ONCE() caused by inbalanced set/clear of beacon enable bit.

2014-08-24 Thread Yousong Zhou
A WARN_ON_ONCE() dump was triggered on a MT7620A based device with following config. Fixes ticket #17032. config wifi-iface option device radio0 option network lan option mode ap option ssid OpenWrt__T