Re: [OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-08 Thread Helmut Schaa
On Mon, Sep 7, 2015 at 6:19 PM, Steven Barth wrote: > NAK. > Not many package build systems honors CPPFLAGS so this solution is > impractical, > since it effectively disables fortification for many of them. > > To my knowledge c-ares is the only package enforcing this kind of

Re: [OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-08 Thread Stefan Peter
Hi Am 07.09.2015 um 17:32 schrieb Helmut Schaa: > Fix the following configure error with c-ares by using CPPFLAGS for > -D_FORTIFY_SOURCE. > Not sure if any other packages suffer from the same issue. > > configure: using CFLAGS: -Os -pipe -march=74kc -fno-caller-saves > -mno-branch-likely -g3

Re: [OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-08 Thread Helmut Schaa
On Tue, Sep 8, 2015 at 9:03 AM, Stefan Peter wrote: > Hi > Am 07.09.2015 um 17:32 schrieb Helmut Schaa: >> Fix the following configure error with c-ares by using CPPFLAGS for >> -D_FORTIFY_SOURCE. >> Not sure if any other packages suffer from the same issue. >> >>

Re: [OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-08 Thread Karl Palsson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Helmut Schaa wrote: > On Tue, Sep 8, 2015 at 9:03 AM, Stefan Peter > wrote: > > Hi > > Am 07.09.2015 um 17:32 schrieb Helmut Schaa: > >> Fix the following configure error with c-ares by using

[OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-07 Thread Helmut Schaa
Fix the following configure error with c-ares by using CPPFLAGS for -D_FORTIFY_SOURCE. Not sure if any other packages suffer from the same issue. configure: using CFLAGS: -Os -pipe -march=74kc -fno-caller-saves -mno-branch-likely -g3 -fno-caller-saves -fhonour-copts

Re: [OpenWrt-Devel] [PATCH] openwrt/hardening: Fix CFLAGS usage for -D_FORTIFY_SOURCE

2015-09-07 Thread Steven Barth
NAK. Not many package build systems honors CPPFLAGS so this solution is impractical, since it effectively disables fortification for many of them. To my knowledge c-ares is the only package enforcing this kind of behavior so it should be fixed to work with our buildsystem instead.