Re: [OpenWrt-Devel] [PATCH 01/13] build metadata: Allow to build a subset of profiles in a single build

2016-01-19 Thread Felix Fietkau
On 2016-01-19 12:21, Daniel Dickinson wrote: >>> +# $(1) macro >>> +# $(2) macro parameter >>> +define BuildForProfiles >>> + $(foreach profile,$(PROFILES_BUILD),$(call $(1),$(2),$(profile))) >>> +endef >> Please don't call all the legacy Image/* code once per profile. >> This will generate unnece

Re: [OpenWrt-Devel] [PATCH 01/13] build metadata: Allow to build a subset of profiles in a single build

2016-01-19 Thread Daniel Dickinson
On 19/01/16 05:04 AM, Felix Fietkau wrote: [snip] [legacy UBI_OPTS targets] Please don't add extra abstractions to this code. The $(PROFILE)_UBI_OPTS stuff is legacy crap and any target still using it should just stay that way and not get multi-profile selection until it is converted to the

Re: [OpenWrt-Devel] [PATCH 01/13] build metadata: Allow to build a subset of profiles in a single build

2016-01-19 Thread Felix Fietkau
On 2016-01-19 03:50, open...@daniel.thecshore.com wrote: > From: Daniel Dickinson > > Certain platforms have large numbers of possible images, and it can be > desirable to build neither all images nor only a single image, > therefore this patch makes selecting target profiles a menu instead of a

[OpenWrt-Devel] [PATCH 01/13] build metadata: Allow to build a subset of profiles in a single build

2016-01-18 Thread openwrt
From: Daniel Dickinson Certain platforms have large numbers of possible images, and it can be desirable to build neither all images nor only a single image, therefore this patch makes selecting target profiles a menu instead of a single choice, which allows the user to build a specific subset of

[OpenWrt-Devel] [PATCH 01/13] build metadata: Allow to build a subset of profiles in a single build

2016-01-18 Thread openwrt
From: Daniel Dickinson Certain platforms have large numbers of possible images, and it can be desirable to build neither all images nor only a single image, therefore this patch makes selecting target profiles a menu instead of a single choice, which allows the user to build a specific subset of