[OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

2014-06-30 Thread Drasko DRASKOVIC
This patch adds WeIO board profile. WeIO is the new AR9331 MIPS based board for Internet of Things. Project web-site is: http://we-io.net/ From 82e77431e2b860f21da5540a84e7440764a49b39 Mon Sep 17 00:00:00 2001 From: Drasko DRASKOVIC drasko.drasko...@gmail.com Date: Sun, 9 Feb 2014 03:46:43 +0100

Re: [OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

2014-06-30 Thread John Crispin
Hi, please resend with the patches inline, it is not possible to comment when they are attached. also, my first impression is that the patches are really messy and the commit text only partially matches what is inside the patches. 1/4 seems to have a pile of unrelated white space fixes. 1/4

Re: [OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

2014-06-30 Thread Drasko DRASKOVIC
On Mon, Jun 30, 2014 at 2:09 PM, John Crispin j...@phrozen.org wrote: Hi, please resend with the patches inline, it is not possible to comment when they are attached. No problem, I will be re-sending the patches inline. also, my first impression is that the patches are really messy and the

Re: [OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

2014-06-30 Thread John Crispin
Hi, i would prefer it to be all in 1 patch with no unrelated whitespace fixes. that makes it less work to merge and its self contained. if there was more code then splitting it up might make sense, however its only a few lines that get patched ok, so it is the same uC as on the UBER ... i saw a

Re: [OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

2014-06-30 Thread Jonas Gorski
On Mon, Jun 30, 2014 at 2:26 PM, John Crispin j...@phrozen.org wrote: Hi, i would prefer it to be all in 1 patch with no unrelated whitespace fixes. that makes it less work to merge and its self contained. if there was more code then splitting it up might make sense, however its only a few

Re: [OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

2014-06-30 Thread Drasko DRASKOVIC
Hi all, signed-off squashed commit that introduces WeIO board support is sent to the list in a new thread. Best regards, Drasko On Mon, Jun 30, 2014 at 3:34 PM, Jonas Gorski j...@openwrt.org wrote: On Mon, Jun 30, 2014 at 2:26 PM, John Crispin j...@phrozen.org wrote: Hi, i would prefer it to

Re: [OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

2014-06-30 Thread John Crispin
thanks, i will have a look tonight or in the morning John On 30/06/2014 17:47, Drasko DRASKOVIC wrote: Hi all, signed-off squashed commit that introduces WeIO board support is sent to the list in a new thread. Best regards, Drasko On Mon, Jun 30, 2014 at 3:34 PM, Jonas Gorski

Re: [OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

2014-06-30 Thread Drasko DRASKOVIC
On Mon, Jun 30, 2014 at 2:26 PM, John Crispin j...@phrozen.org wrote: Hi, i would prefer it to be all in 1 patch with no unrelated whitespace fixes. that makes it less work to merge and its self contained. if there was more code then splitting it up might make sense, however its only a few