Re: [OpenWrt-Devel] [PATCH 2/2] generic at803x: remove unneeded patches

2020-01-21 Thread Christian Lamparter
Hello,

On Tue, Jan 21, 2020 at 9:11 PM David Bauer  wrote:
>
>  - Remove the "RGMII TX delay fixup" hack and the associated
>DT-property. It was never used in a DT-based platform and
>solved a problem which can be mitigated by using correct
>delays on the MAC side.
>
Can you tell us more about what are these correct
delay bits and where do I have to set them? :-D

Acked-by: Christian Lamparter 

Cheers,
Christian

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[OpenWrt-Devel] [PATCH 2/2] generic at803x: remove unneeded patches

2020-01-21 Thread David Bauer
 - Remove the "RGMII TX delay fixup" hack and the associated
   DT-property. It was never used in a DT-based platform and
   solved a problem which can be mitigated by using correct
   delays on the MAC side.

 - Remove the patch to enable platform-data support for the
   at803x driver. It was only used by ar71xx which does not
   (and never will) support kernel 4.19 or later.

 - Remove the SmartEEE DT-configuration patch. As explained
   previously, this patch never disabled the Atheros SmartEEE
   implementation, but rather "standard" EEE. This can be done
   on device-tree compatible platforms by adding the
   "eee-broken-1000t" or "eee-broken-100tx" properties to the PHY
   node. As all usages of the old properties are migrated, this
   patch can be removed.

Signed-off-by: David Bauer 
---
 ...phy-at803x-allow-to-configure-via-dt.patch |  47 --
 ...-at803x-allow-to-configure-via-pdata.patch | 142 --
 ...phy-at803x-allow-to-configure-via-dt.patch |  47 --
 3 files changed, 236 deletions(-)
 delete mode 100644 
target/linux/generic/pending-4.14/736-net-phy-at803x-allow-to-configure-via-dt.patch
 delete mode 100644 
target/linux/generic/pending-4.19/734-net-phy-at803x-allow-to-configure-via-pdata.patch
 delete mode 100644 
target/linux/generic/pending-4.19/736-net-phy-at803x-allow-to-configure-via-dt.patch

diff --git 
a/target/linux/generic/pending-4.14/736-net-phy-at803x-allow-to-configure-via-dt.patch
 
b/target/linux/generic/pending-4.14/736-net-phy-at803x-allow-to-configure-via-dt.patch
deleted file mode 100644
index 6bc626dd6a..00
--- 
a/target/linux/generic/pending-4.14/736-net-phy-at803x-allow-to-configure-via-dt.patch
+++ /dev/null
@@ -1,47 +0,0 @@
 a/drivers/net/phy/at803x.c
-+++ b/drivers/net/phy/at803x.c
-@@ -354,6 +354,14 @@ static int at803x_config_init(struct phy
-   AT803X_DEBUG_TX_CLK_DLY_EN, 0);
-   }
- 
-+#ifdef CONFIG_OF_MDIO
-+  if (phydev->mdio.dev.of_node &&
-+  of_property_read_bool(phydev->mdio.dev.of_node,
-+"at803x-disable-smarteee")) {
-+  at803x_disable_smarteee(phydev);
-+  }
-+#endif
-+
-   return 0;
- }
- 
-@@ -392,6 +400,7 @@ static void at803x_link_change_notify(st
- {
-   struct at803x_priv *priv = phydev->priv;
-   struct at803x_platform_data *pdata;
-+  u8 fixup_rgmii_tx_delay = 0;
-   pdata = dev_get_platdata(>mdio.dev);
- 
-   /*
-@@ -421,8 +430,19 @@ static void at803x_link_change_notify(st
-   } else {
-   priv->phy_reset = false;
-   }
--  if (pdata && pdata->fixup_rgmii_tx_delay &&
--  phydev->speed != priv->prev_speed) {
-+
-+  if (pdata && pdata->fixup_rgmii_tx_delay)
-+  fixup_rgmii_tx_delay = 1;
-+
-+#ifdef CONFIG_OF_MDIO
-+  if (phydev->mdio.dev.of_node &&
-+  of_property_read_bool(phydev->mdio.dev.of_node,
-+"at803x-fixup-rgmii-tx-delay")) {
-+  fixup_rgmii_tx_delay = 1;
-+  }
-+#endif
-+
-+  if (fixup_rgmii_tx_delay && phydev->speed != priv->prev_speed) {
-   switch (phydev->speed) {
-   case SPEED_10:
-   case SPEED_100:
diff --git 
a/target/linux/generic/pending-4.19/734-net-phy-at803x-allow-to-configure-via-pdata.patch
 
b/target/linux/generic/pending-4.19/734-net-phy-at803x-allow-to-configure-via-pdata.patch
deleted file mode 100644
index e56e77addf..00
--- 
a/target/linux/generic/pending-4.19/734-net-phy-at803x-allow-to-configure-via-pdata.patch
+++ /dev/null
@@ -1,142 +0,0 @@
-From: Gabor Juhos 
-Subject: net: phy: allow to configure AR803x PHYs via platform data
-
-Add a patch for the at803x phy driver, in order to be able
-to configure some register settings via platform data.
-
-Signed-off-by: Gabor Juhos 

- drivers/net/phy/at803x.c | 56 
- include/linux/platform_data/phy-at803x.h | 11 +++
- 2 files changed, 67 insertions(+)
- create mode 100644 include/linux/platform_data/phy-at803x.h
-
 a/drivers/net/phy/at803x.c
-+++ b/drivers/net/phy/at803x.c
-@@ -12,12 +12,14 @@
-  */
- 
- #include 
-+#include 
- #include 
- #include 
- #include 
- #include 
- #include 
- #include 
-+#include 
- 
- #define AT803X_INTR_ENABLE0x12
- #define AT803X_INTR_ENABLE_AUTONEG_ERRBIT(15)
-@@ -45,6 +47,11 @@
- #define AT803X_REG_CHIP_CONFIG0x1f
- #define AT803X_BT_BX_REG_SEL  0x8000
- 
-+#define AT803X_PCS_SMART_EEE_CTRL30x805D
-+#define AT803X_SMART_EEE_CTRL3_LPI_TX_DELAY_SEL_MASK  0x3
-+#define AT803X_SMART_EEE_CTRL3_LPI_TX_DELAY_SEL_SHIFT 12
-+#define AT803X_SMART_EEE_CTRL3_LPI_EN BIT(8)
-+
- #define AT803X_DEBUG_ADDR 0x1D
- #define AT803X_DEBUG_DATA 0x1E
- 
-@@ -73,6 +80,7 @@ MODULE_LICENSE("GPL");
- 
- struct at803x_priv {
-