Re: [OpenWrt-Devel] [patch] firewall feature

2010-03-01 Thread Nico
Just to be clear, it's not intended to be a selectable feature, it will just be defined if CONFIG_NETFILTER is defined in the target kernel config, like it is for the GPIO, PCI or USB features. What do you mean by migrate to the DEVICE_TYPE ? -- -{Nico} Imre Kaloz wrote: On Mon, 01 Mar 2010

Re: [OpenWrt-Devel] [patch] firewall feature

2010-03-01 Thread Imre Kaloz
On 2010.03.01. 12:34:03 Nico n...@openwrt.org wrote: Just to be clear, it's not intended to be a selectable feature, it will just be defined if CONFIG_NETFILTER is defined in the target kernel config, like it is for the GPIO, PCI or USB features. What do you mean by migrate to the DEVICE_TYPE

Re: [OpenWrt-Devel] [patch] firewall feature

2010-03-01 Thread Imre Kaloz
On 2010.03.02. 04:52:23 Nico n...@openwrt.org wrote: Well, using DEVICE_TYPE does not solve the issue, it will just prevent netfilter modules from being embedded in the final images, but wont prevent them from being built and that will just fail for those targets that have CONFIG_NETFILTER not

Re: [OpenWrt-Devel] [patch] firewall feature

2010-03-01 Thread mail
On Tue, March 2, 2010 07:10, Imre Kaloz wrote: On 2010.03.02. 04:52:23 Nico n...@openwrt.org wrote: Well, using DEVICE_TYPE does not solve the issue, it will just prevent netfilter modules from being embedded in the final images, but wont prevent them from being built and that will just fail

[OpenWrt-Devel] [patch] firewall feature

2010-02-28 Thread Nico
Hi devs, Any objections adding a firewall feature ? That would help preventing netfilter related modules and utilities from being build on systems where CONFIG_NETFILTER is not set ? Proposed patch attached Regards, -- -{Nico} Index: include/target.mk

Re: [OpenWrt-Devel] [patch] firewall feature

2010-02-28 Thread Imre Kaloz
On Mon, 01 Mar 2010 07:19:02 +0100, Nico n...@openwrt.org wrote: Hi, Any objections adding a firewall feature ? That would help preventing netfilter related modules and utilities from being build on systems where CONFIG_NETFILTER is not set ? Systems should either drop that setting or