Re: [PATCH] build: explicitly specify Makefile generator

2023-10-09 Thread Rosen Penev
On Mon, Oct 9, 2023 at 6:05 AM Eicke Herbertz wrote: > > > > > Where does that CMAKE_GENERATOR environment variable come from? Would > > it make sense to undefine it instead? > > > > Regards, > > Jonas > > Well, from the environment of my development machine. > I have it set to Ninja for a long

Re: [PATCH] build: explicitly specify Makefile generator

2023-10-09 Thread Eicke Herbertz
Where does that CMAKE_GENERATOR environment variable come from? Would it make sense to undefine it instead? Regards, Jonas Well, from the environment of my development machine. I have it set to Ninja for a long time on this system. Do you mean undefining it manually or as part of the build

Re: [PATCH] build: explicitly specify Makefile generator

2023-10-09 Thread Jonas Gorski
On Sun, 8 Oct 2023 at 18:56, wrote: > > From: Eicke Herbertz > > When CMAKE_GENERATOR environment variable is defined, CMake will use the > specified generator by default instead of "Unix Makefiles". > This breaks the build of packages setting PKG_USE_NINJA to 0, like > package/kernel/mt76.

[PATCH] build: explicitly specify Makefile generator

2023-10-08 Thread wolletd
From: Eicke Herbertz When CMAKE_GENERATOR environment variable is defined, CMake will use the specified generator by default instead of "Unix Makefiles". This breaks the build of packages setting PKG_USE_NINJA to 0, like package/kernel/mt76. Signed-off-by: Eicke Herbertz --- include/cmake.mk