Re: [PATCH] comgt: Move to community packages repo

2021-07-02 Thread Sergey Ryazanov
Hello Petr, On Fri, Jul 2, 2021 at 12:31 PM Petr Štetiar wrote: > Sergey Ryazanov [2021-06-29 02:07:16]: >> OTOH, Arjun has been trying to draw attention to the patch for comgt >> for a year. And no one reacted to his quite reasonable fix. > > As always, any additional `Tested-by` or

Re: [PATCH] comgt: Move to community packages repo

2021-07-02 Thread Petr Štetiar
Sergey Ryazanov [2021-06-29 02:07:16]: > OTOH, Arjun has been trying to draw attention to the patch for comgt > for a year. And no one reacted to his quite reasonable fix. As always, any additional `Tested-by` or `Reviewed-by` helps. Anyway, I've merged it already. -- ynezz

Re: [PATCH] comgt: Move to community packages repo

2021-06-30 Thread Alberto Bursi
On 28/06/21 22:51, Lech Perczak wrote: W dniu 2021-06-28 o 21:55, Paul Spooren pisze: On 6/28/21 9:53 AM, John Crispin wrote: On 28.06.21 21:14, Paul Spooren wrote: I'm in favor of this too but if it's a core feature (i.e. SIM card support) we should provide the package by default to,

Re: [PATCH] comgt: Move to community packages repo

2021-06-29 Thread Piotr Dymacz
Hi Arjun, Lech, On 29.06.2021 17:57, Arjun AK wrote: On 29/06/21 2:21 am, Lech Perczak wrote: [...] OTOH, this differs a bit from such packages, by being needed to connect to WAN on such devices. This is the same way as uqmi does on some - removing it would require other Internet

Re: [PATCH] comgt: Move to community packages repo

2021-06-29 Thread Arjun AK
On 29/06/21 2:21 am, Lech Perczak wrote: W dniu 2021-06-28 o 21:55, Paul Spooren pisze: On 6/28/21 9:53 AM, John Crispin wrote: On 28.06.21 21:14, Paul Spooren wrote: I'm in favor of this too but if it's a core feature (i.e. SIM card support) we should provide the package by default to,

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Lech Perczak
W dniu 2021-06-29 o 01:07, Sergey Ryazanov pisze: On Mon, Jun 28, 2021 at 11:57 PM Lech Perczak wrote: W dniu 2021-06-28 o 21:55, Paul Spooren pisze: On 6/28/21 9:53 AM, John Crispin wrote: On 28.06.21 21:14, Paul Spooren wrote: I'm in favor of this too but if it's a core feature (i.e. SIM

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Sergey Ryazanov
On Mon, Jun 28, 2021 at 11:57 PM Lech Perczak wrote: > W dniu 2021-06-28 o 21:55, Paul Spooren pisze: >> On 6/28/21 9:53 AM, John Crispin wrote: >>> On 28.06.21 21:14, Paul Spooren wrote: I'm in favor of this too but if it's a core feature (i.e. SIM card support) we should provide the

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Lech Perczak
W dniu 2021-06-28 o 21:55, Paul Spooren pisze: On 6/28/21 9:53 AM, John Crispin wrote: On 28.06.21 21:14, Paul Spooren wrote: I'm in favor of this too but if it's a core feature (i.e. SIM card support) we should provide the package by default to, not? this should be explained in the wiki,

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Paul Spooren
On 6/28/21 9:53 AM, John Crispin wrote: On 28.06.21 21:14, Paul Spooren wrote: I'm in favor of this too but if it's a core feature (i.e. SIM card support) we should provide the package by default to, not? this should be explained in the wiki, Agree, APU boards etc also need some extra

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread John Crispin
On 28.06.21 21:14, Paul Spooren wrote: I'm in favor of this too but if it's a core feature (i.e. SIM card support) we should provide the package by default to, not? this should be explained in the wiki,     John ___ openwrt-devel mailing list

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Paul Spooren
On 6/28/21 8:53 AM, Piotr Dymacz wrote: Hi John, On 28.06.2021 20:32, John Crispin wrote: On 28.06.21 19:26, Piotr Dymacz wrote: I might be wrong here but I think we don't include packages from external feeds inside 'DEVICE_PACKAGES' (not sure/don't remember why). I am in favour of

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Piotr Dymacz
Hi John, On 28.06.2021 20:32, John Crispin wrote: On 28.06.21 19:26, Piotr Dymacz wrote: I might be wrong here but I think we don't include packages from external feeds inside 'DEVICE_PACKAGES' (not sure/don't remember why). I am in favour of moving all none-core packages to the feeds. the

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread John Crispin
On 28.06.21 19:26, Piotr Dymacz wrote: I might be wrong here but I think we don't include packages from external feeds inside 'DEVICE_PACKAGES' (not sure/don't remember why). I am in favour of moving all none-core packages to the feeds. the dependency should be removed and a note should be

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Piotr Dymacz
Hi Arjun, On 28.06.2021 19:43, Arjun AK wrote: On 28/06/21 10:56 pm, Piotr Dymacz wrote: Hi Arjun, On 28.06.2021 18:52, Arjun AK wrote: Signed-off-by: Arjun AK The only problem here is a D-Link DWR-512B device (ramips/rt305x target) which has 'comgt-ncm' package listed under

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Arjun AK
On 28/06/21 10:56 pm, Piotr Dymacz wrote: Hi Arjun, On 28.06.2021 18:52, Arjun AK wrote: Signed-off-by: Arjun AK The only problem here is a D-Link DWR-512B device (ramips/rt305x target) which has 'comgt-ncm' package listed under 'DEVICE_PACKAGES', see [1]. But the package name is "comgt"

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Piotr Dymacz
Hi Arjun, On 28.06.2021 18:52, Arjun AK wrote: Signed-off-by: Arjun AK The only problem here is a D-Link DWR-512B device (ramips/rt305x target) which has 'comgt-ncm' package listed under 'DEVICE_PACKAGES', see [1]. I might be wrong here but I think we don't include packages from external

Re: [PATCH] comgt: Move to community packages repo

2021-06-28 Thread Arjun AK
On 28/06/21 10:22 pm, Arjun AK wrote: Signed-off-by: Arjun AK --- package/network/utils/comgt/Makefile | 106 package/network/utils/comgt/files/3g.chat | 12 - package/network/utils/comgt/files/3g.sh | 116 package/network/utils/comgt/files/3g.usb

[PATCH] comgt: Move to community packages repo

2021-06-28 Thread Arjun AK
Signed-off-by: Arjun AK --- package/network/utils/comgt/Makefile | 106 package/network/utils/comgt/files/3g.chat | 12 - package/network/utils/comgt/files/3g.sh | 116 package/network/utils/comgt/files/3g.usb | 33 ---