Build changes correcting FPIC definition (was: [PATCH] gmp: compile with -DPIC to use correct asm code)

2021-03-24 Thread Philip Prindeville
> On Mar 19, 2021, at 4:59 PM, Philip Prindeville > wrote: > > > >> On Mar 19, 2021, at 4:06 PM, Eneas U de Queiroz >> wrote: >> >> On Fri, Mar 19, 2021 at 5:08 PM Philip Prindeville >> wrote: >>> >>> >>> Maybe I'm missing something, but why not just fix rules.mk: >>> >>> >>> ifneq

Re: [PATCH] gmp: compile with -DPIC to use correct asm code

2021-03-19 Thread Philip Prindeville
> On Mar 19, 2021, at 4:06 PM, Eneas U de Queiroz wrote: > > On Fri, Mar 19, 2021 at 5:08 PM Philip Prindeville > wrote: >> >> >> Maybe I'm missing something, but why not just fix rules.mk: >> >> >> ifneq (,$(findstring $(ARCH) , aarch64 aarch64_be powerpc )) >> FPIC:=-fPIC >> else >>

Re: [PATCH] gmp: compile with -DPIC to use correct asm code

2021-03-19 Thread Eneas U de Queiroz
On Fri, Mar 19, 2021 at 5:08 PM Philip Prindeville wrote: > > > Maybe I'm missing something, but why not just fix rules.mk: > > > ifneq (,$(findstring $(ARCH) , aarch64 aarch64_be powerpc )) > FPIC:=-fPIC > else > FPIC:=-fpic > endif > > HOST_FPIC:=-fPIC > > > To have the FPIC and HOST_FPIC

Re: [PATCH] gmp: compile with -DPIC to use correct asm code

2021-03-19 Thread Philip Prindeville
> On Mar 12, 2021, at 6:25 AM, Felix Fietkau wrote: > > > On 2021-03-12 11:34, Stijn Tintel wrote: >> On 11/03/2021 23:46, Eneas U de Queiroz wrote: >>> The library is always compiled with $(FPIC) (-fPIC or -fpic), even for >>> the static library. >>> >>> There are some assembly sources

Re: [PATCH] gmp: compile with -DPIC to use correct asm code

2021-03-12 Thread Felix Fietkau
On 2021-03-12 11:34, Stijn Tintel wrote: > On 11/03/2021 23:46, Eneas U de Queiroz wrote: >> The library is always compiled with $(FPIC) (-fPIC or -fpic), even for >> the static library. >> >> There are some assembly sources that decide whether or not to enable >> PIC code by checking if PIC is

Re: [PATCH] gmp: compile with -DPIC to use correct asm code

2021-03-12 Thread Stijn Tintel
On 11/03/2021 23:46, Eneas U de Queiroz wrote: > The library is always compiled with $(FPIC) (-fPIC or -fpic), even for > the static library. > > There are some assembly sources that decide whether or not to enable > PIC code by checking if PIC is defined. It counts on libtool to define > it, but

[PATCH] gmp: compile with -DPIC to use correct asm code

2021-03-11 Thread Eneas U de Queiroz
The library is always compiled with $(FPIC) (-fPIC or -fpic), even for the static library. There are some assembly sources that decide whether or not to enable PIC code by checking if PIC is defined. It counts on libtool to define it, but libtool does it only when producing code for the dynamic