[PATCH] iftop: fix compilation with GCC 10

2020-09-01 Thread Rosen Penev
GCC 10 defaults to fno-common, which demands unique defenitions. Patch taken from buildroot. Signed-off-by: Rosen Penev --- package/network/utils/iftop/Makefile | 2 +- .../utils/iftop/patches/010-gcc10.patch | 57 +++ 2 files changed, 58 insertions(+), 1 deletio

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-18 Thread Jo-Philipp Wich
Hi, > Where? I don't see a merge request on the git link referenced in the Makefile. sent a patch to the author using git send-email. Couldn't figure out how to open a MR on that Gitlab thing after looking for 30 seconds. ~ Jo ___ openwrt-devel mailin

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Rosen Penev
On Fri, Jul 17, 2020 at 3:49 AM Bjørn Mork wrote: > > Rosen Penev writes: > >> On Jul 17, 2020, at 3:06 AM, Felix Fietkau wrote: > > >>> +--- a/ui_common.h > >>> b/ui_common.h > >>> +@@ -33,12 +33,12 @@ typedef struct host_pair_line_tag { > >>> + > >>> + extern options_t options; > >>> + >

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Rosen Penev
On Fri, Jul 17, 2020 at 3:21 AM Jo-Philipp Wich wrote: > > Hi, > > I've sent a fix using extern declarations upstream, lets see what happens. Where? I don't see a merge request on the git link referenced in the Makefile. > > ~ Jo > > ___ > openwrt-devel

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Bjørn Mork
Rosen Penev writes: >> On Jul 17, 2020, at 3:06 AM, Felix Fietkau wrote: >>> +--- a/ui_common.h >>> b/ui_common.h >>> +@@ -33,12 +33,12 @@ typedef struct host_pair_line_tag { >>> + >>> + extern options_t options; >>> + >>> +-sorted_list_type screen_list; >>> +-host_pair_line totals; >>> +

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Koen Vandeputte
On 17.07.20 11:56, Rosen Penev wrote: On Jul 17, 2020, at 2:50 AM, Petr Štetiar wrote: Rosen Penev [2020-07-13 22:43:51]: Hi, GCC 10 defaults to fno-common, which demains unique defenitions. whats the exact error here? Wouldn't it make sense to move this into packages feed? +1 No id

RE: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread mail
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of Petr Štetiar > Sent: Freitag, 17. Juli 2020 11:50 > To: Rosen Penev > Cc: openwrt-devel@lists.openwrt.org > Subject: Re: [PATCH] iftop: fix compilation with GC

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Jo-Philipp Wich
Hi, I've sent a fix using extern declarations upstream, lets see what happens. ~ Jo signature.asc Description: OpenPGP digital signature ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Rosen Penev
> On Jul 17, 2020, at 3:06 AM, Felix Fietkau wrote: > > On 2020-07-14 07:43, Rosen Penev wrote: >> GCC 10 defaults to fno-common, which demains unique defenitions. >> >> Signed-off-by: Rosen Penev >> --- >> package/network/utils/iftop/Makefile | 2 +- >> .../utils/iftop/patches/010-

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Felix Fietkau
On 2020-07-14 07:43, Rosen Penev wrote: > GCC 10 defaults to fno-common, which demains unique defenitions. > > Signed-off-by: Rosen Penev > --- > package/network/utils/iftop/Makefile | 2 +- > .../utils/iftop/patches/010-gcc10.patch | 20 +++ > 2 files changed, 21

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Rosen Penev
> On Jul 17, 2020, at 2:50 AM, Petr Štetiar wrote: > > Rosen Penev [2020-07-13 22:43:51]: > > Hi, > >> GCC 10 defaults to fno-common, which demains unique defenitions. > > whats the exact error here? Wouldn't it make sense to move this into packages > feed? No idea what this package is fo

Re: [PATCH] iftop: fix compilation with GCC 10

2020-07-17 Thread Petr Štetiar
Rosen Penev [2020-07-13 22:43:51]: Hi, > GCC 10 defaults to fno-common, which demains unique defenitions. whats the exact error here? Wouldn't it make sense to move this into packages feed? What about upstream, looks like they might find this patch handy. -- ynezz ___

[PATCH] iftop: fix compilation with GCC 10

2020-07-13 Thread Rosen Penev
GCC 10 defaults to fno-common, which demains unique defenitions. Signed-off-by: Rosen Penev --- package/network/utils/iftop/Makefile | 2 +- .../utils/iftop/patches/010-gcc10.patch | 20 +++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 pack