Re: [PATCH] kernel: disable crypto-hw-ccp on BCM4908

2021-04-13 Thread Rafał Miłecki

On 2021-04-13 12:02, Felix Fietkau wrote:

On 2021-04-13 11:46, Rafał Miłecki wrote:

From: Rafał Miłecki 

CONFIG_CRYPTO_DEV_SP_CCP depends on DMA_ENGINE which depends on
DMADEVICES=y which bcm4908 doesn't need and doesn't use at this point.

Trying to build this package on bcm4908 was causing:
ERROR: module 
'build_dir/target-aarch64_cortex-a53_musl/linux-bcm4908_generic/linux-5.4.110/drivers/crypto/ccp/ccp-crypto.ko' 
is missing.


Signed-off-by: Rafał Miłecki 
---
 package/kernel/linux/modules/crypto.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/kernel/linux/modules/crypto.mk 
b/package/kernel/linux/modules/crypto.mk

index cbaa8d3ce5..0f696c3129 100644
--- a/package/kernel/linux/modules/crypto.mk
+++ b/package/kernel/linux/modules/crypto.mk
@@ -319,7 +319,8 @@ $(eval $(call KernelPackage,crypto-hmac))

 define KernelPackage/crypto-hw-ccp
   TITLE:=AMD Cryptographic Coprocessor
-  DEPENDS:=+kmod-crypto-authenc +kmod-crypto-hash 
+kmod-crypto-manager +kmod-random-core +kmod-crypto-sha1 
+kmod-crypto-sha256 +kmod-crypto-rsa

+  DEPENDS:=@!TARGET_bcm4908
+  DEPENDS+=+kmod-crypto-authenc +kmod-crypto-hash 
+kmod-crypto-manager +kmod-random-core +kmod-crypto-sha1 
+kmod-crypto-sha256 +kmod-crypto-rsa

Wouldn't it make a lot more sense to depend on @TARGET_x86_64 instead?


Yes it would.

CRYPTO_DEV_CCP depends on X86 or ARM64
CRYPTO_DEV_CCP_DD depends on CPU_SUP_AMD or ARM64

I don't think we support any arm64 board with "AMD Secure Processor" so
x86 should be enough for OpenWrt.

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH] kernel: disable crypto-hw-ccp on BCM4908

2021-04-13 Thread Felix Fietkau

On 2021-04-13 11:46, Rafał Miłecki wrote:
> From: Rafał Miłecki 
> 
> CONFIG_CRYPTO_DEV_SP_CCP depends on DMA_ENGINE which depends on
> DMADEVICES=y which bcm4908 doesn't need and doesn't use at this point.
> 
> Trying to build this package on bcm4908 was causing:
> ERROR: module 
> 'build_dir/target-aarch64_cortex-a53_musl/linux-bcm4908_generic/linux-5.4.110/drivers/crypto/ccp/ccp-crypto.ko'
>  is missing.
> 
> Signed-off-by: Rafał Miłecki 
> ---
>  package/kernel/linux/modules/crypto.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/kernel/linux/modules/crypto.mk 
> b/package/kernel/linux/modules/crypto.mk
> index cbaa8d3ce5..0f696c3129 100644
> --- a/package/kernel/linux/modules/crypto.mk
> +++ b/package/kernel/linux/modules/crypto.mk
> @@ -319,7 +319,8 @@ $(eval $(call KernelPackage,crypto-hmac))
>  
>  define KernelPackage/crypto-hw-ccp
>TITLE:=AMD Cryptographic Coprocessor
> -  DEPENDS:=+kmod-crypto-authenc +kmod-crypto-hash +kmod-crypto-manager 
> +kmod-random-core +kmod-crypto-sha1 +kmod-crypto-sha256 +kmod-crypto-rsa
> +  DEPENDS:=@!TARGET_bcm4908
> +  DEPENDS+=+kmod-crypto-authenc +kmod-crypto-hash +kmod-crypto-manager 
> +kmod-random-core +kmod-crypto-sha1 +kmod-crypto-sha256 +kmod-crypto-rsa
Wouldn't it make a lot more sense to depend on @TARGET_x86_64 instead?

- Felix

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[PATCH] kernel: disable crypto-hw-ccp on BCM4908

2021-04-13 Thread Rafał Miłecki
From: Rafał Miłecki 

CONFIG_CRYPTO_DEV_SP_CCP depends on DMA_ENGINE which depends on
DMADEVICES=y which bcm4908 doesn't need and doesn't use at this point.

Trying to build this package on bcm4908 was causing:
ERROR: module 
'build_dir/target-aarch64_cortex-a53_musl/linux-bcm4908_generic/linux-5.4.110/drivers/crypto/ccp/ccp-crypto.ko'
 is missing.

Signed-off-by: Rafał Miłecki 
---
 package/kernel/linux/modules/crypto.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/kernel/linux/modules/crypto.mk 
b/package/kernel/linux/modules/crypto.mk
index cbaa8d3ce5..0f696c3129 100644
--- a/package/kernel/linux/modules/crypto.mk
+++ b/package/kernel/linux/modules/crypto.mk
@@ -319,7 +319,8 @@ $(eval $(call KernelPackage,crypto-hmac))
 
 define KernelPackage/crypto-hw-ccp
   TITLE:=AMD Cryptographic Coprocessor
-  DEPENDS:=+kmod-crypto-authenc +kmod-crypto-hash +kmod-crypto-manager 
+kmod-random-core +kmod-crypto-sha1 +kmod-crypto-sha256 +kmod-crypto-rsa
+  DEPENDS:=@!TARGET_bcm4908
+  DEPENDS+=+kmod-crypto-authenc +kmod-crypto-hash +kmod-crypto-manager 
+kmod-random-core +kmod-crypto-sha1 +kmod-crypto-sha256 +kmod-crypto-rsa
   KCONFIG:= \
CONFIG_CRYPTO_HW=y \
CONFIG_CRYPTO_DEV_CCP=y \
-- 
2.26.2


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel