Re: [PATCH V3] ipq40xx: fix BDF file for pcie wifi chip on the GL.Inet GL-B2200
On Thu, Apr 28, 2022 at 10:42 AM Robert Marko wrote:
>
> On Thu, 28 Apr 2022 at 08:57, Enrico Mioso wrote:
> >
> > After the switch to pre-calibration, ath10k would fail to initialize
> > the PCIE Wi-Fi on the GL-B200 as follows:
> >
> > ath10k_pci :01:00.0: enabling device (0140 -> 0142)
> > ath10k_pci :01:00.0: qca9888 hw2.0 target 0x0100 chip_id 0x
> > sub :
> > [...]
> > ath10k_pci :01:00.0: failed to fetch board data for
> > bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=GL-B2200 from
> > ath10k/QCA9888/hw2.0/board-2.bin
> > ath10k_pci :01:00.0: failed to fetch board-2.bin or board.bin from
> > ath10k/QCA9888/hw2.0
> > ath10k_pci :01:00.0: failed to fetch board file: -12
> > ath10k_pci :01:00.0: could not probe fw (-12)
> >
> > Repackage the BDF file after renaming relevant fields and files to
> > allow for the Wi-Fi interface to start again.
> >
> > Fixes: 80d34d9d593 ("ipq40xx: document pcie wifi chip on the GL.Inet
> > GL-B2200")
> > CC: Christian Lamparter
> > CC: Robert Marko
> > Signed-off-by: Enrico Mioso
>
> LGTM,
> Reviewed-by: Robert Marko
I'll definitively second that too. It's good.
It would be perfect if the QCA9888 board.bin version could also be
submitted to ath10k Mailing-List:
so it will eventually go into linux-firmware.git's QCA9888's board-2.bin.
Yes, this should have already happened when the board was added. Maybe
the mismatched identification string would have been caught right there...
Previous submissions can be used as a template:
Re: [PATCH V3] ipq40xx: fix BDF file for pcie wifi chip on the GL.Inet GL-B2200
On Thu, 28 Apr 2022 at 08:57, Enrico Mioso wrote:
>
> After the switch to pre-calibration, ath10k would fail to initialize
> the PCIE Wi-Fi on the GL-B200 as follows:
>
> ath10k_pci :01:00.0: enabling device (0140 -> 0142)
> ath10k_pci :01:00.0: qca9888 hw2.0 target 0x0100 chip_id 0x
> sub :
> [...]
> ath10k_pci :01:00.0: failed to fetch board data for
> bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=GL-B2200 from
> ath10k/QCA9888/hw2.0/board-2.bin
> ath10k_pci :01:00.0: failed to fetch board-2.bin or board.bin from
> ath10k/QCA9888/hw2.0
> ath10k_pci :01:00.0: failed to fetch board file: -12
> ath10k_pci :01:00.0: could not probe fw (-12)
>
> Repackage the BDF file after renaming relevant fields and files to
> allow for the Wi-Fi interface to start again.
>
> Fixes: 80d34d9d593 ("ipq40xx: document pcie wifi chip on the GL.Inet
> GL-B2200")
> CC: Christian Lamparter
> CC: Robert Marko
> Signed-off-by: Enrico Mioso
LGTM,
Reviewed-by: Robert Marko
> ---
> .../ipq-wifi/board-glinet_gl-b2200.qca9888| Bin 12200 -> 12164 bytes
> 1 file changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/package/firmware/ipq-wifi/board-glinet_gl-b2200.qca9888
> b/package/firmware/ipq-wifi/board-glinet_gl-b2200.qca9888
> index
> 4f0a521f35935d4be1fb01b66dd9954a48eade52..f0a493ace340de0fe84d89d46cc07209df1b6883
> 100644
> GIT binary patch
> delta 79
> zcmZ1x-x5DT!X-nW0SwH5WKwCdZ9#ITPEu~BZgNIufo^7stpS*ql%H6X0^%B)>69fF
> YWhUm8*t+}ZIvE)m806+|Y|zjL0EmDWzyJUM
>
> delta 115
> zcmZpPUlBh+BBMv20Ssb*WKwCdZ9#ITPFZSRN`8^8p_xUpPD*N7W^$^nfq|)+PH|~c
> qab
> --
> 2.36.0
>
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH V3] ipq40xx: fix BDF file for pcie wifi chip on the GL.Inet GL-B2200
After the switch to pre-calibration, ath10k would fail to initialize
the PCIE Wi-Fi on the GL-B200 as follows:
ath10k_pci :01:00.0: enabling device (0140 -> 0142)
ath10k_pci :01:00.0: qca9888 hw2.0 target 0x0100 chip_id 0x sub
:
[...]
ath10k_pci :01:00.0: failed to fetch board data for
bus=pci,bmi-chip-id=0,bmi-board-id=16,variant=GL-B2200 from
ath10k/QCA9888/hw2.0/board-2.bin
ath10k_pci :01:00.0: failed to fetch board-2.bin or board.bin from
ath10k/QCA9888/hw2.0
ath10k_pci :01:00.0: failed to fetch board file: -12
ath10k_pci :01:00.0: could not probe fw (-12)
Repackage the BDF file after renaming relevant fields and files to
allow for the Wi-Fi interface to start again.
Fixes: 80d34d9d593 ("ipq40xx: document pcie wifi chip on the GL.Inet GL-B2200")
CC: Christian Lamparter
CC: Robert Marko
Signed-off-by: Enrico Mioso
---
.../ipq-wifi/board-glinet_gl-b2200.qca9888| Bin 12200 -> 12164 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/package/firmware/ipq-wifi/board-glinet_gl-b2200.qca9888
b/package/firmware/ipq-wifi/board-glinet_gl-b2200.qca9888
index
4f0a521f35935d4be1fb01b66dd9954a48eade52..f0a493ace340de0fe84d89d46cc07209df1b6883
100644
GIT binary patch
delta 79
zcmZ1x-x5DT!X-nW0SwH5WKwCdZ9#ITPEu~BZgNIufo^7stpS*ql%H6X0^%B)>69fF
YWhUm8*t+}ZIvE)m806+|Y|zjL0EmDWzyJUM
delta 115
zcmZpPUlBh+BBMv20Ssb*WKwCdZ9#ITPFZSRN`8^8p_xUpPD*N7W^$^nfq|)+PH|~c
qabhttps://lists.openwrt.org/mailman/listinfo/openwrt-devel
