Re: [PATCH v2 5/5] tfa-layerscape: Change to github and use the latest tag

2023-05-19 Thread Wojciech Dubowik via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
--- Original Message ---
On Thursday, May 18th, 2023 at 4:56 PM, Christian Lamparter 
 wrote:


> On 4/21/23 10:59, Wojciech Dubowik via openwrt-devel wrote:
> 
> > The dafault location of tfa-layerscape has been changed from
> > codeuaurora to github. Also use the latest tag for Layerscape
> > Linux Development POC from NXP.
> > 
> > v2:
> > * restored ls1012afrdm board
> > * added platfrom defines to fiptool so ls-ddr-phy can be built
> > 
> > Signed-off-by: Wojciech dubowikwojciech.dubo...@protonmail.ch
> 
> 
> hmm, source.codeaurora.org (no longer?) resolves. So yes, this
> needs to be updated.
> 
> I ran into issues applying this particular patch though.
> (PKG_RELEASE:=$(AUTORELEASE) has recently being canned, but this is easy to 
> fix)
> 
> what I'm scratching my head about are these:
> ---
> Checking file 
> package/boot/tfa-layerscape/patches/001-fiptool-hostbuild-fixes.patch
> Hunk #1 succeeded at 1 with fuzz 1.
> Hunk #4 FAILED at 39.
> Hunk #5 FAILED at 77.
> 2 out of 5 hunks FAILED
> checking file 
> package/boot/tfa-layerscape/patches/003-plat-nxp-tools-fix-create_pbl-and-byte_swap-host-bui.patch
> Hunk #2 FAILED at 26.
> 1 out of 3 hunks FAILED
> checking file 
> package/boot/tfa-layerscape/patches/004-plat-nxp-restore-ls1012afrdm-support.patch
> ---
> 
> could you have more local changes to:
> 001-fiptool-hostbuild-fixes.patch
> 003-plat-nxp-tools-fix-create_pbl-and-byte_swap-host-bui.patch
> ?
That's strange as I haven't ran into such issues. I have just rebased patches 
on latest master. I have already fixed PKG_RELEASE and I have also removed two 
ls1028ardb specific patches which are not needed with the new uboot version.

Changes are on the my github branch. Could you give it a try?
https://github.com/wodu/openwrt/tree/ls-firmware

Cheers,
Wojtek
> 
> which need to be part of this patch?
> (or does this depend on a previous patch, that needs to be applied first)?
> 
> Cheers,
> Christian

--- End Message ---
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH v2 5/5] tfa-layerscape: Change to github and use the latest tag

2023-05-18 Thread Christian Lamparter

On 4/21/23 10:59, Wojciech Dubowik via openwrt-devel wrote:

The dafault location of tfa-layerscape has been changed from
codeuaurora to github. Also use the latest tag for Layerscape
Linux Development POC from NXP.

v2:
* restored ls1012afrdm board
* added platfrom defines to fiptool so ls-ddr-phy can be built

Signed-off-by: Wojciech Dubowik


hmm, source.codeaurora.org (no longer?) resolves. So yes, this
needs to be updated.

I ran into issues applying this particular patch though.
(PKG_RELEASE:=$(AUTORELEASE) has recently being canned, but this is easy to fix)

what I'm scratching my head about are these:
---
Checking file 
package/boot/tfa-layerscape/patches/001-fiptool-hostbuild-fixes.patch
Hunk #1 succeeded at 1 with fuzz 1.
Hunk #4 FAILED at 39.
Hunk #5 FAILED at 77.
2 out of 5 hunks FAILED
checking file 
package/boot/tfa-layerscape/patches/003-plat-nxp-tools-fix-create_pbl-and-byte_swap-host-bui.patch
Hunk #2 FAILED at 26.
1 out of 3 hunks FAILED
checking file 
package/boot/tfa-layerscape/patches/004-plat-nxp-restore-ls1012afrdm-support.patch
---

could you have more local changes to:
  001-fiptool-hostbuild-fixes.patch
  003-plat-nxp-tools-fix-create_pbl-and-byte_swap-host-bui.patch
?

which need to be part of this patch?
(or does this depend on a previous patch, that needs to be applied first)?

Cheers,
Christian

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[PATCH v2 5/5] tfa-layerscape: Change to github and use the latest tag

2023-04-21 Thread Wojciech Dubowik via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
The dafault location of tfa-layerscape has been changed from
codeuaurora to github. Also use the latest tag for Layerscape
Linux Development POC from NXP.

v2:
* restored ls1012afrdm board
* added platfrom defines to fiptool so ls-ddr-phy can be built

Signed-off-by: Wojciech Dubowik 
---
 package/boot/tfa-layerscape/Makefile  |  15 +-
 .../patches/001-fiptool-hostbuild-fixes.patch |  37 ++-
 ...ix-create_pbl-and-byte_swap-host-bui.patch |  16 +-
 ...plat-nxp-restore-ls1012afrdm-support.patch | 232 ++
 4 files changed, 264 insertions(+), 36 deletions(-)
 create mode 100644 
package/boot/tfa-layerscape/patches/004-plat-nxp-restore-ls1012afrdm-support.patch

diff --git a/package/boot/tfa-layerscape/Makefile 
b/package/boot/tfa-layerscape/Makefile
index 072036da2f..d9d9242941 100644
--- a/package/boot/tfa-layerscape/Makefile
+++ b/package/boot/tfa-layerscape/Makefile
@@ -8,13 +8,13 @@
 include $(TOPDIR)/rules.mk

 PKG_NAME:=tfa-layerscape
-PKG_VERSION:=21.08
+PKG_VERSION:=lf-6.1.1-1.0.0
 PKG_RELEASE:=$(AUTORELEASE)

 PKG_SOURCE_PROTO:=git
-PKG_SOURCE_URL:=https://source.codeaurora.org/external/qoriq/qoriq-components/atf
-PKG_SOURCE_VERSION:=LSDK-21.08
-PKG_MIRROR_HASH:=893f2d28a77dcc9d4413a619b4719ca5f1f4dc78dd824a8488e7d543e66bcf95
+PKG_SOURCE_URL:=https://github.com/nxp-qoriq/atf
+PKG_SOURCE_VERSION:=lf-6.1.1-1.0.0
+PKG_MIRROR_HASH:=c0e3c7d0cc9ee5f9ae68cd705ce7f07f714c4fe3fd4a5a79de5699e7865b759f
 PKG_BUILD_DEPENDS:=tfa-layerscape/host

 include $(INCLUDE_DIR)/host-build.mk
@@ -25,18 +25,19 @@ HOST_CFLAGS += -Wall -Werror -pedantic -std=c99
 define Host/Compile
$(MAKE) -C \
$(HOST_BUILD_DIR)/tools/fiptool \
+   
PLAT_FIPTOOL_HELPER_MK="$(HOST_BUILD_DIR)/tools/nxp/plat_fiptool/plat_fiptool.mk"
CFLAGS="$(HOST_CFLAGS)" \
LDFLAGS="$(HOST_LDFLAGS)" \
HOSTCCFLAGS="$(HOST_CFLAGS)"
$(MAKE) -C \
-   $(HOST_BUILD_DIR)/tools/nxp \
+   $(HOST_BUILD_DIR)/tools/nxp/create_pbl \
CFLAGS="$(HOST_CFLAGS)"
 endef

 define Host/Install
$(INSTALL_BIN) $(HOST_BUILD_DIR)/tools/fiptool/fiptool 
$(STAGING_DIR_HOST)/bin/fiptool-layerscape
-   $(INSTALL_BIN) $(HOST_BUILD_DIR)/tools/nxp/create_pbl 
$(STAGING_DIR_HOST)/bin/tfa-create-pbl
-   $(INSTALL_BIN) $(HOST_BUILD_DIR)/tools/nxp/byte_swap 
$(STAGING_DIR_HOST)/bin/tfa-byte-swap
+   $(INSTALL_BIN) $(HOST_BUILD_DIR)/tools/nxp/create_pbl/create_pbl 
$(STAGING_DIR_HOST)/bin/tfa-create-pbl
+   $(INSTALL_BIN) $(HOST_BUILD_DIR)/tools/nxp/create_pbl/byte_swap 
$(STAGING_DIR_HOST)/bin/tfa-byte-swap
 endef

 define Trusted-Firmware-A/Default
diff --git 
a/package/boot/tfa-layerscape/patches/001-fiptool-hostbuild-fixes.patch 
b/package/boot/tfa-layerscape/patches/001-fiptool-hostbuild-fixes.patch
index 4b74048754..8e7375cfa2 100644
--- a/package/boot/tfa-layerscape/patches/001-fiptool-hostbuild-fixes.patch
+++ b/package/boot/tfa-layerscape/patches/001-fiptool-hostbuild-fixes.patch
@@ -1,6 +1,6 @@
 --- a/Makefile
 +++ b/Makefile
-@@ -801,10 +801,6 @@ CRTTOOL   ?=  
${CRTTOOLPATH}/cert_create$
+@@ -914,10 +914,6 @@ CRTTOOL   ?=  
${CRTTOOLPATH}/cert_create$
  ENCTOOLPATH   ?=  tools/encrypt_fw
  ENCTOOL   ?=  ${ENCTOOLPATH}/encrypt_fw${BIN_EXT}

@@ -11,7 +11,7 @@
  # Variables for use with sptool
  SPTOOLPATH?=  tools/sptool
  SPTOOL?=  ${SPTOOLPATH}/sptool${BIN_EXT}
-@@ -1160,13 +1156,6 @@ endif
+@@ -1322,13 +1318,6 @@ endif
  clean:
@echo "  CLEAN"
$(call SHELL_REMOVE_DIR,${BUILD_PLAT})
@@ -25,7 +25,7 @@
${Q}${MAKE} PLAT=${PLAT} --no-print-directory -C ${CRTTOOLPATH} clean
${Q}${MAKE} PLAT=${PLAT} --no-print-directory -C ${ENCTOOLPATH} clean
${Q}${MAKE} --no-print-directory -C ${ROMLIBPATH} clean
-@@ -1175,13 +1164,6 @@ realclean distclean:
+@@ -1337,13 +1326,6 @@ realclean distclean:
@echo "  REALCLEAN"
$(call SHELL_REMOVE_DIR,${BUILD_BASE})
$(call SHELL_DELETE_ALL, ${CURDIR}/cscope.*)
@@ -39,37 +39,33 @@
${Q}${MAKE} --no-print-directory -C ${SPTOOLPATH} clean
${Q}${MAKE} PLAT=${PLAT} --no-print-directory -C ${CRTTOOLPATH} clean
${Q}${MAKE} PLAT=${PLAT} --no-print-directory -C ${ENCTOOLPATH} 
realclean
-@@ -1238,7 +1220,7 @@ certificates: ${CRT_DEPS} ${CRTTOOL}
+@@ -1400,7 +1382,7 @@ certificates: ${CRT_DEPS} ${CRTTOOL}
@${ECHO_BLANK_LINE}
  endif

 -${BUILD_PLAT}/${FIP_NAME}: ${FIP_DEPS} ${FIPTOOL}
 +${BUILD_PLAT}/${FIP_NAME}: ${FIP_DEPS}
-   ${Q}${FIPTOOL} create ${FIP_ARGS} $@
-   ${Q}${FIPTOOL} info $@
-   @${ECHO_BLANK_LINE}