Re: [OpenWrt-Devel] [PATCH 1/1] uqmi: uim: add support for Get Card Status request

On 14/08/17 12:02, Daniele Palmas wrote: This patch adds support for UIM Get Card Status request Signed-off-by: Daniele Palmas --- Hi Daniele, sorry for the late reply, nitpicks inline, if you could fix those and resend the patch please ..     John commands-uim.c | 143 +

Re: [OpenWrt-Devel] [PATCH 3/6] uclient-http: auth digest: Handle multiple possible memory allocation failures

Hi, comments inline ... On 18/02/18 04:36, Tobias Schramm wrote: Signed-off-by: Tobias Schramm --- uclient-http.c | 41 - 1 file changed, 32 insertions(+), 9 deletions(-) diff --git a/uclient-http.c b/uclient-http.c index 36e051b..2a3cf5d 100644 ---

Re: [OpenWrt-Devel] [PATCH 1/6] uclient-fetch: Check for nullpointer returned by open_output_file

On 18/02/18 04:36, Tobias Schramm wrote: Signed-off-by: Tobias Schramm --- uclient-fetch.c | 5 + 1 file changed, 5 insertions(+) diff --git a/uclient-fetch.c b/uclient-fetch.c index 6961d94..46f9b3d 100644 --- a/uclient-fetch.c +++ b/uclient-fetch.c @@ -122,6 +122,11 @@ static int ope

Re: [OpenWrt-Devel] [PATCH 2/6] uclient-http: basic auth: Handle memory allocation failure

On 18/02/18 04:36, Tobias Schramm wrote: Signed-off-by: Tobias Schramm looks good, but the caller should honour the return value aswell     John --- uclient-http.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/uclient-http.c b/uclient-http.c index ef8de98

Re: [OpenWrt-Devel] [PATCH 5/6] uclient-utils: Handle memory allocation failure for url file name

On 18/02/18 04:36, Tobias Schramm wrote: Signed-off-by: Tobias Schramm --- uclient-utils.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/uclient-utils.c b/uclient-utils.c index a375eea..ee0f8e8 100644 --- a/uclient-utils.c +++ b/uclient-utils.c @@ -177,8 +177,1

Re: [OpenWrt-Devel] [PATCH 0/6] uclient: Handle memory allocation failures

On 18/02/18 04:36, Tobias Schramm wrote: Hi, this series of patches adds some code to handle memory allocation failures without crashing. Previously a lot of memory allocations were not checked for NULL ptrs resulting in nullpointer dereferences if (lib)uclient ran out of memory Regards Tob

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH v3 1/4] kernel: backport dwc pci enumeration fix

On 17/02/18 13:33, Hauke Mehrtens wrote: On 02/15/2018 05:34 PM, Tim Harvey wrote: Backport of: http://patchwork.ozlabs.org/patch/860701/ Signed-off-by: Tim Harvey --- .../generic/pending-4.14/812-pci-dwc-fix-enumeration.patch| 11 +++ 1 file changed, 11 insertions(+) creat

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH v3 0/4]: imx6: update to Linux 4.14

On 17/02/18 13:30, Hauke Mehrtens wrote: On 02/15/2018 05:34 PM, Tim Harvey wrote: Testted on a Gateworks GW54xx. Does not support enabling imx-drm modules yet as those will need some adjustments based on kernel configs. v3: - included missing patch for pcie enumeration fix v2: - move dw

[OpenWrt-Devel] [PATCH v2 0/7] uclient: Handle memory allocation failures

Hi John, I've implemented the suggested improvements and performed some more reformatting to match the codestyle of uclient more closely. Regards Tobias Schramm Changes since v1: Fix codestyle Fix memory leak in uclient_http_add_auth_digest Honour return value of auth header functions Fix wron

[OpenWrt-Devel] [PATCH v2 2/7] uclient-http: basic auth: Handle memory allocation failure

Allocation of the base64 buffer might fail, resulting in a null ptr being passed to base64_encode as a target buffer Signed-off-by: Tobias Schramm --- uclient-http.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/uclient-http.c b/uclient-http.c index ef8de98..36e2b3

[OpenWrt-Devel] [PATCH v2 1/7] uclient-fetch: Check for nullpointer returned by uclient_get_url_filename

uclient_get_url_filename may return a null ptr resulting in a null ptr dereference by fprintf and open Signed-off-by: Tobias Schramm --- uclient-fetch.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/uclient-fetch.c b/uclient-fetch.c index 6961d94..38c9c53 100644 --- a/uclient-fetch.c

[OpenWrt-Devel] [PATCH v2 3/7] uclient-http: auth digest: Handle multiple possible memory allocation failures

Add null pointer checks to allocation of buffers for authentication parameters Signed-off-by: Tobias Schramm --- uclient-http.c | 43 ++- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/uclient-http.c b/uclient-http.c index 36e2b38..20b8a9a

[OpenWrt-Devel] [PATCH v2 4/7] uclient-http: Implement error handling for header-sending

Add some error handling for errors during assembly of headers Signed-off-by: Tobias Schramm --- uclient-http.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/uclient-http.c b/uclient-http.c index 20b8a9a..04f16a3 100644 --- a/uclient-http.c

[OpenWrt-Devel] [PATCH v2 6/7] uclient-utils: Handle memory allocation failure for url file name

Add null pointer check to allocation of url filename Signed-off-by: Tobias Schramm --- uclient-utils.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/uclient-utils.c b/uclient-utils.c index a375eea..9c4dd42 100644 --- a/uclient-utils.c +++ b/uclient-utils.c @@ -177,

[OpenWrt-Devel] [PATCH v2 5/7] uclient-http: Handle memory allocation failure

Add null pointer check to allocation of uclient_http struct Signed-off-by: Tobias Schramm --- uclient-http.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/uclient-http.c b/uclient-http.c index 04f16a3..b6607f1 100644 --- a/uclient-http.c +++ b/uclient-http.c @@ -949,6 +949,9 @@ static s

[OpenWrt-Devel] [PATCH v2 7/7] uclient: Handle memory allocation failure for url

Check ptr to url after allocation to prevent null pointer dereference Signed-off-by: Tobias Schramm --- uclient.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/uclient.c b/uclient.c index 8862b55..1137168 100644 --- a/uclient.c +++ b/uclient.c @@ -59,6 +59,9 @@ __uclient_get_url(const s

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH v3 0/4]: imx6: update to Linux 4.14

On 02/18/2018 12:35 PM, John Crispin wrote: > > > On 17/02/18 13:30, Hauke Mehrtens wrote: >> On 02/15/2018 05:34 PM, Tim Harvey wrote: >>> Testted on a Gateworks GW54xx. Does not support enabling imx-drm modules >>> yet as those will need some adjustments based on kernel configs. >>> >>> v3: >>>

Re: [OpenWrt-Devel] [LEDE-DEV] [PATCH v3 0/4]: imx6: update to Linux 4.14

On 18/02/18 16:35, Hauke Mehrtens wrote: On 02/18/2018 12:35 PM, John Crispin wrote: On 17/02/18 13:30, Hauke Mehrtens wrote: On 02/15/2018 05:34 PM, Tim Harvey wrote: Testted on a Gateworks GW54xx. Does not support enabling imx-drm modules yet as those will need some adjustments based on k

Re: [OpenWrt-Devel] [PATCH v2 6/7] uclient-utils: Handle memory allocation failure for url file name

> On Feb 18, 2018, at 5:46 AM, Tobias Schramm wrote: > > Add null pointer check to allocation of url filename > > Signed-off-by: Tobias Schramm > --- > uclient-utils.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/uclient-utils.c b/uclient-utils.c > index a

[OpenWrt-Devel] kernel version status

The next OpenWrt release will use kernel 4.9 and kernel 4.14 depending on the target. All targets that are *not* on either kernel 4.9 or 4.14 will not be included in the next release. I did some overview of the kernel version some months ago here: http://lists.infradead.org/pipermail/lede-dev/2017

Re: [OpenWrt-Devel] [PATCH 5/6] uclient-utils: Handle memory allocation failure for url file name

Yep Philip, you are right. That's a much nicer solution. I'll wait for some more feedback and do just that in v3. 2018-02-18 19:35 GMT+01:00 Philip Prindeville : > > >> On Feb 17, 2018, at 8:36 PM, Tobias Schramm wrote: >> >> Signed-off-by: Tobias Schramm >> --- >> uclient-utils.c | 8 ++-- >

Re: [OpenWrt-Devel] kernel version status

On 18/02/18 22:43, Hauke Mehrtens wrote: The next OpenWrt release will use kernel 4.9 and kernel 4.14 depending on the target. All targets that are *not* on either kernel 4.9 or 4.14 will not be included in the next release. I did some overview of the kernel version some months ago here: http: