Re: [PATCH] kernel: fix mtd partition erase

2020-08-07 Thread John Thomson
On Wed, 5 Aug 2020, at 21:13, John Thomson wrote: > -@@ -213,6 +262,24 @@ static int part_erase(struct mtd_info *m > if (instr->fail_addr != MTD_FAIL_ADDR_UNKNOWN) > instr->fail_addr -= part->offset; I should modify this to avoid the _write, if the _erase fails before the

Re: MT7621 Flow Control

2020-08-07 Thread Jaap Buurman
On Thu, Aug 6, 2020 at 2:35 PM John Crispin wrote: > > > On 06.08.20 14:31, Andre Valentin wrote: > > Hi Jaap, > > > > > > Am 06.08.20 um 13:43 schrieb Jaap Buurman: > >> Dear all, > >> > >> I have noticed the flow control work for mt7621 in the following > >> Openwrt patch: > >>

Merged: tools/firmware-utils: use UTC for image timestamps

2020-08-07 Thread Jo-Philipp Wich
Merged into my staging tree at http://git.openwrt.org/?p=openwrt/staging/jow.git. Thank you! ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel

OpenWRT (ucert) signature check during upgrade

2020-08-07 Thread Andrii Voloshyn
Hi there, I'd like to use signature verification during sysupgrade, but at the moment I get "Image check failed" message. Similar to what guys mentioned here: https://forum.openwrt.org/t/possible-bug-in-ucert/57704 By digging around, I found out that: fwtool -q -T -s /dev/null

RE: Fate of 4.14 targets

2020-08-07 Thread Adrian Schmutzler
> -Original Message- > From: openwrt-devel [mailto:openwrt-devel-boun...@lists.openwrt.org] > On Behalf Of m...@adrianschmutzler.de > Sent: Dienstag, 4. August 2020 16:43 > To: openwrt-devel@lists.openwrt.org > Subject: Fate of 4.14 targets > > Hi together, > > with bcm47xx/bcm53xx

[RFC netifd 2/3] vlan: add pass-through hotplug ops that pass the VLAN info to the bridge

2020-08-07 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- vlan.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/vlan.c b/vlan.c index 6270d95d755d..7d37fef33e2f 100644 --- a/vlan.c +++ b/vlan.c @@ -18,6 +18,8 @@ #include "netifd.h" #include "system.h"

[RFC netifd 3/3] vlandev: add pass-through hotplug ops that pass the VLAN info to the bridge

2020-08-07 Thread Felix Fietkau
Only used for 802.1q devices Signed-off-by: Felix Fietkau --- vlandev.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/vlandev.c b/vlandev.c index 10b78e241576..7efb5f42b5c4 100644 --- a/vlandev.c +++ b/vlandev.c @@ -45,6 +45,7 @@

[RFC netifd 1/3] bridge: add support for defining port member vlans via hotplug ops

2020-08-07 Thread Felix Fietkau
Signed-off-by: Felix Fietkau --- bridge.c| 105 +++- config.c| 1 + device.h| 4 +- interface.c | 10 +++-- interface.h | 2 +- ubus.c | 5 ++- wireless.c | 4 +- 7 files changed, 120 insertions(+), 11 deletions(-)

Re: OpenWRT (ucert) signature check during upgrade

2020-08-07 Thread Daniel Golle
On Fri, Aug 07, 2020 at 03:47:57PM +0300, Andrii Voloshyn wrote: > Hi there, > > I'd like to use signature verification during sysupgrade, but at the moment I > get "Image check failed" message. > Similar to what guys mentioned here: > https://forum.openwrt.org/t/possible-bug-in-ucert/57704 >

Re: [PATCH v2] busybox: bump to 1.32.0

2020-08-07 Thread Petr Štetiar
Hauke Mehrtens [2020-08-06 23:48:55]: Hi, > On 7/28/20 10:14 AM, Petr Štetiar wrote: > > Refreshed patches and config options. Removed upstreamed patches: > > > > 001-remove-stime-function-calls.patch > > 110-no_static_libgcc.patch > > > > Run tested on x86_64 under QEMU. > > > >

Re: MT7621 Flow Control

2020-08-07 Thread Jaap Buurman
On Fri, Aug 7, 2020 at 10:09 AM Kristian Evensen wrote: > > Hello, > > On Thu, Aug 6, 2020 at 1:44 PM Jaap Buurman wrote: > > However, on this mailing list a user by the name of Kristian claims > > that disabling flow control helps fix this problem, as can be read > > here: > >

[PATCH v5] treewide: use wpad-basic-wolfssl as default

2020-08-07 Thread Adrian Schmutzler
From: Petr Štetiar In order to support SAE/WPA3-Personal in default images. Replaced almost all occurencies of wpad-basic and wpad-mini with wpad-basic-wolfssl for consistency. Keeping out ar71xx from the list in order to make the backports easier. Signed-off-by: Petr Štetiar [rebase]

Re: MT7621 Flow Control

2020-08-07 Thread Kristian Evensen
Hello, On Thu, Aug 6, 2020 at 1:44 PM Jaap Buurman wrote: > However, on this mailing list a user by the name of Kristian claims > that disabling flow control helps fix this problem, as can be read > here: > https://lists.openwrt.org/pipermail/openwrt-devel/2017-November/009882.html My patch

[PATCH] bcm47xx: use vendor_model scheme for device/image names

2020-08-07 Thread Adrian Schmutzler
Most targets have been updated to consistently use the vendor_model scheme for device definitions and thus, image names. Apply this to bcm47xx as well. This does _not_ apply any other specific naming changes. Cc: Rafał Miłecki Signed-off-by: Adrian Schmutzler ---

Re: OpenWRT (ucert) signature check during upgrade

2020-08-07 Thread Henrique de Moraes Holschuh
On 07/08/2020 09:47, Andrii Voloshyn wrote: I'd like to use signature verification during sysupgrade, but at the moment I get "Image check failed" message. Similar to what guys mentioned here: https://forum.openwrt.org/t/possible-bug-in-ucert/57704 Keep in mind that, for security purposes,

OpenWrt's 'procd' now speaks containers

2020-08-07 Thread Daniel Golle
Dear community, in the past couple of months I've been working on implementing the Open Container Initiative Runtime Specification [1] in procd by extending the already existing support for slim containers ('ujail'). As a result, there is now a new CLI tool called 'uxc' which handles the basic

Re: [PATCH] busybox: use settimeofday() instead of syscall

2020-08-07 Thread Rosen Penev
On Thu, Aug 6, 2020 at 10:02 PM Rosen Penev wrote: > > On Thu, Aug 6, 2020 at 9:49 PM wrote: > > > > From: Masafumi UTSUGI > > > > SYS_settimeofday syscall is not time64 safe. > > Using settimeofday() instead of syscall() is recommended or > > some C libraries such as musl might cause compile

Re: Policy on BUILD_PATENTED

2020-08-07 Thread Rosen Penev
On Mon, Aug 3, 2020 at 9:11 AM Etienne Champetier wrote: > > Hi Rosen, > > Le lun. 3 août 2020 à 00:04, Rosen Penev a écrit : > > > > Recently there's been a pull request to get patented functionality in > > the packages feed: https://github.com/openwrt/packages/pull/12992 > > > > Which pointed

[PATCH 2/4] build: ipkg-build use fakeroot with PKG_FILE_MODES

2020-08-07 Thread Paul Spooren
The `ipkg-build` script converts a folder into a `opkg` installable package. Until now it would use root:root for all packages and try to preserve file modes. This has the two drawbacks of packages want to add non-root files or add SUID files, like the `sudo` package does. To give more

[PATCH 1/4] tools: add fakeroot

2020-08-07 Thread Paul Spooren
From: Thomas Petazzoni SELinux support requires setting the appropriate SELinux security context to files and directories, which needs to happen at build time in order to support read-only root filesystem scenarios. In order to create these security contexts, we will have to run some

[PATCH 4/4] build: remove INSTALL_SUID

2020-08-07 Thread Paul Spooren
Instead of INSTALL_SUID the PKG_FILE_MODES variable should be used Signed-off-by: Paul Spooren --- rules.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/rules.mk b/rules.mk index 45d96d6be4..d535e57266 100644 --- a/rules.mk +++ b/rules.mk @@ -281,7 +281,6 @@ PATCH:=patch PYTHON:=python

[PATCH 3/4] busybox: Use PKG_FILE_MODES for SUID

2020-08-07 Thread Paul Spooren
Instead of using INSTALL_SUID use the more flexible PKG_FILE_MODES variable withn the Makefile to set the SUID bit. Signed-off-by: Paul Spooren --- package/utils/busybox/Makefile | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/package/utils/busybox/Makefile

[RFC] Policy for PKG_RELEASE bumps

2020-08-07 Thread Paul Spooren
Hi team, currently exist two different ideas on when to raise the PKG_RELEASE of a package. * When functional things change     For example, a OpenWrt specific patch is added * When anything inside the packages ipk file changes     Includes patch and so called "cosmetic" changes outside the

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
On 07.08.20 16:48, Rosen Penev wrote: On Fri, Aug 7, 2020 at 5:42 PM Paul Spooren wrote: On 07.08.20 14:18, Rosen Penev wrote: On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: Fix shellcheck SC2230 which is non-standard. Use builtin 'command -v' instead. Once applied to everything

Re: OpenWrt's 'procd' now speaks containers

2020-08-07 Thread Paul Spooren
On 07.08.20 09:47, Daniel Golle wrote: Dear community, in the past couple of months I've been working on implementing the Open Container Initiative Runtime Specification [1] in procd by extending the already existing support for slim containers ('ujail'). As a result, there is now a new CLI

[PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
Fix shellcheck SC2230 > which is non-standard. Use builtin 'command -v' instead. Once applied to everything concerning OpenWrt we can disable the busybox feature `which` and save 3.8kB. Signed-off-by: Paul Spooren --- include/rootfs.mk| 6 +++---

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Rosen Penev
On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: > > Fix shellcheck SC2230 > > which is non-standard. Use builtin 'command -v' instead. > > Once applied to everything concerning OpenWrt we can disable the busybox > feature `which` and save 3.8kB. which and command -v seem to not be the same.

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Rosen Penev
On Fri, Aug 7, 2020 at 5:42 PM Paul Spooren wrote: > > > On 07.08.20 14:18, Rosen Penev wrote: > > On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: > >> Fix shellcheck SC2230 > >>> which is non-standard. Use builtin 'command -v' instead. > >> Once applied to everything concerning OpenWrt we

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Paul Spooren
On 07.08.20 14:18, Rosen Penev wrote: On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: Fix shellcheck SC2230 which is non-standard. Use builtin 'command -v' instead. Once applied to everything concerning OpenWrt we can disable the busybox feature `which` and save 3.8kB. which and

Re: [PATCH] treewide: replace `which` with `command -v`

2020-08-07 Thread Rosen Penev
On Fri, Aug 7, 2020 at 8:24 PM Paul Spooren wrote: > > > On 07.08.20 16:48, Rosen Penev wrote: > > On Fri, Aug 7, 2020 at 5:42 PM Paul Spooren wrote: > >> > >> On 07.08.20 14:18, Rosen Penev wrote: > >>> On Fri, Aug 7, 2020 at 3:57 PM Paul Spooren wrote: > Fix shellcheck SC2230 > >