Re: [PATCH] base-files: simplify setting device MAC

2021-05-28 Thread Evgeny K
> 3. Drop section name >It's not required by netifd or LuCI & it's not needed by this script >as $device contains a single device name now. It could be convenient to have it, though. In the former scheme of things, if one would like to know the interface behind, say, lan it was possible

Bridge migration breaks network configuration

2021-05-28 Thread Hauke Mehrtens
Hi, The network configuration migration in the 21.02 branch results in a broken network configuration. When I start with the following old network configuration: - config interface 'lan' option type 'bridge' option

Re: Interface names when putting 802.1q VLAN on top of bonding configuration

2021-05-28 Thread Jo-Philipp Wich
Hi, the following should do what you want. config device option type 8021q option ifname bonding-lan option vid 20 option name vlan20 config interface vlan20 option ifname vlan20 option proto static option ipaddr 172.20.34.2 option netmask 255.255.255.128 ~ Jo signature.asc

[PATCH luci] treewide: drop MAC and MTU from interfaces (protocols)

2021-05-28 Thread Rafał Miłecki
From: Rafał Miłecki Those are L2 options that are not part of interfaces (L3), should not be set there and don't work. Setting MAC and MTU should be done at device layer (config device) and is supported for basic types already. Signed-off-by: Rafał Miłecki ---

Re: [PATCH] ugps: start also in case device is absent

2021-05-28 Thread Piotr Dymacz
Hi Daniel, On 27.05.2021 12:37, Daniel Golle wrote: Don't bail out from init script in case the GPS device is missing. Some modems take time to come up, and some people may use things like 'kplex' to feed ugpsd. Hence it is better to always start ugpsd unconditionally and let procd's respawn

Re: [PATCH] ath79: rb4xx-nand: fix 512 byte pages compatibility

2021-05-28 Thread Bas Mevissen via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- A few nitpicks: On 2021-05-28

Re: [PATCH] ugps: start also in case device is absent

2021-05-28 Thread Daniel Golle
On Fri, May 28, 2021 at 09:58:48AM +0200, Piotr Dymacz wrote: > Hi Daniel, > > On 27.05.2021 12:37, Daniel Golle wrote: > > Don't bail out from init script in case the GPS device is missing. > > Some modems take time to come up, and some people may use things like > > 'kplex' to feed ugpsd. Hence

[PATCH] base-files: simplify setting device MAC

2021-05-28 Thread Rafał Miłecki
From: Rafał Miłecki 1. Move code above interface generation It results in more logical order. Device gets its config section above interface section. 2. Drop the loop We have separated code handling bridges now so $device should be guaranteed to contain a single device name. 3. Drop

Re: [PATCH] ath79: rb4xx-nand: fix 512 byte pages compatibility

2021-05-28 Thread Sergey Ryazanov
Hello Bas, thank you for your review, please find my comments below. On Fri, May 28, 2021 at 11:41 AM Bas Mevissen wrote: > On 2021-05-28 00:27, Sergey Ryazanov wrote: [skipped] >> +static int rb4xx_nand_attach_chip(struct nand_chip *chip) >> +{ >> + struct mtd_info *mtd =

Re: [PATCH] ath79: rb4xx-nand: fix 512 byte pages compatibility

2021-05-28 Thread Bas Mevissen via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- On 2021-05-28 13:55, Sergey

[PATCH] toolchain: gdb: Add optional python support

2021-05-28 Thread Hauke Mehrtens via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Compile gdb with python support

Re: Interface names when putting 802.1q VLAN on top of bonding configuration

2021-05-28 Thread Mike Bernardo
Ah thanks! This worked great. I swear I tried something nearly identical before that broke everything. Mike > On 2021/05/28, at 02:34:44 CDT (-05:00), Jo-Philipp Wich wrote: > > Hi, > > the following should do what you want. > > config device > option type 8021q > option ifname