Re: [PATCH] ubus: add a private field to event handlers

2021-07-14 Thread Louis_Hampton
We use generated Rust bindings to libubus, and our own thread as opposed to uloop. "container_of", quite aside from not being exported, violates the strong types and memory safety rules we've previously been able to uphold. This isn't an issue with callbacks from "ubus_invoke_fd", where we can

Missing files from package build by buildbot and no Phase 2 logs

2021-07-14 Thread Luiz Angelo Daros de Luca
Hello, I'm trying to identify what caused https://github.com/openwrt/packages/issues/16085. If I build the package locally, I get everything in place. However, the file built by buildbot is missing some files. The command that would copy those is:

Re: [PATCH v4] mvebu: add support for iEi Puzzle-M901/Puzzle-M902

2021-07-14 Thread Daniel Golle
Hi Ian, the patch looks good to me now, however, it doesn't apply: Applying: mvebu: add support for iEi Puzzle-M901/Puzzle-M902 error: corrupt patch at line 433 Patch failed at 0001 mvebu: add support for iEi Puzzle-M901/Puzzle-M902 hint: Use 'git am --show-current-patch=diff' to see the failed

Re: [PATCH] ubus: add a private field to event handlers

2021-07-14 Thread Felix Fietkau
On 2021-07-13 13:57, louis_hamp...@sercomm.com wrote: > > This is particularly useful in multithreaded non-C FFI, where > additional context from where the event handler was registered may be > critical to ensuring the output of the event is sent to the right > location. > > Signed-off-by: Louis