Hello,
I am sending patches to remove PCengines apuX boardname checking for
leds-apu2 and gpio-nct5104d kernel modules.
No need to check boardname, which is squishy in different versions of
coreboot.
https://github.com/pcengines/coreboot/compare/v4.6.6...v4.6.7
contact IRC: muhaha
Thanks
--
BR,
Lukáš Mrtvý
From b7130b24c975301741d8dc69dea10bfb6348f0e3 Mon Sep 17 00:00:00 2001
From: Lukas Mrtvy <lukas.mr...@gmail.com>
Date: Wed, 11 Jul 2018 10:22:27 +0200
Subject: [PATCH] kernel: leds-apu2 remove boardname check
'In different versions of coreboot are different names of apu boardname.
No need to check boardname to load module.'
Signed-off-by: Lukas Mrtvy <lukas.mr...@gmail.com>
---
package/kernel/leds-apu2/src/leds-apu2.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/package/kernel/leds-apu2/src/leds-apu2.c b/package/kernel/leds-apu2/src/leds-apu2.c
index 2fefa857cb..ff13b3cde1 100644
--- a/package/kernel/leds-apu2/src/leds-apu2.c
+++ b/package/kernel/leds-apu2/src/leds-apu2.c
@@ -331,18 +331,6 @@ static int __init gpio_apu2_init (void)
const char *board_vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
const char *board_name = dmi_get_system_info(DMI_BOARD_NAME);
- /* Match the device name/model */
- if (!board_name \
- || !board_vendor \
- || strcasecmp(board_vendor, "PC Engines") \
- || (strcasecmp(board_name, "apu2") \
- && strcasecmp(board_name, "apu3") \
- && strcasecmp(board_name, "PC Engines apu2") \
- && strcasecmp(board_name, "PC Engines apu3"))) {
- err = -ENODEV;
- goto exit;
- }
-
pr_info ("%s: load APU2/LED GPIO driver module\n", DEVNAME);
err = platform_driver_register (&gpio_apu2_driver);
--
2.14.1
From 16bea0282210affa4603543d4c0deff1539843e3 Mon Sep 17 00:00:00 2001
From: Lukas Mrtvy <lukas.mr...@gmail.com>
Date: Wed, 11 Jul 2018 10:33:00 +0200
Subject: [PATCH] kernel: gpio-nct5104d remove boardname check
'In different versions of coreboot are different names of apu boardname.
No need to check boardname to load module.'
Signed-off-by: Lukas Mrtvy <lukas.mr...@gmail.com>
---
package/kernel/gpio-nct5104d/src/gpio-nct5104d.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c b/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c
index c139cf8d20..8da7580562 100644
--- a/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c
+++ b/package/kernel/gpio-nct5104d/src/gpio-nct5104d.c
@@ -434,11 +434,6 @@ static int __init nct5104d_gpio_init(void)
const char *board_vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
const char *board_name = dmi_get_system_info(DMI_BOARD_NAME);
- /* Make sure we only run on PC Engine APU boards */
- if (!board_name || !board_vendor || strcasecmp(board_vendor, "PC Engines") || strncasecmp(board_name, "apu", 3)) {
- return -ENODEV;
- }
-
if (nct5104d_find(0x2e, &sio) &&
nct5104d_find(0x4e, &sio))
return -ENODEV;
--
2.14.1
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
