Re: [PATCH] ipq40xx: pakedge_wr-1: convert to DSA

2022-10-05 Thread Christian Marangi 
On Mon, Oct 03, 2022 at 02:59:15PM +0200, Tomasz Maciej Nowak wrote:
> From: Tomasz Maciej Nowak 
> 
> And enable the device.
> 
> Signed-off-by: Tomasz Maciej Nowak 

Hi, merged with ee38573093563a11569afd98495f7a7a85e9a02f with minor
changes to the commit description.

Thanks!

> ---
>  .../ipq40xx/base-files/etc/board.d/02_network |  1 +
>  .../arch/arm/boot/dts/qcom-ipq4018-wr-1.dts   | 37 +++
>  target/linux/ipq40xx/image/generic.mk |  3 +-
>  3 files changed, 39 insertions(+), 2 deletions(-)
> 
> diff --git a/target/linux/ipq40xx/base-files/etc/board.d/02_network 
> b/target/linux/ipq40xx/base-files/etc/board.d/02_network
> index d9a162b10d42..163dcdcbc681 100644
> --- a/target/linux/ipq40xx/base-files/etc/board.d/02_network
> +++ b/target/linux/ipq40xx/base-files/etc/board.d/02_network
> @@ -21,6 +21,7 @@ ipq40xx_setup_interfaces()
>   mikrotik,hap-ac3|\
>   p2w,r619ac-64m|\
>   p2w,r619ac-128m|\
> + pakedge,wr-1|\
>   zyxel,nbg6617)
>   ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4" "wan"
>   ;;
> diff --git 
> a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts 
> b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
> index 317fe26e2e9a..16951da47fc0 100644
> --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
> +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
> @@ -11,6 +11,7 @@
>   compatible = "pakedge,wr-1";
>  
>   aliases {
> + label-mac-device = 
>   led-boot = _power;
>   led-failsafe = _power;
>   led-running = _power;
> @@ -177,6 +178,10 @@
>   status = "okay";
>  };
>  
> + {
> + status = "okay";
> +};
> +
>   {
>   status = "okay";
>  };
> @@ -185,6 +190,38 @@
>   status = "okay";
>  };
>  
> + {
> + status = "okay";
> +};
> +
> + {
> + status = "okay";
> +
> + label = "lan4";
> +};
> +
> + {
> + status = "okay";
> +
> + label = "lan3";
> +};
> +
> + {
> + status = "okay";
> +
> + label = "lan2";
> +};
> +
> + {
> + status = "okay";
> +
> + label = "lan1";
> +};
> +
> + {
> + status = "okay";
> +};
> +
>   {
>   key_pins: key_pinmux {
>   mux {
> diff --git a/target/linux/ipq40xx/image/generic.mk 
> b/target/linux/ipq40xx/image/generic.mk
> index 69ec42c26657..3c1cf6744882 100644
> --- a/target/linux/ipq40xx/image/generic.mk
> +++ b/target/linux/ipq40xx/image/generic.mk
> @@ -938,8 +938,7 @@ define Device/pakedge_wr-1
>   IMAGE_SIZE := 31232k
>   IMAGE/sysupgrade.bin := append-kernel | pad-to (BLOCKSIZE) | 
> append-rootfs | pad-rootfs | append-metadata
>  endef
> -# Missing DSA Setup
> -#TARGET_DEVICES += pakedge_wr-1
> +TARGET_DEVICES += pakedge_wr-1
>  
>  define Device/plasmacloud_pa1200
>   $(call Device/FitImageLzma)
> -- 
> 2.37.3
> 
> 
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

-- 
Ansuel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [PATCH] ipq40xx: pakedge_wr-1: convert to DSA

2022-10-05 Thread Robert Marko 
On Mon, 3 Oct 2022 at 15:00, Tomasz Maciej Nowak  wrote:
>
> From: Tomasz Maciej Nowak 
>
> And enable the device.
>
> Signed-off-by: Tomasz Maciej Nowak 

LGTM, so:
Reviewed-by: Robert Marko 
> ---
>  .../ipq40xx/base-files/etc/board.d/02_network |  1 +
>  .../arch/arm/boot/dts/qcom-ipq4018-wr-1.dts   | 37 +++
>  target/linux/ipq40xx/image/generic.mk |  3 +-
>  3 files changed, 39 insertions(+), 2 deletions(-)
>
> diff --git a/target/linux/ipq40xx/base-files/etc/board.d/02_network 
> b/target/linux/ipq40xx/base-files/etc/board.d/02_network
> index d9a162b10d42..163dcdcbc681 100644
> --- a/target/linux/ipq40xx/base-files/etc/board.d/02_network
> +++ b/target/linux/ipq40xx/base-files/etc/board.d/02_network
> @@ -21,6 +21,7 @@ ipq40xx_setup_interfaces()
> mikrotik,hap-ac3|\
> p2w,r619ac-64m|\
> p2w,r619ac-128m|\
> +   pakedge,wr-1|\
> zyxel,nbg6617)
> ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4" "wan"
> ;;
> diff --git 
> a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts 
> b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
> index 317fe26e2e9a..16951da47fc0 100644
> --- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
> +++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
> @@ -11,6 +11,7 @@
> compatible = "pakedge,wr-1";
>
> aliases {
> +   label-mac-device = 
> led-boot = _power;
> led-failsafe = _power;
> led-running = _power;
> @@ -177,6 +178,10 @@
> status = "okay";
>  };
>
> + {
> +   status = "okay";
> +};
> +
>   {
> status = "okay";
>  };
> @@ -185,6 +190,38 @@
> status = "okay";
>  };
>
> + {
> +   status = "okay";
> +};
> +
> + {
> +   status = "okay";
> +
> +   label = "lan4";
> +};
> +
> + {
> +   status = "okay";
> +
> +   label = "lan3";
> +};
> +
> + {
> +   status = "okay";
> +
> +   label = "lan2";
> +};
> +
> + {
> +   status = "okay";
> +
> +   label = "lan1";
> +};
> +
> + {
> +   status = "okay";
> +};
> +
>   {
> key_pins: key_pinmux {
> mux {
> diff --git a/target/linux/ipq40xx/image/generic.mk 
> b/target/linux/ipq40xx/image/generic.mk
> index 69ec42c26657..3c1cf6744882 100644
> --- a/target/linux/ipq40xx/image/generic.mk
> +++ b/target/linux/ipq40xx/image/generic.mk
> @@ -938,8 +938,7 @@ define Device/pakedge_wr-1
> IMAGE_SIZE := 31232k
> IMAGE/sysupgrade.bin := append-kernel | pad-to (BLOCKSIZE) | 
> append-rootfs | pad-rootfs | append-metadata
>  endef
> -# Missing DSA Setup
> -#TARGET_DEVICES += pakedge_wr-1
> +TARGET_DEVICES += pakedge_wr-1
>
>  define Device/plasmacloud_pa1200
> $(call Device/FitImageLzma)
> --
> 2.37.3
>
>
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[PATCH] ipq40xx: pakedge_wr-1: convert to DSA

2022-10-03 Thread Tomasz Maciej Nowak 
From: Tomasz Maciej Nowak 

And enable the device.

Signed-off-by: Tomasz Maciej Nowak 
---
 .../ipq40xx/base-files/etc/board.d/02_network |  1 +
 .../arch/arm/boot/dts/qcom-ipq4018-wr-1.dts   | 37 +++
 target/linux/ipq40xx/image/generic.mk |  3 +-
 3 files changed, 39 insertions(+), 2 deletions(-)

diff --git a/target/linux/ipq40xx/base-files/etc/board.d/02_network 
b/target/linux/ipq40xx/base-files/etc/board.d/02_network
index d9a162b10d42..163dcdcbc681 100644
--- a/target/linux/ipq40xx/base-files/etc/board.d/02_network
+++ b/target/linux/ipq40xx/base-files/etc/board.d/02_network
@@ -21,6 +21,7 @@ ipq40xx_setup_interfaces()
mikrotik,hap-ac3|\
p2w,r619ac-64m|\
p2w,r619ac-128m|\
+   pakedge,wr-1|\
zyxel,nbg6617)
ucidef_set_interfaces_lan_wan "lan1 lan2 lan3 lan4" "wan"
;;
diff --git a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts 
b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
index 317fe26e2e9a..16951da47fc0 100644
--- a/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
+++ b/target/linux/ipq40xx/files/arch/arm/boot/dts/qcom-ipq4018-wr-1.dts
@@ -11,6 +11,7 @@
compatible = "pakedge,wr-1";
 
aliases {
+   label-mac-device = 
led-boot = _power;
led-failsafe = _power;
led-running = _power;
@@ -177,6 +178,10 @@
status = "okay";
 };
 
+ {
+   status = "okay";
+};
+
  {
status = "okay";
 };
@@ -185,6 +190,38 @@
status = "okay";
 };
 
+ {
+   status = "okay";
+};
+
+ {
+   status = "okay";
+
+   label = "lan4";
+};
+
+ {
+   status = "okay";
+
+   label = "lan3";
+};
+
+ {
+   status = "okay";
+
+   label = "lan2";
+};
+
+ {
+   status = "okay";
+
+   label = "lan1";
+};
+
+ {
+   status = "okay";
+};
+
  {
key_pins: key_pinmux {
mux {
diff --git a/target/linux/ipq40xx/image/generic.mk 
b/target/linux/ipq40xx/image/generic.mk
index 69ec42c26657..3c1cf6744882 100644
--- a/target/linux/ipq40xx/image/generic.mk
+++ b/target/linux/ipq40xx/image/generic.mk
@@ -938,8 +938,7 @@ define Device/pakedge_wr-1
IMAGE_SIZE := 31232k
IMAGE/sysupgrade.bin := append-kernel | pad-to (BLOCKSIZE) | 
append-rootfs | pad-rootfs | append-metadata
 endef
-# Missing DSA Setup
-#TARGET_DEVICES += pakedge_wr-1
+TARGET_DEVICES += pakedge_wr-1
 
 define Device/plasmacloud_pa1200
$(call Device/FitImageLzma)
-- 
2.37.3


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel