Re: [PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-15 Thread Stijn Tintel
On 4/04/2024 19:42, INAGAKI Hiroshi wrote: Hi stijn, Hi Hiroshi, I have some comments below. Thanks for reviewing! On 2024/04/04 23:28, st...@linux-ipv6.be wrote: + +    reboot@0 { +    compatible = "edgecore,reboot"; Isn't this a "gpio-restart"? I can't find any informations about

Re: [PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-04 Thread Sander Vanheule
Hi Stijn, On Thu, 2024-04-04 at 17:28 +0300, st...@linux-ipv6.be wrote: > Add support for the Edgecore ECS4100-12PH, an 8-port PoE Gigabit > Ethernet switch with 2 combo RJ45/SFP and 2 SFP ports. > > Hardware: > * SoC: RTL8392M > * RAM: 256MiB > * Flash: 32MiB SPI-NOR > * Ethernet: >   * 8x GbE

Re: [PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-04 Thread Paul D
On 2024-04-04 17:02, Stijn Tintel wrote: > On 4/04/2024 18:00, Paul D wrote: >> On 2024-04-04 16:28, st...@linux-ipv6.be wrote: >> >>> -netgear,gs110tpp-v1) >>> -    ucidef_set_poe 130 "$(filter_port_list "$lan_list" "lan9 lan10")" >>> -    ;; >> If adding a device, surely these remove lines

Re: [PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-04 Thread INAGAKI Hiroshi
Hi stijn, I have some comments below. On 2024/04/04 23:28, st...@linux-ipv6.be wrote: Add support for the Edgecore ECS4100-12PH, an 8-port PoE Gigabit Ethernet switch with 2 combo RJ45/SFP and 2 SFP ports. Hardware: * SoC: RTL8392M * RAM: 256MiB * Flash: 32MiB SPI-NOR * Ethernet: * 8x GbE

Re: [PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-04 Thread Stijn Tintel
On 4/04/2024 17:28, st...@linux-ipv6.be wrote: Add support for the Edgecore ECS4100-12PH, an 8-port PoE Gigabit Ethernet switch with 2 combo RJ45/SFP and 2 SFP ports. FYI: this patch and WIP changes are also available in my staging tree:

Re: [PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-04 Thread Stijn Tintel
On 4/04/2024 18:00, Paul D wrote: On 2024-04-04 16:28, st...@linux-ipv6.be wrote: -netgear,gs110tpp-v1) - ucidef_set_poe 130 "$(filter_port_list "$lan_list" "lan9 lan10")" - ;; If adding a device, surely these remove lines should not be there? Try looking closer. It's called

Re: [PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-04 Thread Paul D
On 2024-04-04 16:28, st...@linux-ipv6.be wrote: > -netgear,gs110tpp-v1) > - ucidef_set_poe 130 "$(filter_port_list "$lan_list" "lan9 lan10")" > - ;; If adding a device, surely these remove lines should not be there? ___ openwrt-devel mailing

[PATCH] realtek/rtl839x: Edgecore ECS4100-12PH support

2024-04-04 Thread stijn
Add support for the Edgecore ECS4100-12PH, an 8-port PoE Gigabit Ethernet switch with 2 combo RJ45/SFP and 2 SFP ports. Hardware: * SoC: RTL8392M * RAM: 256MiB * Flash: 32MiB SPI-NOR * Ethernet: * 8x GbE RJ45 PoE (built-in RTL8218B) * 2x GbE RJ45 / SFP combo * 2x SFP * Console: RJ45 RS232