Re: [PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L
Hi all!! On Tue, 8 Aug 2023, Linus Walleij wrote: Date: Tue, 8 Aug 2023 09:38:09 From: Linus Walleij To: Felix Baumann Cc: openwrt-devel@lists.openwrt.org, Rafal Milecki , Alvaro Fernandez Rojas Subject: Re: [PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L On Tue, Aug 1, 2023 at 10:20 AM Felix Baumann wrote: The overall problem is that not all patches are being looked at immediately and then they are being forgotten about. Not enough reviewers, yes. :/ I added some people to CC, that might be able to take a look at this. (mostly because I know that they are working with broadcom devices) Hm, lack of reviewers is a universal problem, but also lack of reviewers who are also comitters. A lot of patches are simply applied without review by maintainers who know what they are doing, and that is what one has to do when the community isn't big enough. In the Linux DRM community we solved it by liberally handing out commit access. It works there. I'm pretty sure I can handle commit access but I have no idea how that is handled out in the OpenWrt community. Some level of trust I suppose. this happens by a voting call. I was searching for a wik page documenting it, but so far I only fond this link which may serve as an example: https://openwrt.org/voting/2023-04-25 But I would be all for giving you commit access, given the relevance and the amount of your contributions. Enrico Yours, Linus Walleij ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L
On Tue, Aug 1, 2023 at 10:20 AM Felix Baumann wrote: > The overall problem is that not all patches are being looked at immediately > and > then they are being forgotten about. Not enough reviewers, yes. :/ > > I added some people to CC, that might be able to take a look at this. (mostly > because > I know that they are working with broadcom devices) Hm, lack of reviewers is a universal problem, but also lack of reviewers who are also comitters. A lot of patches are simply applied without review by maintainers who know what they are doing, and that is what one has to do when the community isn't big enough. In the Linux DRM community we solved it by liberally handing out commit access. It works there. I'm pretty sure I can handle commit access but I have no idea how that is handled out in the OpenWrt community. Some level of trust I suppose. Yours, Linus Walleij ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L
Petr Štetiar writes: > Bjørn Mork [2023-08-01 08:51:03]: > >> There's a "6 approving reviews" rule on github, and not >> even close to that many active reviewers. Sp adding new devices via >> pull requests seems impossible at the moment. > > Thats done on purpose, due to the current git.openwrt.org based workflow, > basically to prevent accidental merging via GH as this would break Git > repository sync. AFAIK GH simply doesn't allow us to disable those merge > buttons, so this is our workaround. Well, OK. But since there is no merging any other way, the impression left to random developers passing by is that it's futile to send pull requests. Obviously not a precise count of requess ready to be merged, but IMHO still an indication of the sorry state: https://github.com/openwrt/openwrt/pulls?q=is%3Apr+is%3Aopen+%22add+support+%22 Now I know that reviewer resources ia s problem for all projects, so I probably shouldn't whine about it. But I do have a hard time understanding the current OpenWrt workflow. Bjørn ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L
Am 1. August 2023 08:51:03 MESZ schrieb "Bjørn Mork" : >Linus Walleij writes: > >> can also create a pull request on github if it helps? > >Probably not. There's a "6 approving reviews" rule on github, and not >even close to that many active reviewers. Sp adding new devices via >pull requests seems impossible at the moment. > > >Bjørn > >___ >openwrt-devel mailing list >openwrt-devel@lists.openwrt.org >https://lists.openwrt.org/mailman/listinfo/openwrt-devel That is just an arbitrary number (probably to prevent accidental merges or so). Most device PRs seem to be merged by Hauke. But not all of them. You don't need 6 reviews. But it helps when you have others that are able to test your code change and confirm that it works. (that won't happen much on adding new devices though) But I agree that opening a PR on GitHub won't move this along. I guess, you can mostly revive the patch series by reminding people. Or ask them on IRC for review. The overall problem is that not all patches are being looked at immediately and then they are being forgotten about. Not enough reviewers, yes. :/ I added some people to CC, that might be able to take a look at this. (mostly because I know that they are working with broadcom devices) Also sorry, I butchered your names, my mail program (K9) doesn't support non-ascii characters. (so dumb) Regards Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L
Bjørn Mork [2023-08-01 08:51:03]: Hi, > Linus Walleij writes: > > > can also create a pull request on github if it helps? > > Probably not. BTW I'm doing both, mailing list to notify first pair of eyes not following GH closely, and PRs on GH to get another review attention and mainly to be somehow sure, that I don't introduce regressions as there is quite heavy CI machinery. > There's a "6 approving reviews" rule on github, and not > even close to that many active reviewers. Sp adding new devices via > pull requests seems impossible at the moment. Thats done on purpose, due to the current git.openwrt.org based workflow, basically to prevent accidental merging via GH as this would break Git repository sync. AFAIK GH simply doesn't allow us to disable those merge buttons, so this is our workaround. Cheers, Petr ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L
Linus Walleij writes: > can also create a pull request on github if it helps? Probably not. There's a "6 approving reviews" rule on github, and not even close to that many active reviewers. Sp adding new devices via pull requests seems impossible at the moment. Bjørn ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L
On Mon, Jun 19, 2023 at 8:36 AM Linus Walleij wrote: > This adds support for the D-Link DIR-890L router. > > Linus Walleij (5): > bcm53xx: Fix kernel v6.1 config > uboot-bcm53xx: Add U-Boot for NorthStar BCM53xx > bcm53xx: Add support for D-Link DIR-890L > bcm53xx: dir885/dir890: Tag both partitions as SEAMA > bcm53xx: Add network configuration for DIR-890L Hints on how to proceed with this? Any problem with the patches? I can also create a pull request on github if it helps? Yours, Linus Walleij ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH v3 0/5] bcm53xx: Support D-Link DIR-890L
This adds support for the D-Link DIR-890L router. Linus Walleij (5): bcm53xx: Fix kernel v6.1 config uboot-bcm53xx: Add U-Boot for NorthStar BCM53xx bcm53xx: Add support for D-Link DIR-890L bcm53xx: dir885/dir890: Tag both partitions as SEAMA bcm53xx: Add network configuration for DIR-890L .github/labeler.yml | 1 + package/boot/uboot-bcm53xx/Makefile | 37 + ...0001-nand-brcmnand-add-iproc-support.patch | 199 ++ ...nand_base-Handle-algorithm-selection.patch | 80 +++ ...t-device-tree-for-Broadcom-Northstar.patch | 659 ++ ...port-for-the-Broadcom-Northstar-SoCs.patch | 66 ++ ...ard-Add-new-Broadcom-Northstar-board.patch | 372 ++ .../bcm53xx/base-files/etc/board.d/02_network | 4 + .../base-files/etc/uci-defaults/09_fix_crc| 3 +- .../base-files/lib/upgrade/platform.sh| 1 + target/linux/bcm53xx/config-6.1 | 2 + target/linux/bcm53xx/image/Makefile | 21 + ...-BCM5301X-Describe-partition-formats.patch | 15 +- ...-BCM5301X-Describe-partition-formats.patch | 15 +- 14 files changed, 1470 insertions(+), 5 deletions(-) create mode 100644 package/boot/uboot-bcm53xx/Makefile create mode 100644 package/boot/uboot-bcm53xx/patches/0001-nand-brcmnand-add-iproc-support.patch create mode 100644 package/boot/uboot-bcm53xx/patches/0002-mtd-rawnand-nand_base-Handle-algorithm-selection.patch create mode 100644 package/boot/uboot-bcm53xx/patches/0003-arm-dts-Import-device-tree-for-Broadcom-Northstar.patch create mode 100644 package/boot/uboot-bcm53xx/patches/0004-arm-Add-support-for-the-Broadcom-Northstar-SoCs.patch create mode 100644 package/boot/uboot-bcm53xx/patches/0005-board-Add-new-Broadcom-Northstar-board.patch -- 2.34.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
