Re: [OpenWrt-Devel] [PATCH 0/3] Add kernel support for Fintek Super-IO chips

2020-03-25 Thread Daniel Golle
On Wed, Mar 25, 2020 at 09:02:34AM +0100, Petr Štetiar wrote:
> Nick Bowler  [2020-03-24 21:14:51]:
> 
> > On 2020-03-21, Daniel Golle  wrote:
> > > On Wed, Mar 18, 2020 at 11:27:09PM -0400, Nick Bowler wrote:
> > >> This series enables packaging of the Linux hwmon, watchdog and gpio
> > >> drivers that support multiple Fintek Super-IO chips.  In particular,
> > >> the Fintek F71869A is used on the Jetway NF99FL board and the stock
> > >> OpenWRT kernels appear to completely lack drivers for this chip.
> > >
> > > The driver looks ACPI/x86-specific, please add target dependency or
> > > move the package definition to target/linux/x86/modules.mk.
> > 
> > I think there shouldn't be anything _inherently_ x86 specific about
> > the drivers themselves although probably nobody uses Super-IO chips
> > like these outside of the PC-compatible world.
> 
> Those symbols have `depends on !PPC` config constraint in the kernel.

... which is the only other platform using ACPI apart from x86...
(the driver depends on ACPI)

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 0/3] Add kernel support for Fintek Super-IO chips

2020-03-25 Thread Petr Štetiar
Nick Bowler  [2020-03-24 21:14:51]:

> On 2020-03-21, Daniel Golle  wrote:
> > On Wed, Mar 18, 2020 at 11:27:09PM -0400, Nick Bowler wrote:
> >> This series enables packaging of the Linux hwmon, watchdog and gpio
> >> drivers that support multiple Fintek Super-IO chips.  In particular,
> >> the Fintek F71869A is used on the Jetway NF99FL board and the stock
> >> OpenWRT kernels appear to completely lack drivers for this chip.
> >
> > The driver looks ACPI/x86-specific, please add target dependency or
> > move the package definition to target/linux/x86/modules.mk.
> 
> I think there shouldn't be anything _inherently_ x86 specific about
> the drivers themselves although probably nobody uses Super-IO chips
> like these outside of the PC-compatible world.

Those symbols have `depends on !PPC` config constraint in the kernel.

-- ynezz

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 0/3] Add kernel support for Fintek Super-IO chips

2020-03-24 Thread Nick Bowler
On 2020-03-21, Daniel Golle  wrote:
> On Wed, Mar 18, 2020 at 11:27:09PM -0400, Nick Bowler wrote:
>> This series enables packaging of the Linux hwmon, watchdog and gpio
>> drivers that support multiple Fintek Super-IO chips.  In particular,
>> the Fintek F71869A is used on the Jetway NF99FL board and the stock
>> OpenWRT kernels appear to completely lack drivers for this chip.
>
> The driver looks ACPI/x86-specific, please add target dependency or
> move the package definition to target/linux/x86/modules.mk.

I think there shouldn't be anything _inherently_ x86 specific about
the drivers themselves although probably nobody uses Super-IO chips
like these outside of the PC-compatible world.

I do see that most (but not all) drivers for Super-IO controllers
packaged in openwrt currently have a TARGET_x86 dependency, so I
will submit v2 with the dependency added to these new packages.

Cheers,
  Nick

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH 0/3] Add kernel support for Fintek Super-IO chips

2020-03-21 Thread Daniel Golle
On Wed, Mar 18, 2020 at 11:27:09PM -0400, Nick Bowler wrote:
> This series enables packaging of the Linux hwmon, watchdog and gpio
> drivers that support multiple Fintek Super-IO chips.  In particular,
> the Fintek F71869A is used on the Jetway NF99FL board and the stock
> OpenWRT kernels appear to completely lack drivers for this chip.

The driver looks ACPI/x86-specific, please add target dependency or
move the package definition to target/linux/x86/modules.mk.

Cheers

Daniel


> 
> Nick Bowler (3):
>   kernel: package f71882fg hwmon driver
>   kernel: package f71808e-wdt driver
>   kernel: package gpio-f7188x driver
> 
>  package/kernel/linux/modules/hwmon.mk | 15 +
>  package/kernel/linux/modules/other.mk | 31 +++
>  2 files changed, 46 insertions(+)
> 
> -- 
> 2.24.1
> 
> 
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel