Re: [PATCH] kernel: DSA roaming fix for Marvell Link Street switch series

2021-02-15 Thread Eneas U de Queiroz
On Tue, Feb 2, 2021 at 6:15 AM DENG Qingfang wrote: > > Marvell Link Street switch series cannot perform MAC learning from > CPU-injected (FROM_CPU) DSA frames, which results in 2 issues. > - excessive flooding, due to the fact that DSA treats those addresses > as unknown > - the risk of stale

Re: [PATCH] kernel: DSA roaming fix for Marvell Link Street switch series

2021-02-12 Thread Tad
Happy Friday! I've been using this patchset for 10 days now without issue. It has been available on my builds since then and I've had no issues reported. I've also seen a handful others on the OpenWrt forum make use of it. Of note, 776-v5.12-net-dsa-mv88e6xxx-override-portvec-if-unicast.patch

Re: [PATCH] kernel: DSA roaming fix for Marvell Link Street switch series

2021-02-03 Thread DENG Qingfang
On Wed, Feb 3, 2021 at 4:20 PM Tobias Waldekranz wrote: > > AFAIK, no. There is a per-port bit that you can set to ignore the > errors, i.e. no violation is generated, but I am pretty sure that the > frame is still dropped. I just tested on my WRT1900AC v2. It seems that the CPU can receive

Re: [PATCH] kernel: DSA roaming fix for Marvell Link Street switch series

2021-02-03 Thread Tobias Waldekranz
On Tue Feb 2, 2021 at 11:03 PM CET, DENG Qingfang wrote: > On Tue, Feb 2, 2021 at 9:22 PM Tobias Waldekranz > wrote: > > > > > > > > Tobias, what happens if the switch receives a frame that violates ATU > > > portvec member? Is the frame trapped to the CPU or dropped? > > > > The frame will be

Re: [PATCH] kernel: DSA roaming fix for Marvell Link Street switch series

2021-02-02 Thread DENG Qingfang
On Tue, Feb 2, 2021 at 9:22 PM Tobias Waldekranz wrote: > > > > > Tobias, what happens if the switch receives a frame that violates ATU > > portvec member? Is the frame trapped to the CPU or dropped? > > The frame will be dropped. So the flow will be blocked until the DSA > driver removes the

Re: [PATCH] kernel: DSA roaming fix for Marvell Link Street switch series

2021-02-02 Thread Tobias Waldekranz
On Tue Feb 2, 2021 at 9:31 PM CET, DENG Qingfang wrote: > On Tue, Feb 2, 2021 at 8:14 PM Tad wrote: > > > > I've tested this working well! > > Devices can roam during iperf with no loss! > > Thank you! > > > > > > There are some errors in dmesg: > > wrt1900acv1 > > mv88e6085 f1072004.mdio-mii:00:

Re: [PATCH] kernel: DSA roaming fix for Marvell Link Street switch series

2021-02-02 Thread DENG Qingfang
On Tue, Feb 2, 2021 at 8:14 PM Tad wrote: > > I've tested this working well! > Devices can roam during iperf with no loss! > Thank you! > > > There are some errors in dmesg: > wrt1900acv1 > mv88e6085 f1072004.mdio-mii:00: ATU member violation for [mac] portvec 20 > spid 3 > > wrt1200ac >

Re: [PATCH] kernel: DSA roaming fix for Marvell Link Street switch series

2021-02-02 Thread Tad
I've tested this working well! Devices can roam during iperf with no loss! Thank you! There are some errors in dmesg: wrt1900acv1 mv88e6085 f1072004.mdio-mii:00: ATU member violation for [mac] portvec 20 spid 3 wrt1200ac mv88e6085 f1072004.mdio-mii:00: ATU member violation for [mac] portvec 40