Re: [PATCH 3/3] mediatek: mt7623: use bash for generating bootable images

2020-09-08 Thread David Woodhouse
On Tue, 2020-09-08 at 10:42 +0200, Felix Fietkau wrote: > Sure, using bash is fine. We already require it for many other > things. I did make an effort to remove bashisms as part of the review before adding this script, but yeah, we can live with bash for now. For the time being I do still need

Re: [PATCH 3/3] mediatek: mt7623: use bash for generating bootable images

2020-09-08 Thread Felix Fietkau
On 2020-09-08 10:39, David Woodhouse wrote: > On Tue, 2020-09-08 at 10:31 +0200, Felix Fietkau wrote: >> On 2020-09-08 10:26, David Woodhouse wrote: >> > It turns out that 'echo -e' isn't portable; it doesn't work in the dash >> > builtin echo and Ubuntu users are complaining. >> > >> > I can't

Re: [PATCH 3/3] mediatek: mt7623: use bash for generating bootable images

2020-09-08 Thread David Woodhouse
On Tue, 2020-09-08 at 10:31 +0200, Felix Fietkau wrote: > On 2020-09-08 10:26, David Woodhouse wrote: > > It turns out that 'echo -e' isn't portable; it doesn't work in the dash > > builtin echo and Ubuntu users are complaining. > > > > I can't even get octal (specified by POSIX) to work

Re: [PATCH 3/3] mediatek: mt7623: use bash for generating bootable images

2020-09-08 Thread Felix Fietkau
On 2020-09-08 10:26, David Woodhouse wrote: > It turns out that 'echo -e' isn't portable; it doesn't work in the dash > builtin echo and Ubuntu users are complaining. > > I can't even get octal (specified by POSIX) to work consistently because > those variants of 'echo' which *do* support -e