Re: [PATCH firewall4] fw4: add support for include.d dir

2022-08-11 Thread Jo-Philipp Wich
Hi, > [...] > > Sorry, but I don't agree with the following reasons. Let me briefly explain > why. > > All files under '/usr/share/firewall4/includes.d' are uci files. I can see > all relevant options. One problem with your suggested implementation is that you introduce a generic directory

Re: [PATCH firewall4] fw4: add support for include.d dir

2022-08-11 Thread Florian Eckert
Hi, Sorry for the late reply instead of introducing uci includes that configure nft includes, why not encode the chain/position etc. values directly into the path/filename and directly include the file if it exists at the expected location? I was just wondering why not use the new feature

Re: [PATCH firewall4] fw4: add support for include.d dir

2022-07-22 Thread Jo-Philipp Wich
Hi, instead of introducing uci includes that configure nft includes, why not encode the chain/position etc. values directly into the path/filename and directly include the file if it exists at the expected location? A potential pattern could be