Re: [OpenWrt-Tickets] [OpenWrt] #22349: OpenWRT wrong adjustment of fq_codel defaults

[OpenWrt]

#22349: OpenWRT wrong adjustment of fq_codel defaults
---+---
  Reporter:  brouer@…  |  Owner:  developers
  Type:  defect| Status:  new
  Priority:  highest   |  Milestone:  Bugs Paradise
 Component:  kernel|Version:  Trunk
Resolution:|   Keywords:
---+---

Comment (by RubenKelevra):

 Nice one, thanks for the report, please fix!

--
Ticket URL: 
OpenWrt 
Opensource Wireless Router Technology
___
openwrt-tickets mailing list
openwrt-tickets@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets

Re: [OpenWrt-Tickets] [OpenWrt] #22349: OpenWRT wrong adjustment of fq_codel defaults

[OpenWrt]

#22349: OpenWRT wrong adjustment of fq_codel defaults
---+---
  Reporter:  brouer@…  |  Owner:  developers
  Type:  defect| Status:  new
  Priority:  highest   |  Milestone:  Bugs Paradise
 Component:  kernel|Version:  Trunk
Resolution:|   Keywords:
---+---

Comment (by brouer@…):

 Replying to [comment:1 hauke]:
 > [...] wouldn't it be better to calculate q->flows_cnt based on
 sch->limit? This way this would not happen.

 It would not change/improve much in this place in the code (fq_codel_init)
 as the patch just change the default "init" settings.

 The problem of calculating q->flows_cnt based on sch->limit, is that we
 allow userspace to redefine these two settings.  If you want to, you can
 propose an upstream change that in function fq_codel_change(), calculate
 q->flows_cnt iif (if-and-only-if) it is not set from userspace/tc and that
 limit is configured from userspace.  That would bring value, but do it
 upstream first please (you can Cc me).

--
Ticket URL: 
OpenWrt 
Opensource Wireless Router Technology
___
openwrt-tickets mailing list
openwrt-tickets@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets

Re: [OpenWrt-Tickets] [OpenWrt] #22349: OpenWRT wrong adjustment of fq_codel defaults

[OpenWrt]

#22349: OpenWRT wrong adjustment of fq_codel defaults
---+---
  Reporter:  brouer@…  |  Owner:  developers
  Type:  defect| Status:  new
  Priority:  highest   |  Milestone:  Bugs Paradise
 Component:  kernel|Version:  Trunk
Resolution:|   Keywords:
---+---

Comment (by hauke):

 Thank you for the hint, I will look into this, but currently I do not have
 a device at hand. wouldn't it be better to calculate q->flows_cnt based on
 sch->limit? This way this would not happen.

 We are talking about r47811.

--
Ticket URL: 
OpenWrt 
Opensource Wireless Router Technology
___
openwrt-tickets mailing list
openwrt-tickets@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-tickets