Re: [PAX WEB] Url Pattern is auto-generated from Alias and how to register exact url pattern
Hi
According to the spec, I would agree. +1.
Regards
JB
Le sam. 15 févr. 2020 à 17:31, Grzegorz Grzybek a
écrit :
> Hello
>
> I've finally found the answer to your question:
>
> For example, Servlet, registered with /hello, also matches /hello/1, but I
>> want /hello/1 to return HTTP 404.
>>
>
> I've read the 102nd chapter of OSGi CMPN Http Service spec and I found:
>
> *102.4 Mapping HTTP Requests to Servlet and Resource Registrations*
>
> When an HTTP request comes in from a client, the Http Service checks to
> see if the requested URI matches any registered aliases. A URI matches only
> if the path part of the URI is *exactly the same* string. Matching is
> case sensitive.
>
> Which initially made me think that you're correct. But check this out:
>
> If it does match, a matching registration takes place, which is processed
> as follows:
> [...]
> 6. If there is no match, the *Http Service must attempt to match
> sub-strings of the requested URI to registered aliases*. The sub-strings
> of the requested URI are selected by removing the last "/" and everything
> to the right of the last "/".
>
> The Http Service must repeat this process until either a match is found or
> the sub-string is an empty string. [...]
>
> So, because Pax Web doesn't do what Tomcat/Jetty/Undertow do perfectly
> (VHost/Context/Servlet mapping), I think that actually an "/alias" should
> *always* be changed to "/alias/*" to comply with specification.
>
> If you want to do exact matching, just use the methods accepting URL
> parameters.
>
> +Achim Nierbeck , +Jean-Baptiste Onofré
> do you agree?
>
> regards
> Grzegorz Grzybek
>
> czw., 6 lut 2020 o 12:14 Miroslav Beranič
> napisał(a):
>
>> Hi all,
>>
>> I work with Pax Web on Karaf 4.3.0. I am trying to register Servlet with
>> exact url, but I see url pattern is auto-generated from alias.
>> I look at the current master branch - version 8.0.0-SNAPSHOT. Class:
>>
>> org.ops4j.pax.web.service.spi.model.ServletModel
>>
>>
>> constructor:
>> #ServletModel(org.ops4j.pax.web.service.spi.model.ContextModel,
>> javax.servlet.Servlet, java.lang.String, java.lang.String[],
>> java.lang.String, java.util.Dictionary,
>> java.lang.Integer, java.lang.Boolean, javax.servlet.MultipartConfigElement)
>>
>>
>> it calles method ( private static )
>> new String[]{aliasAsUrlPattern(alias)}
>>
>>
>> private static String aliasAsUrlPattern(final String alias) {
>> String urlPattern = alias;
>> if (urlPattern != null && !urlPattern.equals("/")
>> && !urlPattern.contains("*")) {
>> if (urlPattern.endsWith("/")) {
>> urlPattern = urlPattern + "*";
>> } else {
>> urlPattern = urlPattern + "/*";
>> }
>> }
>> return urlPattern;
>> }
>>
>>
>> so it always creates a url pattern, as I guess the name suggest, but why?
>> I would like to register exact URL, not the pattern. As it looks now, this
>> is not possible to do - as there is no argument to pass in to control the
>> flow.
>>
>> As it looks from the git history/log this is quite "old" code - from 2008
>> - 2013, so I guess this is not new and I guess everybody are ok with this?
>> So in this case, what is the usecase for it? As for my usecase - this is
>> not the required behavior.
>>
>> For example, Servlet, registered with /hello, also matches /hello/1, but
>> I want /hello/1 to return HTTP 404.
>>
>>
>> So for now, only really question is - is this expected behavior or is
>> there a room to change this? If so, how can one, with existing solution,
>> register Servlet with exact URL?
>>
>> Exact strack of calls looks like this:
>>
>> :53, ServletModel (org.ops4j.pax.web.service.spi.model)
>> registerServlet:224, HttpServiceStarted
>> (org.ops4j.pax.web.service.internal)
>> registerServlet:210, HttpServiceStarted
>> (org.ops4j.pax.web.service.internal)
>> registerServlet:69, HttpServiceProxy (org.ops4j.pax.web.service.internal)
>> register:97, ServletWebElement
>> (org.ops4j.pax.web.extender.whiteboard.internal.element)
>> registerWebElement:392, WebApplication
>> (org.ops4j.pax.web.extender.whiteboard.internal)
>> addWebElement:188, WebApplication
>> (org.ops4j.pax.web.extender.whiteboard.internal)
>> addingService:193, AbstractTracker
>> (org.ops4j.pax.web.extender.whiteboard.internal.tracker)
>> addingService:46, AbstractTracker
>> (org.ops4j.pax.web.extender.whiteboard.internal.tracker)
>> customizerAdding:941, ServiceTracker$Tracked (org.osgi.util.tracker)
>> customizerAdding:870, ServiceTracker$Tracked (org.osgi.util.tracker)
>> trackAdding:256, AbstractTracked (org.osgi.util.tracker)
>> track:229, AbstractTracked (org.osgi.util.tracker)
>> serviceChanged:901, ServiceTracker$Tracked (org.osgi.util.tracker)
>> invokeServiceListenerCallback:990, EventDispatcher
>> (org.apache.felix.framework)
>> fireEventImmediately:838, EventDispatcher (org.apache.felix.framework)
>> fireServiceEvent:545, EventDispatcher
Re: [PAX WEB] Url Pattern is auto-generated from Alias and how to register exact url pattern
Hello
I've finally found the answer to your question:
For example, Servlet, registered with /hello, also matches /hello/1, but I
> want /hello/1 to return HTTP 404.
>
I've read the 102nd chapter of OSGi CMPN Http Service spec and I found:
*102.4 Mapping HTTP Requests to Servlet and Resource Registrations*
When an HTTP request comes in from a client, the Http Service checks to see
if the requested URI matches any registered aliases. A URI matches only if
the path part of the URI is *exactly the same* string. Matching is case
sensitive.
Which initially made me think that you're correct. But check this out:
If it does match, a matching registration takes place, which is processed
as follows:
[...]
6. If there is no match, the *Http Service must attempt to match
sub-strings of the requested URI to registered aliases*. The sub-strings of
the requested URI are selected by removing the last "/" and everything to
the right of the last "/".
The Http Service must repeat this process until either a match is found or
the sub-string is an empty string. [...]
So, because Pax Web doesn't do what Tomcat/Jetty/Undertow do perfectly
(VHost/Context/Servlet mapping), I think that actually an "/alias" should
*always* be changed to "/alias/*" to comply with specification.
If you want to do exact matching, just use the methods accepting URL
parameters.
+Achim Nierbeck , +Jean-Baptiste Onofré
do you agree?
regards
Grzegorz Grzybek
czw., 6 lut 2020 o 12:14 Miroslav Beranič
napisał(a):
> Hi all,
>
> I work with Pax Web on Karaf 4.3.0. I am trying to register Servlet with
> exact url, but I see url pattern is auto-generated from alias.
> I look at the current master branch - version 8.0.0-SNAPSHOT. Class:
>
> org.ops4j.pax.web.service.spi.model.ServletModel
>
>
> constructor:
> #ServletModel(org.ops4j.pax.web.service.spi.model.ContextModel,
> javax.servlet.Servlet, java.lang.String, java.lang.String[],
> java.lang.String, java.util.Dictionary,
> java.lang.Integer, java.lang.Boolean, javax.servlet.MultipartConfigElement)
>
>
> it calles method ( private static )
> new String[]{aliasAsUrlPattern(alias)}
>
>
> private static String aliasAsUrlPattern(final String alias) {
> String urlPattern = alias;
> if (urlPattern != null && !urlPattern.equals("/")
> && !urlPattern.contains("*")) {
> if (urlPattern.endsWith("/")) {
> urlPattern = urlPattern + "*";
> } else {
> urlPattern = urlPattern + "/*";
> }
> }
> return urlPattern;
> }
>
>
> so it always creates a url pattern, as I guess the name suggest, but why?
> I would like to register exact URL, not the pattern. As it looks now, this
> is not possible to do - as there is no argument to pass in to control the
> flow.
>
> As it looks from the git history/log this is quite "old" code - from 2008
> - 2013, so I guess this is not new and I guess everybody are ok with this?
> So in this case, what is the usecase for it? As for my usecase - this is
> not the required behavior.
>
> For example, Servlet, registered with /hello, also matches /hello/1, but I
> want /hello/1 to return HTTP 404.
>
>
> So for now, only really question is - is this expected behavior or is
> there a room to change this? If so, how can one, with existing solution,
> register Servlet with exact URL?
>
> Exact strack of calls looks like this:
>
> :53, ServletModel (org.ops4j.pax.web.service.spi.model)
> registerServlet:224, HttpServiceStarted
> (org.ops4j.pax.web.service.internal)
> registerServlet:210, HttpServiceStarted
> (org.ops4j.pax.web.service.internal)
> registerServlet:69, HttpServiceProxy (org.ops4j.pax.web.service.internal)
> register:97, ServletWebElement
> (org.ops4j.pax.web.extender.whiteboard.internal.element)
> registerWebElement:392, WebApplication
> (org.ops4j.pax.web.extender.whiteboard.internal)
> addWebElement:188, WebApplication
> (org.ops4j.pax.web.extender.whiteboard.internal)
> addingService:193, AbstractTracker
> (org.ops4j.pax.web.extender.whiteboard.internal.tracker)
> addingService:46, AbstractTracker
> (org.ops4j.pax.web.extender.whiteboard.internal.tracker)
> customizerAdding:941, ServiceTracker$Tracked (org.osgi.util.tracker)
> customizerAdding:870, ServiceTracker$Tracked (org.osgi.util.tracker)
> trackAdding:256, AbstractTracked (org.osgi.util.tracker)
> track:229, AbstractTracked (org.osgi.util.tracker)
> serviceChanged:901, ServiceTracker$Tracked (org.osgi.util.tracker)
> invokeServiceListenerCallback:990, EventDispatcher
> (org.apache.felix.framework)
> fireEventImmediately:838, EventDispatcher (org.apache.felix.framework)
> fireServiceEvent:545, EventDispatcher (org.apache.felix.framework)
> fireServiceEvent:4595, Felix (org.apache.felix.framework)
> registerService:3587, Felix (org.apache.felix.framework)
> registerService:348, BundleContextImpl (org.apache.felix.framework)
> registerService:355, BundleContextImpl (org.apache.felix.framework)
>
>
