Re: [OPSAWG] AD review of draft-ietf-opsawg-vpn-common-08

2021-07-13 Thread Rob Wilton (rwilton)
Hi Med, [Just to also close this thread/review.] I think that you are good to go. Thanks for accommodating my comments. Regards, Rob > -Original Message- > From: mohamed.boucad...@orange.com > > Sent: 13 July 2021 16:17 > To: Rob Wilton (rwilton) ; draft-ietf-opsawg-vpn- >

Re: [OPSAWG] AD review of draft-ietf-opsawg-l3sm-l3nm-09

2021-07-13 Thread Rob Wilton (rwilton)
Hi Med, I think that you are good to go. Thanks for accommodating my comments. Regards, Rob > -Original Message- > From: mohamed.boucad...@orange.com > > Sent: 13 July 2021 17:04 > To: Rob Wilton (rwilton) ; draft-ietf-opsawg-l3sm- > l3nm@ietf.org > Cc: opsawg@ietf.org > Subject:

Re: [OPSAWG] AD review of draft-ietf-opsawg-l3sm-l3nm-09

2021-07-13 Thread mohamed.boucadair
Re-, Please see inline. Cheeers, Med > -Message d'origine- > De : Rob Wilton (rwilton) [mailto:rwil...@cisco.com] > Envoyé : mardi 13 juillet 2021 17:55 > À : BOUCADAIR Mohamed INNOV/NET ; > draft-ietf-opsawg-l3sm-l3nm@ietf.org > Cc : opsawg@ietf.org > Objet : RE: AD review of

Re: [OPSAWG] AD review of draft-ietf-opsawg-l3sm-l3nm-09

2021-07-13 Thread Rob Wilton (rwilton)
Hi Med, Looking at the diff, I think that you have a typo for "oubound". But just to check, the "inbound-rate-limit" and "inbound-bandwidth" both act in the same direction, right? That was the consistency that I was striving for. Normally, when I think of a QoS policy as acting on say a PE

Re: [OPSAWG] A typo in draft-ietf-opsawg-l2nm-03.txt

2021-07-13 Thread mohamed.boucadair
Hi Moti, Thank you for catching this. Fixed at: https://github.com/IETF-OPSAWG-WG/lxnm/commit/ead6781ad73229cae267f6d805d9dcc19b8824a0 Cheers, Med De : OPSAWG [mailto:opsawg-boun...@ietf.org] De la part de Moti Morgenstern Envoyé : mardi 13 juillet 2021 17:11 À :

Re: [OPSAWG] AD review of draft-ietf-opsawg-vpn-common-08

2021-07-13 Thread mohamed.boucadair
Re-, I updated the file to take into account your feedback: * Module: https://github.com/IETF-OPSAWG-WG/lxnm/commit/fcc9f6c1e79d5074469fe454d95770fe9f1becdb (in addition to the changes already reported as part of the L3NM review). * I-D: https://tinyurl.com/vpn-common-latest Unless you have

[OPSAWG] A typo in draft-ietf-opsawg-l2nm-03.txt

2021-07-13 Thread Moti Morgenstern
Hi, I noticed that the enumerated values supposed to be under "identity evpn-service-type" actually use "base evpn-redundancy-mode". Regards, Moti Morgenstern Packet Optical Networks - Systems Architecture 30 Hasivim Street | Petah Tikva, Israel office: +972.3.9266258 | mobile: +972.50.705.6258

Re: [OPSAWG] AD review of draft-ietf-opsawg-l3sm-l3nm-09

2021-07-13 Thread mohamed.boucadair
Ho Rob, I updated the files to take into account your feedback: * Fix input/output in the common I-D (diff): https://github.com/IETF-OPSAWG-WG/lxnm/commit/ff456448a9398311457eb51c1d78adc8210fd8f8 * L3NM (diff):

Re: [OPSAWG] AD review of draft-ietf-opsawg-vpn-common-08

2021-07-13 Thread Rob Wilton (rwilton)
Hi Med, Please see inline, just a couple of points to resolve ... > -Original Message- > From: mohamed.boucad...@orange.com > > Sent: 12 July 2021 18:35 > To: Rob Wilton (rwilton) ; draft-ietf-opsawg-vpn- > common@ietf.org > Cc: opsawg@ietf.org > Subject: RE: AD review of

Re: [OPSAWG] AD review of draft-ietf-opsawg-l3sm-l3nm-09

2021-07-13 Thread Rob Wilton (rwilton)
Hi Med, Thanks for the quick reply. A few comments inline ... > -Original Message- > From: mohamed.boucad...@orange.com > > Sent: 12 July 2021 18:57 > To: Rob Wilton (rwilton) ; draft-ietf-opsawg-l3sm- > l3nm@ietf.org > Cc: opsawg@ietf.org > Subject: RE: AD review of