Re: [osg-users] Fixes for errors in osg::Light, osg::Hint and osg::ClipPlane

2007-12-08 Thread Robert Osfield
Hi Richard, I have finally got on to reviewing your changes. First your analysis of the problem is correct - both the osg::State's cloning of the affected StateAttribute types was broken, and the invalidation of the StateSet positioning of these attributes when there assingnment number/target

[osg-users] Fixes for errors in osg::Light, osg::Hint and osg::ClipPlane

2007-10-23 Thread Schmidt, Richard, SDGE1
Hi, if you have problems with multiple lightsources in your scenegraph not glEnableling/glDisableing correctly this may be a solution for you. First lets recap the error: osg::Light* l1 = new osg::Light(); osg::Light* l2 = new osg::Light(); osg::StateSet* stateSet = new

Re: [osg-users] Fixes for errors in osg::Light, osg::Hint and osg::ClipPlane

2007-10-23 Thread Robert Osfield
Hi Richard, Could you send future submissions to osg-submissions as ones to osg-users can easily be lost. As for caching in StateSet this does make the assumption that the light number/clip plane number is invariant once assigned. This is done for efficiency purposes and is a trade off in the

Re: [osg-users] Fixes for errors in osg::Light, osg::Hint and osg::ClipPlane

2007-10-23 Thread Schmidt, Richard, SDGE1
Hi Robert, a proper solution could be by setting member variables(lightnum, clipplane, etc.) only through the constructor. Richard Hi Richard, Could you send future submissions to osg-submissions as ones to osg-users can easily be lost. As for caching in StateSet this does make the

Re: [osg-users] Fixes for errors in osg::Light, osg::Hint and osg::ClipPlane

2007-10-23 Thread Schmidt, Richard, SDGE1
Dooh, I submitted an outdated version. The clipplane ::cloneType must clone the MemberType only and not the clipplane as well. Richard Hi Richard, Could you send future submissions to osg-submissions as ones to osg-users can easily be lost. As for caching in StateSet this does make the