Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-10-10 Thread Robert Osfield
Hi Riccardo, On 10 October 2016 at 12:17, Riccardo Corsi wrote: > both double call and crash fixed on my side as well. Good to hear things are now resolved. > Now that one can safely implement a callback by deriving directly from > osg::Callback, I think most users should go that way for their

Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-10-10 Thread Riccardo Corsi
Hi Robert, both double call and crash fixed on my side as well. Now that one can safely implement a callback by deriving directly from osg::Callback, I think most users should go that way for their new code. If that's the case, the not-very-intuitive path of implementing operator() rather than ru

Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-10-06 Thread Robert Osfield
Hi Riccardo, I have found the cause of the double call, fixed it and have now checked in this fix and the other fixes to event callback handling. Changes checked into OSG git master. Could you test them out on your application to make sure that things are now behaving themselves. Thanks, Robert

Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-10-06 Thread Robert Osfield
HI Riccardo, I have been back tackling the outstanding OS work today and have a chance to build and test your callback test. I can recreate the issues with the crash and double calling. So far I've fixed a bug in the osgGA/EventVisitor that was causing the crash and have replaced a couple of dyna

Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-10-05 Thread Riccardo Corsi
Hi Robert, ​​ I know there are many things already going on toward OSG 3.6.0, but if you get a change to take a look to the sample I've sent, it might be worth considering possible fixes before the new release is out. Thank you, Riccardo On Mon, Aug 29, 2016 at 6:45 PM, Robert Osfield wrote: >

Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-10-05 Thread Robert Osfield
Hi Riccardo, On 5 October 2016 at 13:51, Riccardo Corsi wrote: > I know there are many things already going on toward OSG 3.6.0, > but if you get a change to take a look to the sample I've sent, it might be > worth considering possible fixes before the new release is out. I've been busy with cli

Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-08-29 Thread Robert Osfield
Thanks Riccardo. I'm currently submerged in refactoring osgParticle, once this is completed I'll have a look at the modified osgcallback.cpp. On 29 August 2016 at 16:20, Riccardo Corsi wrote: > Hi Robert, > > please find attached a simple example that shows the issues I was trying to > explain:

Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-08-29 Thread Riccardo Corsi
Hi Robert, please find attached a simple example that shows the issues I was trying to explain: - launch with no args to see the initial issue - launch with "--crash" to get the crash i ran into when implementing the callback deriving from osg::Callback - launch with "--fix" to see the way I fixed

Re: [osg-users] GUIEventHandler called twice - possible bug(s)

2016-08-29 Thread Robert Osfield
Hi Ricky, The changes to Drawable and the knock on effect to the callbacks is an awkward one - it would be easy if it we could just discard backwards compatibility, so it's a far from ideal code, but alas you can't rewrite history once it's happened. >From your description I don't have a clear id

[osg-users] GUIEventHandler called twice - possible bug(s)

2016-08-29 Thread Riccardo Corsi
Hi all, I report what I believe could be considered a bug, probably introduced after the promotion of the Drawable class to a node, together with the new callback system. I have a GUIEventHandler derived class installed on a Drawable. After some digging I've realized that it's called twice for ev