Re: [osg-users] osg::LineSegment intersect with Box and Sphere inconsistency

Thanks, Looks good to me. Wojtek 2015-04-27 21:22 GMT+02:00 Robert Osfield robert.osfi...@gmail.com: Hi Wojtek, I have decided I'd rather change the method name and break the build rather than silently change the behaviour of method in a way that could break end user code. What I have gone

Re: [osg-users] osg::LineSegment intersect with Box and Sphere inconsistency

I believe both can be correct but it looks like in Box case r1 is ratio of segment length measured from start and r2 measured backwards from the segment end. For Sphere both r1 and r2 are measured from start. So here is the inconsistency... Cheers, Wojtek 2015-04-27 12:38 GMT+02:00 Robert Osfield

Re: [osg-users] osg::LineSegment intersect with Box and Sphere inconsistency

Hi Wojtek, Thanks for the test code. I've built it on my system with OSG svn/trunk and get the same values reported. The values don't look appropriate in either case, I don't know the cause of the issue yet so am doing a code review now. Robert. On 25 April 2015 at 13:11, Wojciech Lewandowski

Re: [osg-users] osg::LineSegment intersect with Box and Sphere inconsistency

Hi Robert, I am little concerned that some end user code will be using these intersects methods and working around their inconsistency, so if we fix them then we could end up breaking end user code. I am one of those users now ;-). However, I adopt easily. Others may not notice the change,

Re: [osg-users] osg::LineSegment intersect with Box and Sphere inconsistency

Hi Wojtek, On 27 April 2015 at 12:15, Wojciech Lewandowski w.p.lewandow...@gmail.com wrote: I believe both can be correct but it looks like in Box case r1 is ratio of segment length measured from start and r2 measured backwards from the segment end. For Sphere both r1 and r2 are measured from

Re: [osg-users] osg::LineSegment intersect with Box and Sphere inconsistency

Hi Wojtek, On 27 April 2015 at 13:16, Wojciech Lewandowski w.p.lewandow...@gmail.com wrote: I am one of those users now ;-). However, I adopt easily. Others may not notice the change, though. Perhaps better solution would be to leave the functionality as is and clearly rename and/or comment

Re: [osg-users] osg::LineSegment intersect with Box and Sphere inconsistency

Hi Wojtek, I have decided I'd rather change the method name and break the build rather than silently change the behaviour of method in a way that could break end user code. What I have gone for is: --- include/osg/LineSegment (revision 14855) +++ include/osg/LineSegment (working copy)

[osg-users] osg::LineSegment intersect with Box and Sphere inconsistency

Hi, Robert, I have just stumbled on small issue in my intersection code which turned out to be related to different interpretation of r2 param returned by LineSegment::intersect( BoundingBox, r1, r2 ) and LineSegment::intersect( BoundingSphere, r1, r2 ). Example Code: osg::BoundingBox box(