Re: [osg-users] osgDB XmlParser and localization

2018-09-04 Thread Trajce Nikolov NICK
Thanks a bunch Robert! I will check it first thing tomorrow morning On Tue, Sep 4, 2018 at 4:40 PM Robert Osfield wrote: > On Fri, 31 Aug 2018 at 08:06, Trajce Nikolov NICK > wrote: > > can you fix this too when you get back to OSG dev please? > > This morning I have checked in UTF8 handling

Re: [osg-users] osgDB XmlParser and localization

2018-09-04 Thread Robert Osfield
On Fri, 31 Aug 2018 at 08:06, Trajce Nikolov NICK wrote: > can you fix this too when you get back to OSG dev please? This morning I have checked in UTF8 handling in XmlNode/Input to master and the 3.6 branch.

Re: [osg-users] osgDB XmlParser and localization

2018-08-31 Thread Trajce Nikolov NICK
Hi Robert, can you fix this too when you get back to OSG dev please? Thank you a bunch Nick On Mon, Jul 9, 2018 at 1:58 PM Trajce Nikolov NICK < trajce.nikolov.n...@gmail.com> wrote: > Hi again Robert, > > fast hint: The nodes to be parsed are root->osm->node->tag and their > properties

Re: [osg-users] osgDB XmlParser and localization

2018-07-09 Thread Trajce Nikolov NICK
Hi again Robert, fast hint: The nodes to be parsed are root->osm->node->tag and their properties contains these non asci codes. But probably fastest is to write recursive parser Thanks again On Mon, Jul 9, 2018 at 1:54 PM Trajce Nikolov NICK < trajce.nikolov.n...@gmail.com> wrote: > Thanks so

Re: [osg-users] osgDB XmlParser and localization

2018-07-09 Thread Robert Osfield
Hi Nick, On Mon, 9 Jul 2018 at 12:26, Trajce Nikolov NICK wrote: > > are changes for changes sake rather than likely to make any > functional difference > > I knew you will have comments ;-). It works just fine with these changes but > yes, you are right - quick and somewhat dirty. So can

Re: [osg-users] osgDB XmlParser and localization

2018-07-09 Thread Trajce Nikolov NICK
hi Robert, > are changes for changes sake rather than likely to make any functional difference I knew you will have comments ;-). It works just fine with these changes but yes, you are right - quick and somewhat dirty. So can you look at it or you want to do a ping-pong code review with my

Re: [osg-users] osgDB XmlParser and localization

2018-07-09 Thread Robert Osfield
Hi Nick, I had a quick look at your changes and it seems to be like most of them are changes for changes sake rather than likely to make any functional difference. For non ascii char support I think what you'd actually want to do is change the XmllNode::Input::string _buffer member var to a

[osg-users] osgDB XmlParser and localization

2018-07-09 Thread Trajce Nikolov NICK
Hi Robert, I am working with some localized XML files (with chars out of 0-255 range) and at present the XML Node parsing is not suitable to manage it. And I think the support for is important - at my case it is OpenStreetMap with street names containing these chars. Attached is the modified