Re: [osg-users] osgjs fix for 64 builds with some compilers

2016-02-18 Thread Robert Osfield
On 18 February 2016 at 10:36, Trajce Nikolov NICK < trajce.nikolov.n...@gmail.com> wrote: > Hi Robert, > > since this is one line and related to output info maybe this will be > enough to work on both platforms > > ss << (int64_t)image << ".inline_conv_generated.png"; // write the > pointer

Re: [osg-users] osgjs fix for 64 builds with some compilers

2016-02-18 Thread Trajce Nikolov NICK
Hi Robert, since this is one line and related to output info maybe this will be enough to work on both platforms ss << (int64_t)image << ".inline_conv_generated.png"; // write the pointer location On Thu, Feb 18, 2016 at 11:21 AM, Trajce Nikolov NICK < trajce.nikolov.n...@gmail.com> wrote: >

Re: [osg-users] osgjs fix for 64 builds with some compilers

2016-02-18 Thread Trajce Nikolov NICK
Hi Robert, I did fast fix hoping you will find a time to comment on this. I agree with you .. Let me try to do it more properly :) Thanks for finding a time to look at the issue! Cheers, Nick On Thu, Feb 18, 2016 at 10:45 AM, Robert Osfield wrote: > Hi Nick, > > I

Re: [osg-users] osgjs fix for 64 builds with some compilers

2016-02-18 Thread Robert Osfield
Hi Nick, I have just reviewed your change and don't feel it's the appropriate way to tackle this type of issue. If long int isn't being interpreted as 64bit int then it would be appropriate to use a typedef rather than #ifdef blocks. The include/osg/Types file contains int64_t, could you just