Hi Ulrich, I also spotted the missing '&'. You're absolutely right. Well, if you already fixed them you can submit ^^... or else I'll do (but sincerely I don't know when...)
Cheers, Sukender ----- Mail original ----- De: "Ulrich Hertlein" <u.hertl...@sandbox.de> À: "OpenSceneGraph Submissions" <osg-submissi...@lists.openscenegraph.org> Cc: "Sukender" <suky0...@free.fr> Envoyé: Jeudi 14 Juin 2012 15:52:30 Objet: Re: [osg-submissions] ReaderWriter X reworked Hi Sukender, I had a quick look at the patch and checked that it still works with the various .x files I have flying around. One thing I did notice in the code is that you're passing 'const std::string' in some places. For the sake of efficiency these chould be replaced with 'const std::string&' to avoid making a copy every time. Same for passing 'osg::Vec', these should always be passed as const-ref unless they are modified or returned. Maybe this is something you could fix and resubmit? Apart from that I'd say it's good to go. Just my $0.02 Cheers, /ulrich On 31/05/12 11:14 , Sukender wrote: > And now the patch. It is about .X: > - Brand new writer for .x format. Yes, the format is deprecated but some > still use it. Current implementation has limitations (only supports one > texture, for instance) but works. > - Reader > - Added checks, warnings, and crash guards > - Now handles "FrameTransformMatrix" element (kind of osg::MatrixTransform) > - Fixed CW / CCW for faces > - Better handling of materials (handles meshes with no materials, fixed > reading of transparent textures...) > - Handling triangles and polygons differently > - Reader can now create indexed geometries > - And more... > The reader clearly doesn't read 100% of .x files, but handling is way better > now. > > Sorry for the huge amount of changes, but these are the result of many > commits from a > colleague, and giving you these commits separately won't help you merge the > code as the "1 > commit = 1 feature" rule was not followed at all... > > Cheers, > > Sukender _______________________________________________ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
