Re: [osg-users] [vpb] inlineImageFile MIP_MAPPING_HARDWARE suggestion

2010-08-16 Thread Robert Osfield 
HI Alex,

On Wed, Aug 11, 2010 at 2:28 PM, Alexander Irion alexander.ir...@xse.de wrote:
 Hi,

 shouldn't the line

 bool inlineImageFile = _dataSet-getDestinationTileExtension()==.ive;

 be expanded to:

 bool inlineImageFile = _dataSet-getDestinationTileExtension()==.ive || 
 _dataSet-getDestinationTileExtension()==.osgb;

 inorder to get mipmaps as imagery in osgb files?

Reviewing the code in VPB this change does indeed look appropriate.
As Brad mentions .osgb support is very new to the OSG and VPB so
hasn't yet been fully tested and refined so items like this we'll need
to be on the look out for.

I've made the above change to VPB and checked it in to svn/trunk.


 I would also only set hardware mipmap generation in the output file, when 
 MIP_MAPPING_HARDWARE is set:

 texture-setUseHardwareMipMapGeneration(getImageOptions(layerNum)-getMipMappingMode()
  == DataSet::MIP_MAPPING_HARDWARE);

 Is this correct?

I can't work out the problem you are thinking about there.  The code
looks fine to me right now, and would expect the code to work for .ive
and .osgb in the same way.  Is there a specific problem you are
thinking about?

Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] [vpb] inlineImageFile MIP_MAPPING_HARDWARE suggestion

2010-08-11 Thread Christiansen, Brad 
Hi,

Looks correct to me. Support for .osgb has only recently been added to VPB and 
it looks like the case you mention was missed. I would suggest you submit a 
patch to osg-submissions.

Cheers,

Brad

-Original Message-
From: osg-users-boun...@lists.openscenegraph.org 
[mailto:osg-users-boun...@lists.openscenegraph.org] On Behalf Of Alexander Irion
Sent: Wednesday, 11 August 2010 9:28 PM
To: osg-users@lists.openscenegraph.org
Subject: [osg-users] [vpb] inlineImageFile  MIP_MAPPING_HARDWARE suggestion

Hi,

shouldn't the line

bool inlineImageFile = _dataSet-getDestinationTileExtension()==.ive; 

be expanded to:

bool inlineImageFile = _dataSet-getDestinationTileExtension()==.ive || 
_dataSet-getDestinationTileExtension()==.osgb;

inorder to get mipmaps as imagery in osgb files?

I would also only set hardware mipmap generation in the output file, when 
MIP_MAPPING_HARDWARE is set:

texture-setUseHardwareMipMapGeneration(getImageOptions(layerNum)-getMipMappingMode()
 == DataSet::MIP_MAPPING_HARDWARE);

Is this correct?

--Alex






Thank you!

Cheers,
Alexander

--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=30690#30690





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org



DISCLAIMER:---
This e-mail transmission and any documents, files and previous e-mail messages
attached to it are private and confidential. They may contain proprietary or 
copyright
material or information that is subject to legal professional privilege. They 
are for
the use of the intended recipient only.  Any unauthorised viewing, use, 
disclosure,
copying, alteration, storage or distribution of, or reliance on, this message is
strictly prohibited. No part may be reproduced, adapted or transmitted without 
the
written permission of the owner. If you have received this transmission in 
error, or
are not an authorised recipient, please immediately notify the sender by return 
email,
delete this message and all copies from your e-mail system, and destroy any 
printed
copies. Receipt by anyone other than the intended recipient should not be 
deemed a
waiver of any privilege or protection. Thales Australia does not warrant or 
represent
that this e-mail or any documents, files and previous e-mail messages attached 
are
error or virus free.
--

___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org