[osg-users] FindFBX.cmake broken on WIn32/Cmake 2.6?
Hi, my automated build system fails with the new FindFBX.cmake (plain vanilla osg from trunk). CMake complains: 8 snip 8 CMake Error: Error in cmake code at C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake:25: Parse error. Function missing ending ). Instead found left paren with text (. CMake Error at CMakeLists.txt:454 (FIND_PACKAGE): find_package Error reading CMake code from C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake. 8 snip 8 What cmake-version is required on win32? I am using 2.6 cheers, Stephan ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] FindFBX.cmake broken on WIn32/Cmake 2.6?
Hi Stephan, Could the use of a nested () section with the enclosing ELSEIF() be the problem? Perhaps this test coulde be separated out into several separate lines that decide whether 64bit is required or not. Could you experiment with getting this to work, it'd be good to keep the OSG working with older versions of cmake. Thanks, Robert. On Wed, May 4, 2011 at 9:01 AM, Stephan Maximilian Huber ratzf...@digitalmind.de wrote: Hi, my automated build system fails with the new FindFBX.cmake (plain vanilla osg from trunk). CMake complains: 8 snip 8 CMake Error: Error in cmake code at C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake:25: Parse error. Function missing ending ). Instead found left paren with text (. CMake Error at CMakeLists.txt:454 (FIND_PACKAGE): find_package Error reading CMake code from C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake. 8 snip 8 What cmake-version is required on win32? I am using 2.6 cheers, Stephan ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] FindFBX.cmake broken on WIn32/Cmake 2.6?
Hi Robert, As I don't use the FBX-plugin I can't test my modifications, they satisfy cmake 2.6 though. See attached file. cheers, Stephan Am 04.05.11 10:08, schrieb Robert Osfield: Hi Stephan, Could the use of a nested () section with the enclosing ELSEIF() be the problem? Perhaps this test coulde be separated out into several separate lines that decide whether 64bit is required or not. Could you experiment with getting this to work, it'd be good to keep the OSG working with older versions of cmake. Thanks, Robert. On Wed, May 4, 2011 at 9:01 AM, Stephan Maximilian Huber ratzf...@digitalmind.de wrote: Hi, my automated build system fails with the new FindFBX.cmake (plain vanilla osg from trunk). CMake complains: 8 snip 8 CMake Error: Error in cmake code at C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake:25: Parse error. Function missing ending ). Instead found left paren with text (. CMake Error at CMakeLists.txt:454 (FIND_PACKAGE): find_package Error reading CMake code from C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake. 8 snip 8 What cmake-version is required on win32? I am using 2.6 cheers, Stephan ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org # Locate FBX # This module defines: # FBX_INCLUDE_DIR, where to find the headers # # FBX_LIBRARY, FBX_LIBRARY_DEBUG # FBX_FOUND # # $FBX_DIR is an environment variable that would # correspond to the ./configure --prefix=$FBX_DIR IF(APPLE) SET(FBX_LIBDIR gcc4/ub) ELSEIF(CMAKE_COMPILER_IS_GNUCXX) SET(FBX_LIBDIR gcc4) ELSEIF(MSVC80) SET(FBX_LIBDIR vs2005) ELSEIF(MSVC90) SET(FBX_LIBDIR vs2008) ELSEIF(MSVC100 OR MSVC_VER1600) SET(FBX_LIBDIR vs2010) ENDIF() IF(APPLE) # do nothing ELSEIF() # default SET(FBX_LIBDIR ${FBX_LIBDIR}/x86) # check for 64bit IF(CMAKE_CL_64) SET(FBX_LIBDIR ${FBX_LIBDIR}/x64) ELSEIF(CMAKE_COMPILER_IS_GNUCXX AND CMAKE_SIZEOF_VOID_P EQUAL 8) SET(FBX_LIBDIR ${FBX_LIBDIR}/x64) ENDIF() ENDIF() IF(APPLE) SET(FBX_LIBNAME fbxsdk-2012.1-static) ELSEIF(CMAKE_COMPILER_IS_GNUCXX) SET(FBX_LIBNAME fbxsdk-2012.1-static) ELSE() SET(FBX_LIBNAME fbxsdk-2012.1-md) ENDIF() SET(FBX_LIBNAME_DEBUG ${FBX_LIBNAME}d) SET( FBX_SEARCH_PATHS $ENV{FBX_DIR} $ENV{ProgramW6432}/Autodesk/FBX/FbxSdk/2012.1 $ENV{PROGRAMFILES}/Autodesk/FBX/FbxSdk/2012.1 /Applications/Autodesk/FBXSDK20121 ) # search for headers debug/release libraries FIND_PATH(FBX_INCLUDE_DIR fbxsdk.h PATHS ${FBX_SEARCH_PATHS} PATH_SUFFIXES include) FIND_LIBRARY( FBX_LIBRARY ${FBX_LIBNAME} PATHS ${FBX_SEARCH_PATHS} PATH_SUFFIXES lib/${FBX_LIBDIR}) FIND_LIBRARY( FBX_LIBRARY_DEBUG ${FBX_LIBNAME_DEBUG} PATHS ${FBX_SEARCH_PATHS} PATH_SUFFIXES lib/${FBX_LIBDIR}) IF(FBX_LIBRARY AND FBX_LIBRARY_DEBUG AND FBX_INCLUDE_DIR) SET(FBX_FOUND YES) ELSE() SET(FBX_FOUND NO) ENDIF() ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] FindFBX.cmake broken on WIn32/Cmake 2.6?
If I read that file correctly, for x64 builds it would execute both SET(FBX_LIBDIR ${FBX_LIBDIR}/x86) as well as SET(FBX_LIBDIR ${FBX_LIBDIR}/x64) which would be incorrect. The attached file gives the correct behaviour without the nested parentheses. -Michael On 4 May 2011 09:29, Stephan Maximilian Huber ratzf...@digitalmind.dewrote: Hi Robert, As I don't use the FBX-plugin I can't test my modifications, they satisfy cmake 2.6 though. See attached file. cheers, Stephan Am 04.05.11 10:08, schrieb Robert Osfield: Hi Stephan, Could the use of a nested () section with the enclosing ELSEIF() be the problem? Perhaps this test coulde be separated out into several separate lines that decide whether 64bit is required or not. Could you experiment with getting this to work, it'd be good to keep the OSG working with older versions of cmake. Thanks, Robert. On Wed, May 4, 2011 at 9:01 AM, Stephan Maximilian Huber ratzf...@digitalmind.de wrote: Hi, my automated build system fails with the new FindFBX.cmake (plain vanilla osg from trunk). CMake complains: 8 snip 8 CMake Error: Error in cmake code at C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake:25: Parse error. Function missing ending ). Instead found left paren with text (. CMake Error at CMakeLists.txt:454 (FIND_PACKAGE): find_package Error reading CMake code from C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake. 8 snip 8 What cmake-version is required on win32? I am using 2.6 cheers, Stephan ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org FindFBX.cmake Description: Binary data ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] FindFBX.cmake broken on WIn32/Cmake 2.6?
Hi Michael + Robert, Am 04.05.11 11:00, schrieb Michael Platings: The attached file gives the correct behaviour without the nested parentheses. this version works fine on my end. thanks again. Stephan ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] FindFBX.cmake broken on WIn32/Cmake 2.6?
Hi Michael, Your suggestions looks good, now merged and submittted to svn/trunk. Cheers, Robert. On Wed, May 4, 2011 at 10:00 AM, Michael Platings mplati...@gmail.com wrote: If I read that file correctly, for x64 builds it would execute both SET(FBX_LIBDIR ${FBX_LIBDIR}/x86) as well as SET(FBX_LIBDIR ${FBX_LIBDIR}/x64) which would be incorrect. The attached file gives the correct behaviour without the nested parentheses. -Michael On 4 May 2011 09:29, Stephan Maximilian Huber ratzf...@digitalmind.de wrote: Hi Robert, As I don't use the FBX-plugin I can't test my modifications, they satisfy cmake 2.6 though. See attached file. cheers, Stephan Am 04.05.11 10:08, schrieb Robert Osfield: Hi Stephan, Could the use of a nested () section with the enclosing ELSEIF() be the problem? Perhaps this test coulde be separated out into several separate lines that decide whether 64bit is required or not. Could you experiment with getting this to work, it'd be good to keep the OSG working with older versions of cmake. Thanks, Robert. On Wed, May 4, 2011 at 9:01 AM, Stephan Maximilian Huber ratzf...@digitalmind.de wrote: Hi, my automated build system fails with the new FindFBX.cmake (plain vanilla osg from trunk). CMake complains: 8 snip 8 CMake Error: Error in cmake code at C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake:25: Parse error. Function missing ending ). Instead found left paren with text (. CMake Error at CMakeLists.txt:454 (FIND_PACKAGE): find_package Error reading CMake code from C:/Program Files/Jenkins/jobs/osg/workspace/osg/CMakeModules/FindFBX.cmake. 8 snip 8 What cmake-version is required on win32? I am using 2.6 cheers, Stephan ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org