Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-22 Thread Robert Osfield
On Tue, 21 Aug 2018 at 20:43, Paul Levy wrote: > Seems to be working now. Yesterday I submitted a PR to change GL_RGBA16F and > GL_RGBA32F to GL_RGBA16F_ARB and GL_RGBA32F_ARB, but you only changed > GL_RGBA32F. Both are undefined on Windows so I re-submitted a PR to get the > Windows build

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-21 Thread Paul Levy
Robert, Seems to be working now. Yesterday I submitted a PR to change GL_RGBA16F and GL_RGBA32F to GL_RGBA16F_ARB and GL_RGBA32F_ARB, but you only changed GL_RGBA32F. Both are undefined on Windows so I re-submitted a PR to get the Windows build building again. Thanks -- Paul Levy : Pelican

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-21 Thread Trajce Nikolov NICK
Hi Robert, I had the same issue with the FBO failing to initialize. Works now with the master. On Tue, Aug 21, 2018 at 2:34 PM Robert Osfield wrote: > Hi Glenn, > > We have had a bash at resolve this issue. Could you please try out > OSG master or the OpenSceneGraph-3.6-TexStorage branch to

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-21 Thread Robert Osfield
Hi Glenn, We have had a bash at resolve this issue. Could you please try out OSG master or the OpenSceneGraph-3.6-TexStorage branch to see if this issue still exists. Cheers, Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Julien Valentin
Here's my example corrections to remove unsized internal formats https://github.com/openscenegraph/OpenSceneGraph/pull/592 I also add setSourceFormat to comply when no immutable available mp3butcher wrote: > @Robert > forget my last post (it was a bug left on my branch) > I don't understand

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Julien Valentin
@Robert forget my last post (it was a bug left on my branch) I don't understand the bug found in osgdeffered i've just launch it whithout any problem..It would have been weird as i don't implement immutable imageless TextureRectangle yet... I'll make 2 separate pr for examples correction and

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Julien Valentin
@Robert As you see I removed some call to setSourceFormat This is because i made sourceformat more prioritized than internal format in my glTexStorageXD calls it surely be wiser to remove this priority scheme (only when texstorage available) and don't remove call to setSourceFormat mp3butcher

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Julien Valentin
All is linked: in osgdeffered: remove l.51 // tex2D->setSourceFormat(GL_RGBA); in osgssbo l.802 texture->setInternalFormat(GL_RGBA16); osgoit : DpethPeeling.cpp remove l310 colorTexture->setInternalFormat(GL_RGBA16); and that's all (I haven't made pr for them) Paul Levy wrote: >

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Paul Levy
Julien, Thanks for looking into it. I think there is a different problem as Glenn mentioned. All the examples that use COLOR_BUFFER0 are broken on my system. osgdeferred, osgSSBO, osgoit, etc are a few I tried. Setting OSG_GL_TEXTURE_STORAGE=OFF fixes the problem but as Glenn mentioned,

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Julien Valentin
I debugged osgprerender It was the unsized texture format: changing GL_RGBA to GL_RGBA8 i'll patch the example but you have to patch osgearth gwaldron wrote: > Julian,New information: In osgEarth we use Camera::attach like so: > > >    rttCamera->attach(osg::Camera::COLOR_BUFFER0, texture); >

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Glenn Waldron
Several OSG examples also bind to COLOR_BUFFER0 for RTT and they fail in a similar fashion: osgoit, osgblenddrawbuffers, osgSSBO, osgdeferred. Glenn Waldron On Fri, Aug 10, 2018 at 1:48 PM Glenn Waldron wrote: > Julian, > New information: In osgEarth we use Camera::attach like so: > >

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Glenn Waldron
Julian, New information: In osgEarth we use Camera::attach like so: rttCamera->attach(osg::Camera::COLOR_BUFFER0, texture); If I replace COLOR_BUFFER0 with COLOR_BUFFER, it works. Been using the former since forever but maybe it was wrong. Glenn Waldron On Fri, Aug 10, 2018 at 12:39 PM

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Julien Valentin
No you're right osgprerender bugs I'll dig it mp3butcher wrote: > Hi > It's weird that immutable texture interact with fbo render to texture. > I've done a lot of FBORTT since this commit and haven't seen any problem > Are you sure your problem come from here? > Try to replicate the behavior

Re: [osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-10 Thread Julien Valentin
Hi It's weird that immutable texture interact with fbo render to texture. I've done a lot of FBORTT since this commit and haven't seen any problem Are you sure your problem come from here? Try to replicate the behavior in a simple example code please Cheers gwaldron wrote: > Robert, > > > We

[osg-users] New glTexStorage code is disrupting FBO initialization

2018-08-09 Thread Glenn Waldron
Robert, We recently pulled the latest master branch of OpenSceneGraph, and found that FBOs in osgEarth no longer initialize properly. We narrowed the problem down to this commit which appears to introduce the usage of glTexStorage: