Re: [osg-users] OpenSceneGraph-3.6.1 release candidate 6 tagged

[Robert Osfield]

Thanks Maxim. I've applied this fix to the 3.6 branch and master.

On 22 May 2018 at 21:17, Maxim Stere  wrote:
> Hi Robert,
>
> We found a bug in the timer class.
>
> in osg/Timer lines 21 to 25 read:
>
>
> Code:
>
> #if defined(_MSC_VER)
> typedef __int64 Timer_t;
> #else
> typedef unsigned long long Timer_t;
> #endif
>
>
>
>
> but it should be
>
>
> Code:
>
> #if defined(_MSC_VER)
> typedef unsigned __int64 Timer_t;
> #else
> typedef unsigned long long Timer_t;
> #endif
>
>
>
>
> We were working with timers in Linux and Windows, and noticed that in certain 
> cases you can introduce a bug that will be hidden on Windows and will break 
> things on Linux if you all of a sudden somehow get negative Timer_t
>
>
> ...
>
> Thank you!
>
> Cheers,
> Maxim
>
> 
> Thank you,
> --Maxim
>
> --
> Read this topic online here:
> http://forum.openscenegraph.org/viewtopic.php?p=73714#73714
>
>
>
>
>
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OpenSceneGraph-3.6.1 release candidate 6 tagged

[Maxim Stere]

Hi Robert,

We found a bug in the timer class. 

in osg/Timer lines 21 to 25 read:


Code:

#if defined(_MSC_VER)
typedef __int64 Timer_t;
#else
typedef unsigned long long Timer_t;
#endif




but it should be


Code:

#if defined(_MSC_VER)
typedef unsigned __int64 Timer_t;
#else
typedef unsigned long long Timer_t;
#endif




We were working with timers in Linux and Windows, and noticed that in certain 
cases you can introduce a bug that will be hidden on Windows and will break 
things on Linux if you all of a sudden somehow get negative Timer_t


... 

Thank you!

Cheers,
Maxim


Thank you,
--Maxim

--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=73714#73714





___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OpenSceneGraph-3.6.1 release candidate 6 tagged

[Robert Osfield]

Hi Björn,

Sorry to hear that you have .osgb's that are failing.

I can have a look into it.  It could be a simple regression but also
might a more awkward issue to resolve, there is chance that there is
incompatibility that is not straight forward to resolve - for instance
if there was a bug in the original writer/file format that has been
fixed.  If the later then it may be a case of writing out the file to
a .osgt, .osg or .ive and then reloading and writing back out as a
.osgb.  For testing purposes it may be useful to do this.

What version of the OSG where these files generated with?

Just send me a link to the files directly I can have a look myself.

Cheers,
Robert.

On 22 May 2018 at 12:01, Björn Blissing <bjorn.bliss...@vti.se> wrote:
> Hi,
>
> I haven't been able to test the previous release candidates. But I do have 
> some troubles reading some of my osgb files. These files work with osg 3.5.9 
> but currently gives a lot of the following warnings and then fails:
>
> 
> ...
> InputIterator::checkStream() : _in->rdstate() 2, 2
>_in->tellg() = -1
> InputIterator::checkStream() : _in->rdstate() 2, 2
>_in->tellg() = -1
> InputIterator::checkStream() : _in->rdstate() 2, 2
>_in->tellg() = -1
> Error reading file testfile.osgb: read error (InputStream: Failed to read 
> from stream. At osg::Group osg::Group osg::Geode osg::Drawable osg::StateSet 
> osg::Texture2D )
> osgviewer: No data loaded
> ==
>
> Compiled as 64bit using Visual Studio 2017 15.7.2
>
> I cannot share these files publicly, but I could probably send a file via 
> some form of private channel if Robert want to have a look. (The above file 
> is ~100mb).
>
> Best regards
> Björn
>
>>-Original Message-
>>From: osg-users <osg-users-boun...@lists.openscenegraph.org> On Behalf Of
>>Robert Osfield
>>Sent: Tuesday, May 22, 2018 8:40 AM
>>To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org>
>>Subject: [osg-users] OpenSceneGraph-3.6.1 release candidate 6 tagged
>>
>>Hi All,
>>
>>More testing uncovered more issues to fix, these are now fixed so time
>>for yet another release candidate :-)
>>
>>
>>https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGrap
>>h-3.6.1-rc6
>>
>>Please test and let us know of success or failure.  I can't imagine
>>there is much left to fix, surely but only more testing will let
>>us know.
>>
>>My plan is tag 3.6.1 this week, if rc6 looks good then I'll tag it tomorrow.
>>
>>Cheers,
>>Robert.
>>
>>-- ChangeLog since rc5
>>
>>Mon, 21 May 2018 13:26:04 -0400
>>Author : gwaldron
>>osgText: perform pixel size computation in double-precision to prevent
>>coordinate jitter
>>
>>Mon, 21 May 2018 18:14:18 +0100
>>Author : Robert Osfield
>>Moved the rotation to before the scale
>>
>>Mon, 21 May 2018 13:18:29 +0100
>>Author : Robert Osfield
>>Fixed typos
>>
>>Mon, 21 May 2018 13:10:40 +0100
>>Author : Robert Osfield
>>Restored the REGISTER_WINDOWINGSYSTEMINTERFACE macro to the
>>include/osg/GraphicsContext header and removed the OSGVIEWER_EXPORT
>>as
>>this was causing compatibility issues with osgQt.In
>>GraphicsWindowWin32 replaced REGISTER_WINDOWINGSYSTEMINTERFACE
>>usage
>>with locally implemented equivilant with the required
>>OSGVIEWER_EXPORT.
>>___
>>osg-users mailing list
>>osg-users@lists.openscenegraph.org
>>http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] OpenSceneGraph-3.6.1 release candidate 6 tagged

[Björn Blissing]

Hi,

I haven't been able to test the previous release candidates. But I do have some 
troubles reading some of my osgb files. These files work with osg 3.5.9 but 
currently gives a lot of the following warnings and then fails:


...
InputIterator::checkStream() : _in->rdstate() 2, 2
   _in->tellg() = -1
InputIterator::checkStream() : _in->rdstate() 2, 2
   _in->tellg() = -1
InputIterator::checkStream() : _in->rdstate() 2, 2
   _in->tellg() = -1
Error reading file testfile.osgb: read error (InputStream: Failed to read from 
stream. At osg::Group osg::Group osg::Geode osg::Drawable osg::StateSet 
osg::Texture2D )
osgviewer: No data loaded
==

Compiled as 64bit using Visual Studio 2017 15.7.2 

I cannot share these files publicly, but I could probably send a file via some 
form of private channel if Robert want to have a look. (The above file is 
~100mb).

Best regards
Björn

>-Original Message-
>From: osg-users <osg-users-boun...@lists.openscenegraph.org> On Behalf Of
>Robert Osfield
>Sent: Tuesday, May 22, 2018 8:40 AM
>To: OpenSceneGraph Users <osg-users@lists.openscenegraph.org>
>Subject: [osg-users] OpenSceneGraph-3.6.1 release candidate 6 tagged
>
>Hi All,
>
>More testing uncovered more issues to fix, these are now fixed so time
>for yet another release candidate :-)
>
>
>https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGrap
>h-3.6.1-rc6
>
>Please test and let us know of success or failure.  I can't imagine
>there is much left to fix, surely but only more testing will let
>us know.
>
>My plan is tag 3.6.1 this week, if rc6 looks good then I'll tag it tomorrow.
>
>Cheers,
>Robert.
>
>-- ChangeLog since rc5
>
>Mon, 21 May 2018 13:26:04 -0400
>Author : gwaldron
>osgText: perform pixel size computation in double-precision to prevent
>coordinate jitter
>
>Mon, 21 May 2018 18:14:18 +0100
>Author : Robert Osfield
>Moved the rotation to before the scale
>
>Mon, 21 May 2018 13:18:29 +0100
>Author : Robert Osfield
>Fixed typos
>
>Mon, 21 May 2018 13:10:40 +0100
>Author : Robert Osfield
>Restored the REGISTER_WINDOWINGSYSTEMINTERFACE macro to the
>include/osg/GraphicsContext header and removed the OSGVIEWER_EXPORT
>as
>this was causing compatibility issues with osgQt.In
>GraphicsWindowWin32 replaced REGISTER_WINDOWINGSYSTEMINTERFACE
>usage
>with locally implemented equivilant with the required
>OSGVIEWER_EXPORT.
>___
>osg-users mailing list
>osg-users@lists.openscenegraph.org
>http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

[osg-users] OpenSceneGraph-3.6.1 release candidate 6 tagged

[Robert Osfield]

Hi All,

More testing uncovered more issues to fix, these are now fixed so time
for yet another release candidate :-)

   
https://github.com/openscenegraph/OpenSceneGraph/tree/OpenSceneGraph-3.6.1-rc6

Please test and let us know of success or failure.  I can't imagine
there is much left to fix, surely but only more testing will let
us know.

My plan is tag 3.6.1 this week, if rc6 looks good then I'll tag it tomorrow.

Cheers,
Robert.

-- ChangeLog since rc5

Mon, 21 May 2018 13:26:04 -0400
Author : gwaldron
osgText: perform pixel size computation in double-precision to prevent
coordinate jitter

Mon, 21 May 2018 18:14:18 +0100
Author : Robert Osfield
Moved the rotation to before the scale

Mon, 21 May 2018 13:18:29 +0100
Author : Robert Osfield
Fixed typos

Mon, 21 May 2018 13:10:40 +0100
Author : Robert Osfield
Restored the REGISTER_WINDOWINGSYSTEMINTERFACE macro to the
include/osg/GraphicsContext header and removed the OSGVIEWER_EXPORT as
this was causing compatibility issues with osgQt.In
GraphicsWindowWin32 replaced REGISTER_WINDOWINGSYSTEMINTERFACE usage
with locally implemented equivilant with the required
OSGVIEWER_EXPORT.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org