Hi Jean,
thank you for the patch. Currently I have submitted only the CMake part,
because the SSAO example is in progress. Unfortunately I do not have enough
time to work on it now, therefor I just deactivated it, so that it doesn't get
compiled for now. I hope I will get free time for it soon, to acomplish it.
As to the installation path for the examples, you are probably right. We need
something kind of same mechanism as for the osg examples. I will try to make
some nice solution soon for it.
Thank you again.
Best regards,
art
--- Jean-Sébastien Guay [EMAIL PROTECTED] schrieb am Di, 11.11.2008:
Von: Jean-Sébastien Guay [EMAIL PROTECTED]
Betreff: [osg-users] Some small osgPPU modifications
An: OpenSceneGraph Users osg-users@lists.openscenegraph.org
Datum: Dienstag, 11. November 2008, 16:10
Hi Art,
Updating the osgPPU SVN and compiling today, I found I
needed some small changes:
1. In the new SSAO example, the setupCamera function does
not return a value but has osg::Camera* return type. It
should be void, since it operates on the camera passed as
argument and the main() does not store its return value (if
there was one) anyways.
Side note: I'm pretty apalled that gcc lets this kind
of error pass... It's pretty basic IMHO. What would
happen if you had taken the return value? Would it be
uninitialized, or would gcc flag the error then?
2. On Windows, we need to have the 'd' suffix on
the plugin DLL too, and the code in
CMakeModules/OsgPPUMacroUtils.cmake (SETUP_PLUGIN) just
removed the suffix in the NOT MSVC case, but never added it
in the else... so I added that.
3. The ssao_fp.glsl shader had some errors. I'm still
not sure it gives the right result (looks like just a
visualization of the depth buffer to me - perhaps it's
not complete yet?), but at least it compiles.
It would be nice to install the examples to some directory
for out-of-source builds, for example
$CMAKE_INSTALL_PREFIX/share/osgPPU/bin like OSG does. But I
didn't do that yet, if you want I can do it.
I've tested the examples I could (i.e. all except
texture3D and video) and they seem to work (except as noted
above for the SSAO example).
Changes attached.
J-S
-- __
Jean-Sebastien Guay[EMAIL PROTECTED]
http://www.cm-labs.com/
http://whitestar02.webhop.org/
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
