Re: [osg-users] libPNG API changes

2010-04-01 Thread Paul Martz

Bruce Wheaton wrote:
LibPNG changed their API in January. I have a current Arch Linux install 
which uses the newer version, but we can presume it will crop up more. 
The only two current issues are addressed by:


/OpenSceneGraph/src/osgPlugins/png/ReaderWriterPNG.cpp 
176d175

 #if PNG_LIBPNG_VER  10004
178,180d176
 #else
 if (fin.gcount() == 8  png_sig_cmp(header, 0, 8) == 0)
 #endif
231,232d226
 {
 #if PNG_LIBPNG_VER  10004
234,237d227
 #else
png_set_expand_gray_1_2_4_to_8(png);
 #endif
 }

As per the libPNG recommendations, to replace png_check_sig 
and png_set_gray_1_2_4_to_8()


http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt

If this isn't the best/place to report this, someone please let me know.


Hi Bruce -- This appears to be fixed on trunk with r11121. It's a non-invasive 
change, except for I also need to add r10763 (essentially just a change to CMake 
except for the PNG plugin code changes). But I have now merged r10763 and r11121 
onto the 2.8 branch, so now we should have support for many versions of libPNG 
(I'm using an older version) and also adds the OSG_CPP_EXCEPTIONS_AVAILABLE 
CMake option.


I'll tag a release candidate shortly.
--
  -Paul Martz  Skew Matrix Software
   http://www.skew-matrix.com/
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


[osg-users] libPNG API changes

2010-03-31 Thread Bruce Wheaton
LibPNG changed their API in January. I have a current Arch Linux  
install which uses the newer version, but we can presume it will crop  
up more. The only two current issues are addressed by:


/OpenSceneGraph/src/osgPlugins/png/ReaderWriterPNG.cpp
176d175
#if PNG_LIBPNG_VER  10004
178,180d176
#else
if (fin.gcount() == 8  png_sig_cmp(header, 0, 8) == 0)
#endif
231,232d226
{
#if PNG_LIBPNG_VER  10004
234,237d227
#else
png_set_expand_gray_1_2_4_to_8(png);
#endif
}

As per the libPNG recommendations, to replace png_check_sig and  
png_set_gray_1_2_4_to_8()


http://www.libpng.org/pub/png/src/libpng-1.2.x-to-1.4.x-summary.txt

If this isn't the best/place to report this, someone please let me know.

Regards,

Bruce Wheaton___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org