Re: [osg-users] pragma warnings disabled in headers

2008-11-25 Thread Robert Osfield
Hi Wojtek, On Tue, Nov 25, 2008 at 11:39 AM, Wojciech Lewandowski [EMAIL PROTECTED] wrote: But the other side is that proper fixing would probably require modifying hundreds of OSG headers. I doubt that there is anyone brave enough to accept this time consuming task and I doubt Robert will

Re: [osg-users] pragma warnings disabled in headers

2008-11-25 Thread Wojciech Lewandowski
Hi Guys, I generally agree that suppressing these warnings is bad. Truth is if they were not disabled at the early days of OSG most of them would be not present today because authors would fix them in other way. And this poses a danger for the future. As along as we keep them disabled authors

Re: [osg-users] pragma warnings disabled in headers

2008-11-24 Thread Wojciech Lewandowski
Hi Robert, I have restored MSVC disabled warnings in osg/Export. Difference is they are now disabled only when OSG_DISABLE_MSVC_WARNINGS macro is defined. This macro is set through CMake options and autogenerated in osg/Config. Simon suggested that it would be cool if we had more control

Re: [osg-users] pragma warnings disabled in headers

2008-11-24 Thread Tomlinson, Gordon
PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Paul Martz Sent: Monday, November 24, 2008 4:38 PM To: 'OpenSceneGraph Users' Subject: Re: [osg-users] pragma warnings disabled in headers Hi all -- Sorry I'm coming into this a little late. What I'd really like is a clean compile so that if I

Re: [osg-users] pragma warnings disabled in headers

2008-11-24 Thread Paul Martz
I thought a push and pop pragma would work ( I use that in my code) , but that would be in the headers which Robert wants to avoid I'm usually opposed to push/pop too -- not because they're in the headers, but because they disable displaying warnings for a block of code, and therefore

Re: [osg-users] pragma warnings disabled in headers

2008-11-21 Thread Simon Hammett
2008/11/21 Wojciech Lewandowski [EMAIL PROTECTED]: Hi, Guys Some middle step solution could be CMake define which would activate warning disable in osg\Export. Would this be acceptable ? What do other OSG windows developers think ? Sounds good to me. Though perhaps we should go whole hog

Re: [osg-users] pragma warnings disabled in headers

2008-11-21 Thread Wojciech Lewandowski
:35 PM Subject: Re: [osg-users] pragma warnings disabled in headers 2008/11/7 Robert Osfield [EMAIL PROTECTED] On Fri, Nov 7, 2008 at 3:42 PM, Simon Hammett [EMAIL PROTECTED] wrote: I agree with Peter, arbitrarily turning off peoples warnings isn't good practice. The OSG generally doesn't

Re: [osg-users] pragma warnings disabled in headers

2008-11-07 Thread Simon Hammett
2008/11/7 Robert Osfield [EMAIL PROTECTED] Hi Peter, On Fri, Nov 7, 2008 at 12:11 PM, Peter Wraae Marino [EMAIL PROTECTED] wrote: there is no push/pop for the warning in the header file which will make these warnings disabled in my own code too. I would like to catch this warnings in my

Re: [osg-users] pragma warnings disabled in headers

2008-11-07 Thread Robert Osfield
On Fri, Nov 7, 2008 at 3:42 PM, Simon Hammett [EMAIL PROTECTED] wrote: I agree with Peter, arbitrarily turning off peoples warnings isn't good practice. The OSG generally doesn't disable warnings, warning disabling is only done on VS as it's had a history of producing lots of warnings on

Re: [osg-users] pragma warnings disabled in headers

2008-11-07 Thread Robert Osfield
Hi Peter, On Fri, Nov 7, 2008 at 12:11 PM, Peter Wraae Marino [EMAIL PROTECTED] wrote: there is no push/pop for the warning in the header file which will make these warnings disabled in my own code too. I would like to catch this warnings in my own code and I shouldn't be forced to enabling

Re: [osg-users] pragma warnings disabled in headers

2008-11-07 Thread Simon Hammett
2008/11/7 Robert Osfield [EMAIL PROTECTED] On Fri, Nov 7, 2008 at 3:42 PM, Simon Hammett [EMAIL PROTECTED] wrote: I agree with Peter, arbitrarily turning off peoples warnings isn't good practice. The OSG generally doesn't disable warnings, warning disabling is only done on VS as it's had

[osg-users] pragma warnings disabled in headers

2008-11-07 Thread Peter Wraae Marino
Hi Users (Robert), I noticed that the include file export has the following #if defined(_MSC_VER) #pragma warning( disable : 4244 ) #pragma warning( disable : 4251 ) #pragma warning( disable : 4267 ) #pragma warning( disable : 4275 ) #pragma warning( disable : 4290 )