Re: [osg-users] osgjs fix for 64 builds with some compilers

[Robert Osfield]

On 18 February 2016 at 10:36, Trajce Nikolov NICK <
trajce.nikolov.n...@gmail.com> wrote:

> Hi Robert,
>
> since this is one line and related to output info maybe this will be
> enough to work on both platforms
>
> ss << (int64_t)image << ".inline_conv_generated.png"; // write the
> pointer location
>

I have applied this change and checked it into master and OSG-3.4 branch.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] osgjs fix for 64 builds with some compilers

[Trajce Nikolov NICK]

Hi Robert,

since this is one line and related to output info maybe this will be enough
to work on both platforms

ss << (int64_t)image << ".inline_conv_generated.png"; // write the pointer
location

On Thu, Feb 18, 2016 at 11:21 AM, Trajce Nikolov NICK <
trajce.nikolov.n...@gmail.com> wrote:

> Hi Robert,
>
> I did fast fix hoping you will find a time to comment on this. I agree
> with you .. Let me try to do it more properly :)
>
> Thanks for finding a time to look at the issue!
>
> Cheers,
> Nick
>
> On Thu, Feb 18, 2016 at 10:45 AM, Robert Osfield  > wrote:
>
>> Hi Nick,
>>
>> I have just reviewed your change and don't feel it's the appropriate way
>> to tackle this type of issue.  If long int isn't being interpreted as 64bit
>> int then it would be appropriate to use a typedef rather than #ifdef
>> blocks.  The include/osg/Types file contains int64_t, could you just try
>> this instead?
>>
>> Robert.
>>
>> On 29 January 2016 at 10:26, Trajce Nikolov NICK <
>> trajce.nikolov.n...@gmail.com> wrote:
>>
>>> Hi Robert,
>>>
>>> attached is small fix for 64 builds with some compilers. It is from the
>>> 3.5.1 dev release. Is there a chance to integrate this fix into the
>>> mentioned version?
>>>
>>> Was tested with MSVC and g++
>>>
>>> --
>>> trajce nikolov nick
>>>
>>> ___
>>> osg-users mailing list
>>> osg-users@lists.openscenegraph.org
>>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>>
>>>
>>
>> ___
>> osg-users mailing list
>> osg-users@lists.openscenegraph.org
>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>
>>
>
>
> --
> trajce nikolov nick
>



-- 
trajce nikolov nick
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] osgjs fix for 64 builds with some compilers

[Trajce Nikolov NICK]

Hi Robert,

I did fast fix hoping you will find a time to comment on this. I agree with
you .. Let me try to do it more properly :)

Thanks for finding a time to look at the issue!

Cheers,
Nick

On Thu, Feb 18, 2016 at 10:45 AM, Robert Osfield 
wrote:

> Hi Nick,
>
> I have just reviewed your change and don't feel it's the appropriate way
> to tackle this type of issue.  If long int isn't being interpreted as 64bit
> int then it would be appropriate to use a typedef rather than #ifdef
> blocks.  The include/osg/Types file contains int64_t, could you just try
> this instead?
>
> Robert.
>
> On 29 January 2016 at 10:26, Trajce Nikolov NICK <
> trajce.nikolov.n...@gmail.com> wrote:
>
>> Hi Robert,
>>
>> attached is small fix for 64 builds with some compilers. It is from the
>> 3.5.1 dev release. Is there a chance to integrate this fix into the
>> mentioned version?
>>
>> Was tested with MSVC and g++
>>
>> --
>> trajce nikolov nick
>>
>> ___
>> osg-users mailing list
>> osg-users@lists.openscenegraph.org
>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>
>>
>
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
>


-- 
trajce nikolov nick
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org

Re: [osg-users] osgjs fix for 64 builds with some compilers

[Robert Osfield]

Hi Nick,

I have just reviewed your change and don't feel it's the appropriate way to
tackle this type of issue.  If long int isn't being interpreted as 64bit
int then it would be appropriate to use a typedef rather than #ifdef
blocks.  The include/osg/Types file contains int64_t, could you just try
this instead?

Robert.

On 29 January 2016 at 10:26, Trajce Nikolov NICK <
trajce.nikolov.n...@gmail.com> wrote:

> Hi Robert,
>
> attached is small fix for 64 builds with some compilers. It is from the
> 3.5.1 dev release. Is there a chance to integrate this fix into the
> mentioned version?
>
> Was tested with MSVC and g++
>
> --
> trajce nikolov nick
>
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org