Hi Igor, Thanks for the patch. It looks good to me. I've applied it to trunk.
Can you please update the documentation for the next version on the wiki to describe the new argument value? http://wiki.openstreetmap.org/wiki/Osmosis/Detailed_Usage_0.39 Cheers, Brett On Sun, Feb 6, 2011 at 4:12 AM, Igor Podolskiy < igor.podols...@vwi-stuttgart.de> wrote: > Hello everybody, > > first of all, thank you all for developing Osmosis! :) > > I currently have some issues with the compressionMethod parameter in the > XML tasks. This is just a minor annoyance but nevertheless: > > The compressionMethod parameter of the --[fast]-read-xml task is currently > handled somewhat differently than most other parameters in Osmosis. > CompressionMethod has three official values (none, gzip, bzip2), but > actually there is a fourth option (autodetect) which can only be specified > implicitly by omitting compressionMethod altogether. > > Although this is documented in the wiki, it creates problems for people who > build tools around Osmosis which read and/or generate Osmosis command lines > automatically, and even for a human user, this is another special case which > you need to think of (no other parameter in any task works this way). > > This can easily be fixed by creating an explicit fourth value (say, "auto") > for compressionMethod, and making it the default value. This change doesn't > break old scripts and streamlines the parameters for new ones. The attached > patch against current trunk does this (and the trunk still passes all unit > tests with the patch applied). > > It would be cool if you could integrate this into the next version of > Osmosis. If you have any questions or if the patch needs some improvement, > I'll be here on the mailing list :). > > Best regards > Igor > > _______________________________________________ > osmosis-dev mailing list > osmosis-dev@openstreetmap.org > http://lists.openstreetmap.org/listinfo/osmosis-dev > >
_______________________________________________ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
