Re: [osmosis-dev] Osmosis and Osmium-enhanced PBF files with way node locations

2018-03-11 Thread Brett Henderson
Hmm, my previous email was probably hard to read. Let me know if it doesn't make sense. One other thing I should mention. GIven that you are just adding read support, have you looked at the osmosis-pbf2 sub-project? It contains an alternative PBF reading implementation that I wrote to support

Re: [osmosis-dev] Osmosis and Osmium-enhanced PBF files with way node locations

2018-03-11 Thread Jochen Topf
On Sun, Mar 11, 2018 at 10:19:21AM +, Brett Henderson wrote: > *osmformat.proto* > Are these changes mastered somewhere else? In other words, are these new > fields the same ones used by Osmium in its implementation? I'm wondering > if we need to re-sync from the main OSM-binary project.

Re: [osmosis-dev] Osmosis and Osmium-enhanced PBF files with way node locations

2018-03-11 Thread Locke, Jonathan
Thanks for the feedback, Brett. I'm on vacation tomorrow, but I'll try to address your concerns on Tuesday. Jon From: Jochen Topf Sent: Sunday, March 11, 2018 5:56:54 AM To: Brett Henderson Cc: Locke, Jonathan; Van Exel, Martijn;

Re: [osmosis-dev] Osmosis and Osmium-enhanced PBF files with way node locations

2018-03-11 Thread Brett Henderson
Hi Jon, Thanks for sending through the patch. I've just taken a look at it. Some comments: *WayNode* The WayNode class now has the new optional latitude and longitude fields which makes sense. Can you update the store method and (StoreReader, StoreClassRegister) constructor to persist and