Re: [oss-devel] sync_control for envy24ht devices

2008-06-10 Thread Hannu Savolainen
Zakhar Levchenko wrote: > Ok, I've prepared the next version. It is attached to this mail. This > version contains also a couple of fixes for warnings about indeces out > of array boundaries. Many thanks. I have applied it to the current version. Will appear in the hg server soon. Best regards,

Re: [oss-devel] sync_control for envy24ht devices

2008-06-09 Thread Zakhar Levchenko
Ok, I've prepared the next version. It is attached to this mail. This version contains also a couple of fixes for warnings about indeces out of array boundaries. Regards, Zakhar levchenko On 6/10/08, Hannu Savolainen <[EMAIL PROTECTED]> wrote: > > Zakhar Levchenko kirjoitti: > > > I did

Re: [oss-devel] sync_control for envy24ht devices

2008-06-09 Thread Hannu Savolainen
Zakhar Levchenko kirjoitti: > I didn't mean that another procesess may interrupt execution, no. I > meant that handle_syncstart itself may return before SYNC_START stage. > There is the following code in handle_syncstart: > > if((err = prepare_output(adev, adev->dmap_out)) < 0) > return err; >

Re: [oss-devel] sync_control for envy24ht devices

2008-06-09 Thread Zakhar Levchenko
I didn't mean that another procesess may interrupt execution, no. I meant that handle_syncstart itself may return before SYNC_START stage. There is the following code in handle_syncstart: if((err = prepare_output(adev, adev->dmap_out)) < 0) return err; If prepare_output fails handle_syncstart w

Re: [oss-devel] sync_control for envy24ht devices

2008-06-09 Thread Hannu Savolainen
Zakhar Levchenko kirjoitti: > Hi, > > This is good approach, however it may fail if syncstart operation is > interrupted before SYNC_TRIGGER stage. I don't know if this is really > possible in practice, It will not be possible because there is now a mutex around the code that makes the SYNC_PREP

Re: [oss-devel] sync_control for envy24ht devices

2008-06-09 Thread Zakhar Levchenko
Hi, This is good approach, however it may fail if syncstart operation is interrupted before SYNC_TRIGGER stage. I don't know if this is really possible in practice, however code of handle_syncstart permits this. On lines 2744 and 2745 result of prepare_output is checked and if prepare_output fails

Re: [oss-devel] sync_control for envy24ht devices

2008-06-09 Thread Hannu Savolainen
Zakhar Levchenko kirjoitti: > Hi, > > I've attached a patch that implements sync_control for envy24ht devices. I would recommend you do it in slightly different way: Add a syncstart_mask field to devc. During SYNC_PREPARE: devc->syncstart_mask |= portc->mask; /* Add this sub-device to the m