Re: [OSS-Tools] [PATCH 2/8] libdt: factor out u64 sysattr parsing into helper

2023-06-02 Thread Roland Hieber
On Fri, Jun 02, 2023 at 03:16:13PM +0200, Roland Hieber wrote: > On Wed, May 31, 2023 at 05:22:47PM +0200, Ahmad Fatoum wrote: > > We will need to parse two more sysattrs in a follow-up patch, so factor > > this out for reuse. While at it switch to 64-bit strtoull: This may > > be more useful for

Re: [OSS-Tools] [PATCH 2/8] libdt: factor out u64 sysattr parsing into helper

2023-06-02 Thread Roland Hieber
On Wed, May 31, 2023 at 05:22:47PM +0200, Ahmad Fatoum wrote: > We will need to parse two more sysattrs in a follow-up patch, so factor > this out for reuse. While at it switch to 64-bit strtoull: This may > be more useful for future users and unlike atol doesn't invoke undefined > behavior when

Re: [OSS-Tools] [PATCH 5/5] barebox-state: fix use after free in error path

2023-06-02 Thread Roland Hieber
For the whole series: Reviewed-by: Roland Hieber On Wed, May 31, 2023 at 05:10:15PM +0200, Ahmad Fatoum wrote: > blob_bin is freed a few lines above unconditionally, so freeing it > again in the error path will cause a double free. > > Signed-off-by: Ahmad Fatoum > --- > src/keystore-blob.c