Re: [OSS-Tools] [PATCH dt-utils 11/12] state: fix formatting of "off_t" variables

On Mon, Feb 04 2019 at 10:06 +0100, Uwe Kleine-König wrote: > On Mon, Feb 04, 2019 at 08:54:29AM +0100, Juergen Borleis wrote: >> On Sunday 03 February 2019 22:48:06 Ulrich Ölmann wrote: >> > Explicitely casting an "off_t" variable to "long long" and

[OSS-Tools] [PATCH dt-utils 10/12] base64: remove duplicate ‘const’ declaration specifier

By cleaning up the code the compiler does not emit the following warning anymore: src/base64.c:15:19: warning: duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier] static const char const uuenc_tbl_base64[65 + 1] = { ^ Signed-off-by: Ulrich

[OSS-Tools] [PATCH dt-utils 07/12] barebox-state: remove unused variables

-by: Ulrich Ölmann --- src/barebox-state.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/barebox-state.c b/src/barebox-state.c index fc9a7bb055ef..946a8dba6d8c 100644 --- a/src/barebox-state.c +++ b/src/barebox-state.c @@ -251,7 +251,6 @@ static char *__state_string_get(struct

[OSS-Tools] [PATCH dt-utils 08/12] keystore-blob: remove unused variable

; ^~~~ Signed-off-by: Ulrich Ölmann --- src/keystore-blob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/keystore-blob.c b/src/keystore-blob.c index 028dd8bcc9be..f71ff5d9d5cb 100644 --- a/src/keystore-blob.c +++ b/src/keystore-blob.c @@ -22,7 +22,7 @@ static struct state

[OSS-Tools] [PATCH dt-utils 06/12] barebox-state: remove declaration of __state_uint8_get()

); ^ The function is not needed as its job is done by __state_uint32_get(). Signed-off-by: Ulrich Ölmann --- src/barebox-state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/barebox-state.c b/src/barebox-state.c index 4e087b9d63bf..fc9a7bb055ef 100644 --- a/src/barebox-state.c +++ b/src

[OSS-Tools] [PATCH dt-utils 04/12] barebox-state: complete cmdline options

t. - the call to getopt_long() already allowed the option "-f" in its optstring, but the usage() message said nothing about it, hence amend that and offer the long option "--force" as well. Signed-off-by: Ulrich Ölmann --- src/barebox-state.c | 5 - 1 file chang

[OSS-Tools] [PATCH dt-utils 01/12] common: align declarations of dev_add_param_*() functions with barebox

s applying the compiler option "-Wno-pointer-sign" in its main makefile. Signed-off-by: Ulrich Ölmann --- src/dt/common.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/dt/common.h b/src/dt/common.h index de8d2938a149..c3c4f53fc216 100644 --- a/src/dt/common.h +

[OSS-Tools] [PATCH dt-utils 11/12] state: fix formatting of "off_t" variables

Explicitely casting an "off_t" variable to "long long" and formatting it via "%lld" or "%llx" respectively makes 32- as well as 64-bit compilers happy (tested with gcc-8.2.1 and clang-7.0.1). Signed-off-by: Ulrich Ölmann --- src/bare

[OSS-Tools] [PATCH dt-utils 05/12] barebox-state: add cmdline option "--version"

Signed-off-by: Ulrich Ölmann --- src/barebox-state.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/barebox-state.c b/src/barebox-state.c index 0f40044bc2c6..4e087b9d63bf 100644 --- a/src/barebox-state.c +++ b/src/barebox-state.c @@ -366,6 +366,7 @@ struct state *state_get(const

[OSS-Tools] [PATCH dt-utils 03/12] barebox-state: fix usage of multiple state instances

ve calls $ barebox-state --get blue.x $ barebox-state --get yellow.y would succeed. This commit fixes that bug. Signed-off-by: Ulrich Ölmann --- src/barebox-state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/barebox-state.c b/src/barebox-state.c index 3e6c2600346

[OSS-Tools] [PATCH dt-utils 12/12] state: fix formatting of "uint32_t" variables

The format specifier "%zd" is for "size_t" typed variables and produces a warning with gcc, so use "%u" instead. Signed-off-by: Ulrich Ölmann --- src/barebox-state/backend_bucket_circular.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[OSS-Tools] [PATCH dt-utils 02/12] of_get_devicepath: again correct comment

The cited patch went mainline meanwhile so reflect that in the comment. Signed-off-by: Ulrich Ölmann --- src/libdt.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libdt.c b/src/libdt.c index 4638678fcd30..8ae9978c66c2 100644 --- a/src/libdt.c +++ b/src/libdt.c

[OSS-Tools] [PATCH dt-utils] state: backend_bucket_circular: fix double free()

From: Kim Christensen The function state_mtd_peb_read() is only a user of buf and not its owner, hence it may not deallocate it. Signed-off-by: Kim Christensen Acked-by: Ulrich Ölmann --- src/barebox-state/backend_bucket_circular.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src

Re: [OSS-Tools] [PATCH dt-utils] state: backend_bucket_circular: fix double free()

On Wed, Sep 18 2019 at 22:23 +0200, Uwe Kleine-König wrote: > On Wed, Sep 18, 2019 at 04:48:23PM +0200, Ulrich Ölmann wrote: >> From: Kim Christensen >> >> The function state_mtd_peb_read() is only a user of buf and not its owner, >> hence >> it may not deallo

[OSS-Tools] [PATCH dt-utils 03/13] state: Fix lseek error check in state_mtd_peb_read()

with | large seek offsets. While at it, make sure to populate return error | code from 'errno'. | | Signed-off-by: Andrey Smirnov | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- src/barebox-state/backend_bucket_circular.c | 7 +++ 1 file changed, 3 insertions(+), 4

[OSS-Tools] [PATCH dt-utils 06/13] state: backend_bucket_circular: mark block as bad if mtd_peb_torture() failed

() and then directly afterwards. | | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- src/barebox-state/backend_bucket_circular.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/barebox-state/backend_bucket_circular.c b/src/barebox-state/backend_bucket_circular.c index

[OSS-Tools] [PATCH dt-utils 02/13] state: Fix lseek error check in state_backend_bucket_direct_write()

problems with | large seek offsets. While at it, make sure to populate return error | code from 'errno'. | | Signed-off-by: Andrey Smirnov | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- src/barebox-state/backend_bucket_direct.c | 7 +++ 1 file changed, 3

[OSS-Tools] [PATCH dt-utils 09/13] state: backend_storage: harmonize code with barebox

| if MTD is present. Exclude it from the build if MTD is not enabled. | | Signed-off-by: Lucas Stach | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- configure.ac| 2 ++ src/barebox-state/backend_storage.c | 6 -- 2 files changed, 6 insertions(+), 2

[OSS-Tools] [PATCH dt-utils 11/13] state: harmonize code with barebox

as can be seen from the | phytec-som-am335x/board.c change. (The check for state != NULL could be | dropped already before.) | | Signed-off-by: Uwe Kleine-König | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- configure.ac | 2 ++ src/state.h | 36

[OSS-Tools] [PATCH dt-utils 12/13] configure: remove build time option '--disable-logging'

If enabled it defined the C preprocessor macro 'ENABLE_LOGGING' which wasn't used anywhere. Signed-off-by: Ulrich Ölmann --- configure.ac | 8 1 file changed, 8 deletions(-) diff --git a/configure.ac b/configure.ac index c2486af9436f..5dd17b20809b 100644 --- a/configure.ac +++ b

[OSS-Tools] [PATCH dt-utils 04/13] state: Fix lseek error check in state_mtd_peb_write()

with | large seek offsets. While at it, make sure to populate return error | code from 'errno'. | | Signed-off-by: Andrey Smirnov | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- src/barebox-state/backend_bucket_circular.c | 7 +++ 1 file changed, 3 insertions

[OSS-Tools] [PATCH dt-utils 07/13] state: drop unused code and declarations for non-existing functions

. | state_backend_dtb_file() and state_backend_raw_file() were dropped in | c999b507da98 ("state: Refactor state framework"). | | Signed-off-by: Uwe Kleine-König | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- src/barebox-state/state.c | 7 --- s

[OSS-Tools] [PATCH dt-utils 01/13] state: Fix lseek error check in state_backend_bucket_direct_read()

problems with | large seek offsets. While at it, make sure to populate return error | code from 'errno'. | | Signed-off-by: Andrey Smirnov | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- src/barebox-state/backend_bucket_direct.c | 16 1 file

[OSS-Tools] [PATCH dt-utils 13/13] configure: remove build time option '--enable-debug'

If enabled it defined the C preprocessor macro 'DEBUG' which wasn't used anywhere. Signed-off-by: Ulrich Ölmann --- configure.ac | 8 1 file changed, 8 deletions(-) diff --git a/configure.ac b/configure.ac index 5dd17b20809b..d679fa335919 100644 --- a/configure.ac +++ b/configure.ac

[OSS-Tools] [PATCH dt-utils 08/13] state: keep backward compatibility

. | This change makes backward compatibility explicit, else it complains in | the read function as well. With some more debug output it helps the | developer to do things right. | | Signed-off-by: Juergen Borleis | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann

[OSS-Tools] [PATCH dt-utils 05/13] state: check length

will panic barebox. | | Check if the value is sane. Make read_len unsigned to avoid negative | values. | | Signed-off-by: Jan Remmet | Signed-off-by: Sascha Hauer Signed-off-by: Ulrich Ölmann --- src/barebox-state/backend_bucket_direct.c | 7 ++- 1 file changed, 6 insertions(+), 1

[OSS-Tools] [PATCH platsch 4/5] README.rst: fix typos

Signed-off-by: Ulrich Ölmann --- README.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/README.rst b/README.rst index 96337bfd49f2..c1e914990ea8 100644 --- a/README.rst +++ b/README.rst @@ -1,7 +1,7 @@ platsch - Splash Screen Application

[OSS-Tools] [PATCH platsch 5/5] README.rst: fix documented purpose of commandline arguments

Signed-off-by: Ulrich Ölmann --- README.rst | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/README.rst b/README.rst index c1e914990ea8..e318120605e6 100644 --- a/README.rst +++ b/README.rst @@ -106,10 +106,11 @@ Therefore the above settings can be supplied via

[OSS-Tools] [PATCH platsch 1/5] avoid unnecessary indirections

Signed-off-by: Ulrich Ölmann --- platsch.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/platsch.c b/platsch.c index dfa42dc9d544..c75f934935f2 100644 --- a/platsch.c +++ b/platsch.c @@ -398,9 +398,9 @@ static int set_env_connector_mode(drmModeConnector *conn

[OSS-Tools] [PATCH platsch 2/5] use pointers to immutable strings for cmdline options

Signed-off-by: Ulrich Ölmann --- platsch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platsch.c b/platsch.c index c75f934935f2..8228b2f8a886 100644 --- a/platsch.c +++ b/platsch.c @@ -565,8 +565,8 @@ int main(int argc, char *argv[]) char drmdev[128

[OSS-Tools] [PATCH platsch 3/5] allow directory/basename selection via environment

connector. [1] https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html Signed-off-by: Ulrich Ölmann --- README.rst | 12 platsch.c | 9 + 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/README.rst b/README.rst index 07f60177b510