Re: [PATCH v2 2/2] Return list of all threads in given application

2016-07-04 Thread Nadav Har'El
Hi, thanks. Looks mostly good but some comments below. On Mon, Jul 4, 2016 at 7:26 PM, Justin Cinkelj wrote: > Signed-off-by: Justin Cinkelj > --- > Makefile | 1 + > core/osv_c_wrappers.cc | 39

Re: [PATCH v2 1/2] app: execute function on all threads of one application

2016-07-04 Thread Nadav Har'El
Thanks. Nitpick (but I'll commit anyway as-is): I think you could have used a const reference to the thread th1 instead of a regular reference. -- Nadav Har'El n...@scylladb.com On Mon, Jul 4, 2016 at 7:26 PM, Justin Cinkelj wrote: > Application is identified by one

[PATCH v2 2/2] Return list of all threads in given application

2016-07-04 Thread Justin Cinkelj
Signed-off-by: Justin Cinkelj --- Makefile | 1 + core/osv_c_wrappers.cc | 39 +++ include/osv/osv_c_wrappers.h | 27 +++ 3 files changed, 67 insertions(+) create mode 100644

[PATCH v2 1/2] app: execute function on all threads of one application

2016-07-04 Thread Justin Cinkelj
Application is identified by one of its threads. Signed-off-by: Justin Cinkelj --- core/app.cc| 8 include/osv/app.hh | 5 + 2 files changed, 13 insertions(+) diff --git a/core/app.cc b/core/app.cc index 7fa76a7..ea00661 100644 --- a/core/app.cc +++